FormatMapping::mapMainArticle() - Code Metrics - Inspection of "Mapping function rest entity" - KLYgarage/onesdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#21)

by kenny

created 2018-07-04 07:10 UTC

FormatMapping::mapMainArticle() C

↳ Parent: FormatMapping

Complexity

Conditions	13
Paths	2

Size

Total Lines

118

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
nc	2
nop	1
dl	0
loc	118
rs	5.2933
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace one;

use One\Model\Article;

class FormatMapping {

	/**
	 * map a single article to main attributes in Article Class
	 * @param  string $singleJsonArticle JSON response
	 * @return \One\Model\Article                   An Article Object
	 */
	public function mapMainArticle($singleJsonArticle) {

		$decoded_article = $singleJsonArticle;

		if (!is_null($this->jsonToArray($singleJsonArticle))) {
			$decoded_article = $this->jsonToArray($singleJsonArticle);
		}

		$data_article = $decoded_article['data'];

		$title = function () use ($data_article) {
			if (isset($data_article['title'])) {
				return $data_article['title'];
			}
			return null;
		};

		$body = function () use ($data_article) {
			if (isset($data_article['body'])) {
				return $data_article['body'];
			}
			return null;
		};

		$source = function () use ($data_article) {
			if (isset($data_article['source'])) {
				return $data_article['source'];
			}
			return null;
		};

		$uniqueId = function () use ($data_article) {
			if (isset($data_article['uniqueId'])) {
				return $data_article['uniqueId'];
			}
			return null;
		};

		$typeId = function () use ($data_article) {
			if (isset($data_article['type']['type_id'])) {
				return $data_article['type']['type_id'];
			}
			return null;
		};

		$categoryId = function () use ($data_article) {
			if (isset($data_article['category']['category_id'])) {
				return $data_article['category']['category_id'];
			}
			return null;
		};

		$reporter = function () use ($data_article) {
			if (isset($data_article['reporter'])) {
				return $data_article['reporter'];
			}
			return null;
		};

		$lead = function () use ($data_article) {
			if (isset($data_article['lead'])) {
				return $data_article['lead'];
			}
			return null;
		};

		$tags = function () use ($data_article) {
			if (isset($data_article['tags']['tag_name'])) {
				return $data_article['tags']['tag_name'];
			}
			return null;
		};

		$publishedAt = function () use ($data_article) {
			if (isset($data_article['published_at'])) {
				return $data_article['published_at'];
			}
			return null;
		};

		$identifier = function () use ($data_article) {
			if (isset($data_article['id'])) {
				return $data_article['id'];
			}
			return null;
		};

		$article = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$article = new Article(

			$title(),

			$body(),

			$source(),

			$uniqueId(),

			$typeId(),

			$categoryId(),

			$reporter(),

			$lead(),

			$tags(),

			$publishedAt(),

			$identifier()

		);

		return $article;

	}

	/**
	 * Convert JSON string to associative array
	 * @param  string $jsonResponse
	 * @return array if it is valid json, null otherwise
	 */
	public function jsonToArray($jsonResponse) {

		try {
			return json_decode($jsonResponse, TRUE);

		} catch (\Exception $e) {
			return null;
		}

	}

}


1			<?php
2
3			namespace one;
4
5			use One\Model\Article;
6
7			class FormatMapping {
8
9			/**
10			* map a single article to main attributes in Article Class
11			* @param string $singleJsonArticle JSON response
12			* @return \One\Model\Article An Article Object
13			*/
14			public function mapMainArticle($singleJsonArticle) {
15
16			$decoded_article = $singleJsonArticle;
17
18			if (!is_null($this->jsonToArray($singleJsonArticle))) {
19			$decoded_article = $this->jsonToArray($singleJsonArticle);
20			}
21
22			$data_article = $decoded_article['data'];
23
24			$title = function () use ($data_article) {
25			if (isset($data_article['title'])) {
26			return $data_article['title'];
27			}
28			return null;
29			};
30
31			$body = function () use ($data_article) {
32			if (isset($data_article['body'])) {
33			return $data_article['body'];
34			}
35			return null;
36			};
37
38			$source = function () use ($data_article) {
39			if (isset($data_article['source'])) {
40			return $data_article['source'];
41			}
42			return null;
43			};
44
45			$uniqueId = function () use ($data_article) {
46			if (isset($data_article['uniqueId'])) {
47			return $data_article['uniqueId'];
48			}
49			return null;
50			};
51
52			$typeId = function () use ($data_article) {
53			if (isset($data_article['type']['type_id'])) {
54			return $data_article['type']['type_id'];
55			}
56			return null;
57			};
58
59			$categoryId = function () use ($data_article) {
60			if (isset($data_article['category']['category_id'])) {
61			return $data_article['category']['category_id'];
62			}
63			return null;
64			};
65
66			$reporter = function () use ($data_article) {
67			if (isset($data_article['reporter'])) {
68			return $data_article['reporter'];
69			}
70			return null;
71			};
72
73			$lead = function () use ($data_article) {
74			if (isset($data_article['lead'])) {
75			return $data_article['lead'];
76			}
77			return null;
78			};
79
80			$tags = function () use ($data_article) {
81			if (isset($data_article['tags']['tag_name'])) {
82			return $data_article['tags']['tag_name'];
83			}
84			return null;
85			};
86
87			$publishedAt = function () use ($data_article) {
88			if (isset($data_article['published_at'])) {
89			return $data_article['published_at'];
90			}
91			return null;
92			};
93
94			$identifier = function () use ($data_article) {
95			if (isset($data_article['id'])) {
96			return $data_article['id'];
97			}
98			return null;
99			};
100
101			$article = array();
			0 ignored issues – show Unused Code introduced 2018-07-04 07:14 UTC by Report Bug Copy Issue Report `$article` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
102
103			$article = new Article(
104
105			$title(),
106
107			$body(),
108
109			$source(),
110
111			$uniqueId(),
112
113			$typeId(),
114
115			$categoryId(),
116
117			$reporter(),
118
119			$lead(),
120
121			$tags(),
122
123			$publishedAt(),
124
125			$identifier()
126
127			);
128
129			return $article;
130
131			}
132
133			/**
134			* Convert JSON string to associative array
135			* @param string $jsonResponse
136			* @return array if it is valid json, null otherwise
137			*/
138			public function jsonToArray($jsonResponse) {
139
140			try {
141			return json_decode($jsonResponse, TRUE);
142
143			} catch (\Exception $e) {
144			return null;
145			}
146
147			}
148
149			}
150

KLYgarage / onesdk

Pull Request — master (#21)

FormatMapping::mapMainArticle() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like