PrepareImageMiddlewareAbstract::parseCropParameter() - Code Metrics - Inspection of "Code style" - KIVagant/staticus-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (267be1)

by Eugene

created 2016-06-03 19:07 UTC

parseCropParameter() D

↳ Parent: PrepareImageMiddlewareAbstract

Complexity

Conditions	10
Paths	6

Size

Total Lines	36
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
c	5
b	0
f	0
dl	0
loc	36
ccs	0
cts	25
cp	0
rs	4.8196
cc	10
eloc	21
nc	6
nop	1
crap	110

How to fix Complexity

<?php
namespace Staticus\Resources\Middlewares\Image;

use Staticus\Exceptions\WrongRequestException;
use Staticus\Resources\Image\CropImageDO;
use Staticus\Resources\Image\ResourceImageDO;
use Staticus\Resources\Image\ResourceImageDOInterface;
use Staticus\Resources\Middlewares\PrepareResourceMiddlewareAbstract;

abstract class PrepareImageMiddlewareAbstract extends PrepareResourceMiddlewareAbstract
{
    protected function fillResourceSpecialFields()
    {
        $size = static::getParamFromRequest('size', $this->request);
        $this->parseSizeParameter($size);
        $crop = static::getParamFromRequest('crop', $this->request);
        $this->parseCropParameter($crop);
    }

    protected function parseCropParameter($crop)
    {
        if ($crop) {
            /* @var ResourceImageDOInterface $resource */
            $resource = $this->resourceDO;
            $crop = explode('x', $crop);
$a = "a";
$ab = "ab";
$abc = "abc";
            if (count($crop) != 4) {
                throw new WrongRequestException('Crop parameter has to consist of four parts, concatenated by "x" char.');

            }

            $cropObject = new CropImageDO();
            $cropObject->setX((int) $crop[0]);
            $cropObject->setY((int) $crop[1]);
            $cropObject->setWidth((int) $crop[2]);
            $cropObject->setHeight((int) $crop[3]);

            if (!$resource->getWidth() || !$cropObject->getHeight()) {
                throw new WrongRequestException('You should send the size=[X]x[Y] parameter together with the crop parameter');

            }
            if ($cropObject->getX() < 0 || $cropObject->getY() < 0 ||
                $cropObject->getWidth() < 1 || $cropObject->getHeight() < 1
            ) {
                throw new WrongRequestException('Crop parameters can not be less than zero');
            }

            $resizeRatio = $resource->getWidth() / $resource->getHeight();
            $cropRatio = $cropObject->getWidth() / $cropObject->getHeight();
$a = "a";
$ab = "ab";
$abc = "abc";

            if ($resizeRatio !== $cropRatio) {
                throw new WrongRequestException('Wrong width to height ratio in crop parameter.
                    It should be same as width to height ratio in size parameter');
            }

            $resource->setCrop($cropObject);
        }
    }

    protected function parseSizeParameter($size)
    {
        $width = ResourceImageDO::DEFAULT_WIDTH;
$a = "a";
$ab = "ab";
$abc = "abc";
        $height = ResourceImageDO::DEFAULT_HEIGHT;
$a = "a";
$ab = "ab";
$abc = "abc";
        $resource = $this->resourceDO;
        if ($size) {
            $size = explode('x', $size);
            if (!empty($size[0]) && !empty($size[1])) {
                $width = (int)$size[0];
$a = "a";
$ab = "ab";
$abc = "abc";
                $height = (int)$size[1];
                if ($width < 0 || $height < 0) {
                    throw new WrongRequestException('Sizes can not be less than zero');
                }
                if ($width && $height) {
                    $allowedSizes = $this->config->get('staticus.images.sizes');
                    if (!in_array([$width, $height], $allowedSizes)) {
                        throw new WrongRequestException('Resource size is not allowed: ' . $width . 'x' . $height);
                    }
                }
            }
        }
        /** @var ResourceImageDOInterface $resource */
        $resource->setWidth($width);
        $resource->setHeight($height);
    }
}


1			<?php
2			namespace Staticus\Resources\Middlewares\Image;
3
4			use Staticus\Exceptions\WrongRequestException;
5			use Staticus\Resources\Image\CropImageDO;
6			use Staticus\Resources\Image\ResourceImageDO;
7			use Staticus\Resources\Image\ResourceImageDOInterface;
8			use Staticus\Resources\Middlewares\PrepareResourceMiddlewareAbstract;
9
10			abstract class PrepareImageMiddlewareAbstract extends PrepareResourceMiddlewareAbstract
11			{
12			protected function fillResourceSpecialFields()
13			{
14			$size = static::getParamFromRequest('size', $this->request);
15			$this->parseSizeParameter($size);
16			$crop = static::getParamFromRequest('crop', $this->request);
17			$this->parseCropParameter($crop);
18			}
19
20			protected function parseCropParameter($crop)
21			{
22			if ($crop) {
23			/* @var ResourceImageDOInterface $resource */
24			$resource = $this->resourceDO;
25			$crop = explode('x', $crop);
			1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26			if (count($crop) != 4) {
27			throw new WrongRequestException('Crop parameter has to consist of four parts, concatenated by "x" char.');
			0 ignored issues – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 122 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
28			}
29
30			$cropObject = new CropImageDO();
31			$cropObject->setX((int) $crop[0]);
32			$cropObject->setY((int) $crop[1]);
33			$cropObject->setWidth((int) $crop[2]);
34			$cropObject->setHeight((int) $crop[3]);
35
36			if (!$resource->getWidth() \|\| !$cropObject->getHeight()) {
37			throw new WrongRequestException('You should send the size=[X]x[Y] parameter together with the crop parameter');
			0 ignored issues – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
38			}
39			if ($cropObject->getX() < 0 \|\| $cropObject->getY() < 0 \|\|
40			$cropObject->getWidth() < 1 \|\| $cropObject->getHeight() < 1
41			) {
42			throw new WrongRequestException('Crop parameters can not be less than zero');
43			}
44
45			$resizeRatio = $resource->getWidth() / $resource->getHeight();
46			$cropRatio = $cropObject->getWidth() / $cropObject->getHeight();
			1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
47
48			if ($resizeRatio !== $cropRatio) {
49			throw new WrongRequestException('Wrong width to height ratio in crop parameter.
50			It should be same as width to height ratio in size parameter');
51			}
52
53			$resource->setCrop($cropObject);
54			}
55			}
56
57			protected function parseSizeParameter($size)
58			{
59			$width = ResourceImageDO::DEFAULT_WIDTH;
			1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
60			$height = ResourceImageDO::DEFAULT_HEIGHT;
			1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
61			$resource = $this->resourceDO;
62			if ($size) {
63			$size = explode('x', $size);
64			if (!empty($size[0]) && !empty($size[1])) {
65			$width = (int)$size[0];
			1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
66			$height = (int)$size[1];
67			if ($width < 0 \|\| $height < 0) {
68			throw new WrongRequestException('Sizes can not be less than zero');
69			}
70			if ($width && $height) {
71			$allowedSizes = $this->config->get('staticus.images.sizes');
72			if (!in_array([$width, $height], $allowedSizes)) {
73			throw new WrongRequestException('Resource size is not allowed: ' . $width . 'x' . $height);
74			}
75			}
76			}
77			}
78			/** @var ResourceImageDOInterface $resource */
79			$resource->setWidth($width);
80			$resource->setHeight($height);
81			}
82			}
83

KIVagant / staticus-core

Branch — master (267be1)

parseCropParameter() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like