ImageCompressMiddlewareAbstract::compress() - Code Metrics - Inspection of "Code style" - KIVagant/staticus-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (267be1)

by Eugene

created 2016-06-03 19:07 UTC

ImageCompressMiddlewareAbstract::compress() C

↳ Parent: ImageCompressMiddlewareAbstract

Complexity

Conditions	12
Paths	9

Size

Total Lines	27
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	27
ccs	0
cts	22
cp	0
rs	5.1612
cc	12
eloc	18
nc	9
nop	5
crap	156

How to fix Complexity

<?php
namespace Staticus\Resources\Middlewares\Image;

use League\Flysystem\FilesystemInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Staticus\Config\ConfigInterface;
use Staticus\Resources\ResourceDOInterface;

abstract class ImageCompressMiddlewareAbstract extends ImagePostProcessingMiddlewareAbstract
{
    /**
     * @var ConfigInterface
     */
    protected $config;

    public function __construct(ResourceDOInterface $resourceDO, FilesystemInterface $filesystem, ConfigInterface $config)

    {
        parent::__construct($resourceDO, $filesystem);
        $this->config = $config;
    }

    public function __invoke(
        ServerRequestInterface $request,
        ResponseInterface $response,
        callable $next = null
    )
    {
        parent::__invoke($request, $response, $next);
        if (!$this->isSupportedResponse($response)) {

            return $next($request, $response);
        }
        if ($this->isAllowed()) {
            $interlacing = $this->config->get('staticus.images.compress.interlace', false);
            $quality = $this->config->get('staticus.images.compress.quality', false);
$a = "a";
$ab = "ab";
$abc = "abc";
            $maxWidth = $this->config->get('staticus.images.compress.maxWidth', false);
$a = "a";
$ab = "ab";
$abc = "abc";
            $maxHeight = $this->config->get('staticus.images.compress.maxHeight', false);
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->compress($this->resourceDO->getFilePath(), $interlacing, $quality, $maxWidth, $maxHeight);
        }

        return $next($request, $response);
    }

    public function compress($sourcePath, $interlacing = null, $quality = null, $maxWidth = null, $maxHeight = null)
    {
        if (!$interlacing && !$quality && (!$maxWidth || !$maxHeight)) {

            return;
        }
        $imagick = $this->getImagick($sourcePath);
        if ($interlacing) {
            $imagick->setInterlaceScheme($interlacing);
        }
        if ($quality) {
            $imagick->setImageCompressionQuality($quality);
        }
        if (
            // if width and height is already set in resourceDO, this middleware MUST not call default resizing
            !$this->resourceDO->getDimension()
            && $maxWidth
            && $imagick->getImageWidth() > $maxWidth
            && $maxHeight
            && $imagick->getImageHeight() > $maxHeight
        ) {
            $imagick->adaptiveResizeImage($maxWidth, $maxHeight, true);
        }
        $imagick->writeImage($sourcePath);
        $imagick->clear();
        $imagick->destroy();
    }

    /**
     * @return bool
     */
    protected function isAllowed()

    {
        return $this->config->get('staticus.images.compress.compress', false)
        && (
            $this->resourceDO->isNew() // For the POST method
            || $this->resourceDO->isRecreate() // For the POST method
        )
        && $this->filesystem->has($this->resourceDO->getFilePath());
    }
}


1		<?php
2		namespace Staticus\Resources\Middlewares\Image;
3
4		use League\Flysystem\FilesystemInterface;
5		use Psr\Http\Message\ResponseInterface;
6		use Psr\Http\Message\ServerRequestInterface;
7		use Staticus\Config\ConfigInterface;
8		use Staticus\Resources\ResourceDOInterface;
9
10		abstract class ImageCompressMiddlewareAbstract extends ImagePostProcessingMiddlewareAbstract
11		{
12		/**
13		* @var ConfigInterface
14		*/
15		protected $config;
16
17		public function __construct(ResourceDOInterface $resourceDO, FilesystemInterface $filesystem, ConfigInterface $config)
		0 ignored issues – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 122 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
18		{
19		parent::__construct($resourceDO, $filesystem);
20		$this->config = $config;
21		}
22
23		public function __invoke(
24		ServerRequestInterface $request,
25		ResponseInterface $response,
26		callable $next = null
27		)
28		{
29		parent::__invoke($request, $response, $next);
30		if (!$this->isSupportedResponse($response)) {
31
32		return $next($request, $response);
33		}
34		if ($this->isAllowed()) {
35		$interlacing = $this->config->get('staticus.images.compress.interlace', false);
36		$quality = $this->config->get('staticus.images.compress.quality', false);
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37		$maxWidth = $this->config->get('staticus.images.compress.maxWidth', false);
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
38		$maxHeight = $this->config->get('staticus.images.compress.maxHeight', false);
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
39		$this->compress($this->resourceDO->getFilePath(), $interlacing, $quality, $maxWidth, $maxHeight);
40		}
41
42		return $next($request, $response);
43		}
44
45		public function compress($sourcePath, $interlacing = null, $quality = null, $maxWidth = null, $maxHeight = null)
46		{
47		if (!$interlacing && !$quality && (!$maxWidth \|\| !$maxHeight)) {
48
49		return;
50		}
51		$imagick = $this->getImagick($sourcePath);
52		if ($interlacing) {
53		$imagick->setInterlaceScheme($interlacing);
54		}
55		if ($quality) {
56		$imagick->setImageCompressionQuality($quality);
57		}
58		if (
59		// if width and height is already set in resourceDO, this middleware MUST not call default resizing
60		!$this->resourceDO->getDimension()
61		&& $maxWidth
62		&& $imagick->getImageWidth() > $maxWidth
63		&& $maxHeight
64		&& $imagick->getImageHeight() > $maxHeight
65		) {
66		$imagick->adaptiveResizeImage($maxWidth, $maxHeight, true);
67		}
68		$imagick->writeImage($sourcePath);
69		$imagick->clear();
70		$imagick->destroy();
71		}
72
73		/**
74		* @return bool
75		*/
76	View Code Duplication	protected function isAllowed()
		1 ignored issue – show Duplication introduced 2016-06-03 16:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		return $this->config->get('staticus.images.compress.compress', false)
79		&& (
80		$this->resourceDO->isNew() // For the POST method
81		\|\| $this->resourceDO->isRecreate() // For the POST method
82		)
83		&& $this->filesystem->has($this->resourceDO->getFilePath());
84		}
85		}
86

KIVagant / staticus-core

Branch — master (267be1)

ImageCompressMiddlewareAbstract::compress() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like