DestroyResourceCommand::__invoke() - Code Metrics - Inspection of "Code style" - KIVagant/staticus-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (267be1)

by Eugene

created 2016-06-03 19:07 UTC

DestroyResourceCommand::__invoke() C

↳ Parent: DestroyResourceCommand

Complexity

Conditions	16
Paths	3

Size

Total Lines	44
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	34
CRAP Score	16.0059

Importance

Changes	5
Bugs	0	Features	1

Metric	Value
c	5
b	0
f	1
dl	0
loc	44
ccs	34
cts	35
cp	0.9714
rs	5.0151
cc	16
eloc	32
nc	3
nop	1
crap	16.0059

How to fix Complexity

<?php
namespace Staticus\Resources\Commands;

use League\Flysystem\FilesystemInterface;
use Staticus\Resources\Exceptions\CommandErrorException;
use Staticus\Resources\ResourceDOAbstract;
use Staticus\Resources\ResourceDOInterface;

class DestroyResourceCommand implements ResourceCommandInterface
{
    /**
     * @var ResourceDOInterface
     */
    protected $resourceDO;
    /**
     * @var FilesystemInterface
     */
    protected $filesystem;

    public function __construct(ResourceDOInterface $resourceDO, FilesystemInterface $filesystem)
    {
        $this->resourceDO = $resourceDO;
        $this->filesystem = $filesystem;
    }

    /**
     * @param bool $byPathOnly If true, no search on disk will be executed
     * @return ResourceDOInterface
     */
    public function __invoke($byPathOnly = false)
    {
        $uuid = $this->resourceDO->getUuid();
$a = "a";
$ab = "ab";
$abc = "abc";
        $type = $this->resourceDO->getType();
$a = "a";
$ab = "ab";
$abc = "abc";
        $variant = $this->resourceDO->getVariant();
$a = "a";
$ab = "ab";
$abc = "abc";
        $version = $this->resourceDO->getVersion();
$a = "a";
$ab = "ab";
$abc = "abc";
        $baseDir = $this->resourceDO->getBaseDirectory();
$a = "a";
$ab = "ab";
$abc = "abc";
        $namespace = $this->resourceDO->getNamespace();
        $filePath = $this->resourceDO->getFilePath();
$a = "a";
$ab = "ab";
$abc = "abc";
        if (!$uuid || !$type || !$baseDir || !$filePath) {
            throw new CommandErrorException('Cannot destroy the empty resource');
        }
        if ($byPathOnly) {
            $this->deleteFile($filePath);
        } else {
            $command = new FindResourceOptionsCommand($this->resourceDO, $this->filesystem);
            $result = $command();
$a = "a";
$ab = "ab";
$abc = "abc";
            foreach ($result as $item) {
                if (
                    $item[ResourceDOAbstract::TOKEN_TYPE] !== $type
                    || $item['filename'] !== $uuid
                    || ($namespace && ($item[ResourceDOAbstract::TOKEN_NAMESPACE] !== $namespace))
                ) {
                    continue;
                }
                if ($version !== ResourceDOInterface::DEFAULT_VERSION) {
                    if (
                        $variant === $item[ResourceDOAbstract::TOKEN_VARIANT] // delete versions only for current variant

                        && $version === (int)$item[ResourceDOAbstract::TOKEN_VERSION]
                    ) {
                        $this->deleteFile($item['path']);
                    }
                } elseif ($variant !== ResourceDOInterface::DEFAULT_VARIANT) {
                    if ($variant === $item[ResourceDOAbstract::TOKEN_VARIANT]) {
                        $this->deleteFile($item['path']);
                    }
                } else {
                    $this->deleteFile($item['path']);
                }
            }
        }

        return $this->resourceDO;
    }

    protected function deleteFile($filePath)
    {
        // If file is already gone somewhere, it is OK for us
        if ($this->filesystem->has($filePath) && !$this->filesystem->delete($filePath)) {
            throw new CommandErrorException('The file cannot be removed: ' . $filePath);
        }
    }
}

1		<?php
2		namespace Staticus\Resources\Commands;
3
4		use League\Flysystem\FilesystemInterface;
5		use Staticus\Resources\Exceptions\CommandErrorException;
6		use Staticus\Resources\ResourceDOAbstract;
7		use Staticus\Resources\ResourceDOInterface;
8
9		class DestroyResourceCommand implements ResourceCommandInterface
10		{
11		/**
12		* @var ResourceDOInterface
13		*/
14		protected $resourceDO;
15		/**
16		* @var FilesystemInterface
17		*/
18		protected $filesystem;
19
20	13	public function __construct(ResourceDOInterface $resourceDO, FilesystemInterface $filesystem)
21		{
22	13	$this->resourceDO = $resourceDO;
23	13	$this->filesystem = $filesystem;
24	13	}
25
26		/**
27		* @param bool $byPathOnly If true, no search on disk will be executed
28		* @return ResourceDOInterface
29		*/
30	13	public function __invoke($byPathOnly = false)
31		{
32	13	$uuid = $this->resourceDO->getUuid();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33	13	$type = $this->resourceDO->getType();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34	13	$variant = $this->resourceDO->getVariant();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
35	13	$version = $this->resourceDO->getVersion();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
36	13	$baseDir = $this->resourceDO->getBaseDirectory();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37	13	$namespace = $this->resourceDO->getNamespace();
38	13	$filePath = $this->resourceDO->getFilePath();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
39	13	if (!$uuid \|\| !$type \|\| !$baseDir \|\| !$filePath) {
40	1	throw new CommandErrorException('Cannot destroy the empty resource');
41		}
42	12	if ($byPathOnly) {
43	6	$this->deleteFile($filePath);
44	6	} else {
45	6	$command = new FindResourceOptionsCommand($this->resourceDO, $this->filesystem);
46	6	$result = $command();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
47	6	foreach ($result as $item) {
48		if (
49	6	$item[ResourceDOAbstract::TOKEN_TYPE] !== $type
50	6	\|\| $item['filename'] !== $uuid
51	6	\|\| ($namespace && ($item[ResourceDOAbstract::TOKEN_NAMESPACE] !== $namespace))
52	6	) {
53		continue;
54		}
55	6	if ($version !== ResourceDOInterface::DEFAULT_VERSION) {
56		if (
57	2	$variant === $item[ResourceDOAbstract::TOKEN_VARIANT] // delete versions only for current variant
		0 ignored issues – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 121 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
58	2	&& $version === (int)$item[ResourceDOAbstract::TOKEN_VERSION]
59	2	) {
60	2	$this->deleteFile($item['path']);
61	2	}
62	6	} elseif ($variant !== ResourceDOInterface::DEFAULT_VARIANT) {
63	2	if ($variant === $item[ResourceDOAbstract::TOKEN_VARIANT]) {
64	2	$this->deleteFile($item['path']);
65	2	}
66	2	} else {
67	2	$this->deleteFile($item['path']);
68		}
69	6	}
70		}
71
72	12	return $this->resourceDO;
73		}
74
75	12	protected function deleteFile($filePath)
76		{
77		// If file is already gone somewhere, it is OK for us
78	12	if ($this->filesystem->has($filePath) && !$this->filesystem->delete($filePath)) {
79		throw new CommandErrorException('The file cannot be removed: ' . $filePath);
80		}
81		}
82		}

KIVagant / staticus-core

Branch — master (267be1)

DestroyResourceCommand::__invoke() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like