CopyResourceCommand::__invoke() - Code Metrics - Inspection of "Code style" - KIVagant/staticus-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (267be1)

by Eugene

created 2016-06-03 19:07 UTC

CopyResourceCommand::__invoke() D

↳ Parent: CopyResourceCommand

Complexity

Conditions	10
Paths	6

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	10

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	25
ccs	16
cts	16
cp	1
rs	4.8196
cc	10
eloc	16
nc	6
nop	1
crap	10

How to fix Complexity

<?php

namespace Staticus\Resources\Commands;

use League\Flysystem\FilesystemInterface;
use Staticus\Resources\Exceptions\CommandErrorException;
use Staticus\Resources\ResourceDOInterface;

class CopyResourceCommand implements ResourceCommandInterface
{
    /**
     * @var ResourceDOInterface
     */
    protected $originResourceDO;
    /**
     * @var ResourceDOInterface
     */
    protected $newResourceDO;
    /**
     * @var FilesystemInterface
     */
    protected $filesystem;

    public function __construct(ResourceDOInterface $originResourceDO, ResourceDOInterface $newResourceDO, FilesystemInterface $filesystem)

    {
        $this->originResourceDO = $originResourceDO;
        $this->newResourceDO = $newResourceDO;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->filesystem = $filesystem;
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @param bool $replace Replace exist file or just do nothing
     * @return ResourceDOInterface
     * @throws CommandErrorException
     */
    public function __invoke($replace = false)
    {
        if (!$this->originResourceDO->getName() || !$this->originResourceDO->getType()) {
            throw new CommandErrorException('Source resource cannot be empty');
        }
        if (!$this->newResourceDO->getName() || !$this->newResourceDO->getType()) {
            throw new CommandErrorException('Destination resource cannot be empty');
        }
        $originPath = $this->originResourceDO->getFilePath();
        $newPath = $this->newResourceDO->getFilePath();
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($originPath === $newPath) {
            throw new CommandErrorException('Source and destination paths is equal');
        }
        if (!$this->filesystem->has($originPath)) {
            throw new CommandErrorException('Origin file is not exists: ' . $originPath);
        }
        $exists = $this->filesystem->has($newPath);
        if (!$exists || $replace) {
            $this->copyFile($originPath, $newPath, $exists && $replace);

            return $this->newResourceDO;
        }

        return $this->originResourceDO;
    }

    protected function copyFile($fromFullPath, $toFullPath, $replace = false)
    {
        $this->createDirectory(dirname($toFullPath));
        if ($replace) {
            $this->filesystem->delete($toFullPath);
        }
        if (!$this->filesystem->copy($fromFullPath, $toFullPath)) {
            throw new CommandErrorException('File cannot be copied to the path ' . $toFullPath);
        }
    }

    protected function createDirectory($directory)
    {
        if (!$this->filesystem->createDir($directory)) {
            throw new CommandErrorException('Can\'t create a directory: ' . $directory);
        }
    }
}

1		<?php
2
3		namespace Staticus\Resources\Commands;
4
5		use League\Flysystem\FilesystemInterface;
6		use Staticus\Resources\Exceptions\CommandErrorException;
7		use Staticus\Resources\ResourceDOInterface;
8
9		class CopyResourceCommand implements ResourceCommandInterface
10		{
11		/**
12		* @var ResourceDOInterface
13		*/
14		protected $originResourceDO;
15		/**
16		* @var ResourceDOInterface
17		*/
18		protected $newResourceDO;
19		/**
20		* @var FilesystemInterface
21		*/
22		protected $filesystem;
23
24	14	public function __construct(ResourceDOInterface $originResourceDO, ResourceDOInterface $newResourceDO, FilesystemInterface $filesystem)
		0 ignored issues – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 139 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
25		{
26	14	$this->originResourceDO = $originResourceDO;
27	14	$this->newResourceDO = $newResourceDO;
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
28	14	$this->filesystem = $filesystem;
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29	14	}
30
31		/**
32		* @param bool $replace Replace exist file or just do nothing
33		* @return ResourceDOInterface
34		* @throws CommandErrorException
35		*/
36	14	public function __invoke($replace = false)
37		{
38	14	if (!$this->originResourceDO->getName() \|\| !$this->originResourceDO->getType()) {
39	1	throw new CommandErrorException('Source resource cannot be empty');
40		}
41	13	if (!$this->newResourceDO->getName() \|\| !$this->newResourceDO->getType()) {
42	1	throw new CommandErrorException('Destination resource cannot be empty');
43		}
44	12	$originPath = $this->originResourceDO->getFilePath();
45	12	$newPath = $this->newResourceDO->getFilePath();
		1 ignored issue – show Coding Style introduced 2016-06-03 19:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
46	12	if ($originPath === $newPath) {
47	1	throw new CommandErrorException('Source and destination paths is equal');
48		}
49	11	if (!$this->filesystem->has($originPath)) {
50	1	throw new CommandErrorException('Origin file is not exists: ' . $originPath);
51		}
52	10	$exists = $this->filesystem->has($newPath);
53	10	if (!$exists \|\| $replace) {
54	9	$this->copyFile($originPath, $newPath, $exists && $replace);
55
56	9	return $this->newResourceDO;
57		}
58
59	1	return $this->originResourceDO;
60		}
61
62	9	protected function copyFile($fromFullPath, $toFullPath, $replace = false)
63		{
64	9	$this->createDirectory(dirname($toFullPath));
65	9	if ($replace) {
66	1	$this->filesystem->delete($toFullPath);
67	1	}
68	9	if (!$this->filesystem->copy($fromFullPath, $toFullPath)) {
69		throw new CommandErrorException('File cannot be copied to the path ' . $toFullPath);
70		}
71	9	}
72
73	9	protected function createDirectory($directory)
74		{
75	9	if (!$this->filesystem->createDir($directory)) {
76		throw new CommandErrorException('Can\'t create a directory: ' . $directory);
77		}
78		}
79		}

KIVagant / staticus-core

Branch — master (267be1)

CopyResourceCommand::__invoke() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like