AuthSessionMiddleware::__invoke() - Code Metrics - KIVagant/staticus-core - Measure and Improve Code Quality continuously with Scrutinizer

AuthSessionMiddleware::__invoke() B
last analyzed 2017-08-22 07:53 UTC

↳ Parent: AuthSessionMiddleware

Complexity

Conditions	4
Paths	4

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	12
cp	0
rs	8.6845
c	0
b	0
f	0
cc	4
eloc	12
nc	4
nop	3
crap	20

<?php
namespace Staticus\Auth;

use Staticus\Acl\Roles;
use Staticus\Config\ConfigInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Zend\Session\ManagerInterface;
use Zend\Session\SessionManager;
use Zend\Stratigility\MiddlewareInterface;

class AuthSessionMiddleware implements MiddlewareInterface
{
    protected $config;

    /**
     * @var ManagerInterface|SessionManager
     */
    protected $manager;

    /**
     * @var UserInterface|User
     */
    protected $user;

    public function __construct(ConfigInterface $config, ManagerInterface $manager, UserInterface $user)
    {
        $this->config = $config->get('auth.session');
        $this->manager = $manager;
        $this->user = $user;
    }
    public function __invoke(
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        ServerRequestInterface $request,
        ResponseInterface $response,
        callable $next = null
    )
    {
        /** @link http://framework.zend.com/manual/current/en/modules/zend.authentication.intro.html */
        if (array_key_exists('Zend_Auth', $_SESSION)) {

            /** @var \Zend\Stdlib\ArrayObject $auth */
            $auth = $_SESSION['Zend_Auth'];
            if ($auth->offsetExists('storage')) {

                /** @var StdClass $storage */
                $storage = $auth->storage;
                if (property_exists($storage, 'user_id')) {
                    $this->user->login($storage->user_id, [Roles::USER]);
                    $this->user->setNamespace(UserInterface::NAMESPACES . DIRECTORY_SEPARATOR . $storage->user_id);
                }
            }
        }

        return $next($request, $response);
    }
}


1			<?php
2			namespace Staticus\Auth;
3
4			use Staticus\Acl\Roles;
5			use Staticus\Config\ConfigInterface;
6			use Psr\Http\Message\ResponseInterface;
7			use Psr\Http\Message\ServerRequestInterface;
8			use Zend\Session\ManagerInterface;
9			use Zend\Session\SessionManager;
10			use Zend\Stratigility\MiddlewareInterface;
11
12			class AuthSessionMiddleware implements MiddlewareInterface
13			{
14			protected $config;
15
16			/**
17			* @var ManagerInterface\|SessionManager
18			*/
19			protected $manager;
20
21			/**
22			* @var UserInterface\|User
23			*/
24			protected $user;
25
26			public function __construct(ConfigInterface $config, ManagerInterface $manager, UserInterface $user)
27			{
28			$this->config = $config->get('auth.session');
29			$this->manager = $manager;
30			$this->user = $user;
31			}
32			public function __invoke(
			0 ignored issues – show Coding Style introduced 2017-08-09 08:15 UTC by Report Bug Copy Issue Report `__invoke` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
33			ServerRequestInterface $request,
34			ResponseInterface $response,
35			callable $next = null
36			)
37			{
38			/** @link http://framework.zend.com/manual/current/en/modules/zend.authentication.intro.html */
39			if (array_key_exists('Zend_Auth', $_SESSION)) {
40
41			/** @var \Zend\Stdlib\ArrayObject $auth */
42			$auth = $_SESSION['Zend_Auth'];
43			if ($auth->offsetExists('storage')) {
44
45			/** @var StdClass $storage */
46			$storage = $auth->storage;
47			if (property_exists($storage, 'user_id')) {
48			$this->user->login($storage->user_id, [Roles::USER]);
49			$this->user->setNamespace(UserInterface::NAMESPACES . DIRECTORY_SEPARATOR . $storage->user_id);
50			}
51			}
52			}
53
54			return $next($request, $response);
55			}
56			}
57

KIVagant / staticus-core

AuthSessionMiddleware::__invoke() B last analyzed 2017-08-22 07:53 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AuthSessionMiddleware::__invoke() B
last analyzed 2017-08-22 07:53 UTC