KIClubinfo / upont

back/src/KI/UserBundle/Command/FacegameAchievementsCommand.php

Spacing +4 added lines, -4 removed lines

@@ -47,23 +47,23 @@
             $wrongAnswers = $facegame->getWrongAnswers();
             $duration = $facegame->getDuration();
 
-            if ($wrongAnswers == 0 && $promoGame == $promoUser - 1 && $duration < 60 * 1000) {
+            if ($wrongAnswers == 0 && $promoGame == $promoUser - 1 && $duration < 60*1000) {
 
                 $achievementCheck = new AchievementCheckEvent(Achievement::GAME_BEFORE, $user);
                 $dispatcher->dispatch('upont.achievement', $achievementCheck);
 
-            } else if ($wrongAnswers == 0 && $promoGame == $promoUser && $duration < 60 * 1000) {
+            } else if ($wrongAnswers == 0 && $promoGame == $promoUser && $duration < 60*1000) {
 
                 $achievementCheck = new AchievementCheckEvent(Achievement::GAME_SELF, $user);
                 $dispatcher->dispatch('upont.achievement', $achievementCheck);
 
-            } else if ($wrongAnswers == 0 && $promoGame == $promoUser + 1 && $duration < 60 * 1000) {
+            } else if ($wrongAnswers == 0 && $promoGame == $promoUser + 1 && $duration < 60*1000) {
 
                 $achievementCheck = new AchievementCheckEvent(Achievement::GAME_NEXT, $user);
                 $dispatcher->dispatch('upont.achievement', $achievementCheck);
 
             }
-            if ($wrongAnswers == 0 && $promoGame < $promoUser && $facegame->getHardcore() && $duration < 60 * 1000) {
+            if ($wrongAnswers == 0 && $promoGame < $promoUser && $facegame->getHardcore() && $duration < 60*1000) {
 
                 $achievementCheck = new AchievementCheckEvent(Achievement::GAME_OLD, $user);
                 $dispatcher->dispatch('upont.achievement', $achievementCheck);

back/src/KI/CoreBundle/Helper/FormHelper.php

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 use Doctrine\ORM\EntityManager;
 use Symfony\Bundle\FrameworkBundle\Routing\Router;
 use Symfony\Component\Form\FormFactory;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RequestStack;
-use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 
 // Valide les formulaires pour une entité et affiche la réponse à la demande
 class FormHelper

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     public function formData($item, $method, $flush = true)
     {
         // On devine le formulaire à partir du chemin de la classe
-        $formName = str_replace('Entity', 'Form', get_class($item)) . 'Type';
+        $formName = str_replace('Entity', 'Form', get_class($item)).'Type';
         $form = $this->formFactory->create($formName, $item, ['method' => $method]);
         $form->handleRequest($this->request);
         $code = 400;

back/src/KI/CoreBundle/Helper/PaginateHelper.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityRepository;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpFoundation\Response;
 

Spacing +2 added lines, -2 removed lines

@@ -58,8 +58,8 @@
 
         // On compte le nombre total d'entrées dans la BDD
         $queryBuilder->select('count(o.id)');
-        foreach ($findBy as $key => $value){
-            $queryBuilder->andWhere('o.' . $key . ' = :' . $key);
+        foreach ($findBy as $key => $value) {
+            $queryBuilder->andWhere('o.'.$key.' = :'.$key);
             $queryBuilder->setParameter($key, $value);
         }
         $count = $queryBuilder->getQuery()->getSingleScalarResult();

back/src/KI/DvpBundle/Command/SendOrdersCommand.php

Unused Use Statements +1 added lines, -6 removed lines

@@ -2,17 +2,12 @@
 
 namespace KI\DvpBundle\Command;
 
-use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
-use Doctrine\ORM\NoResultException;
 use KI\DvpBundle\Entity\BasketDate;;
+use Swift_Message;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
-use Swift_Message;
-
 
 class SendOrdersCommand extends ContainerAwareCommand
 {

Spacing +5 added lines, -5 removed lines

@@ -4,7 +4,7 @@ 
 
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
 use Doctrine\ORM\NoResultException;
-use KI\DvpBundle\Entity\BasketDate;;
+use KI\DvpBundle\Entity\BasketDate; ;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -39,13 +39,13 @@ 
          */
         $basketDate = $query->getOneOrNullResult();
 
-        if($basketDate) {
+        if ($basketDate) {
 
             $orders = $basketDate->getOrders();
 
             // Envoi du mail
             $message = Swift_Message::newInstance()
-                ->setSubject('Commandes du ' . $basketDate->getDateRetrieve()->format('l d F Y'))
+                ->setSubject('Commandes du '.$basketDate->getDateRetrieve()->format('l d F Y'))
                 ->setFrom('noreply@upont.enpc.fr')
                 ->setTo('paniersprimeur@upont.enpc.fr')
                 ->setBody($this->getContainer()->get('twig')->render('KIDvpBundle::basket-orders.html.twig', [
@@ -72,7 +72,7 @@ 
 
         $count = $query->getSingleScalarResult();
 
-        while($count < 4) {
+        while ($count < 4) {
             $prevDate->modify('next thursday');
 
             $dateExists = $query = $em->createQuery('SELECT COUNT(date.id) 
@@ -81,7 +81,7 @@ 
                 ->setParameter('dateAdding', $prevDate)
                 ->getSingleScalarResult();
 
-            if($dateExists == 0) {
+            if ($dateExists == 0) {
                 $nextBasketDate = new BasketDate();
                 $nextBasketDate->setDateRetrieve($prevDate);
                 $em->persist($nextBasketDate);

back/src/KI/DvpBundle/Controller/BasketsController.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -3,11 +3,10 @@
 namespace KI\DvpBundle\Controller;
 
 use KI\CoreBundle\Controller\ResourceController;
+use Nelmio\ApiDocBundle\Annotation\ApiDoc;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
-use Nelmio\ApiDocBundle\Annotation\ApiDoc;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 class BasketsController extends ResourceController
 {

back/src/KI/UserBundle/Factory/UserFactory.php

Doc Comments +6 added lines

@@ -18,6 +18,12 @@
         $this->eventDispatcher = $eventDispatcher;
     }
 
+    /**
+     * @param string $key
+     * @param string $default_value
+     *
+     * @return string
+     */
     private function array_value($array, $key, $default_value = null)
     {
         if (!is_array($array))

Spacing +2 added lines, -2 removed lines

@@ -48,8 +48,8 @@
         $user->setEmail($email);
 
         $password = $this->array_value($attributes, 'password');
-        if(!$password) {
-            $password = substr(str_shuffle(strtolower(sha1(rand() . time() . 'salt'))), 0, 8);
+        if (!$password) {
+            $password = substr(str_shuffle(strtolower(sha1(rand().time().'salt'))), 0, 8);
             $attributes['password'] = $password;
         }
 

back/src/KI/UserBundle/Listener/SendMailUserRegistrationListener.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace KI\UserBundle\Listener;
 
-use KI\UserBundle\Entity\User;
 use KI\UserBundle\Event\UserRegistrationEvent;
 use Swift_Mailer;
 use Swift_Message;

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
         $this->swiftMailer->send($message);
 
         $message = Swift_Message::newInstance()
-            ->setSubject('[uPont] Nouvelle inscription (' . $username . ')')
+            ->setSubject('[uPont] Nouvelle inscription ('.$username.')')
             ->setFrom('noreply@upont.enpc.fr')
             ->setTo('root@clubinfo.enpc.fr')
             ->setBody($this->twigEngine->render('KIUserBundle::registration-ki.txt.twig', $attributes));

back/src/KI/UserBundle/Security/SsoEnpcLoginAuthenticator.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use Symfony\Component\Security\Core\Exception\CustomUserMessageAuthenticationException;
 use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
 use Symfony\Component\Security\Core\User\UserInterface;
-
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 
 

Spacing +3 added lines, -3 removed lines

@@ -67,7 +67,7 @@ 
         $username = $credentials['username'];
 
         $email = $credentials['mail'];
-        if(!preg_match('/@eleves\.enpc\.fr$/', $email))
+        if (!preg_match('/@eleves\.enpc\.fr$/', $email))
             throw new AccessDeniedException();
 
         $user = null;
@@ -78,7 +78,7 @@ 
 
         }
 
-        if(!$user) {
+        if (!$user) {
             $user = $this->userRepository->findOneBy(['email' => $credentials['mail']]);
         }
 
@@ -88,7 +88,7 @@ 
                 'firstName' => $credentials['givenName'],
                 'lastName' => ucwords(strtolower($credentials['sn'])),
                 'email' => $credentials['mail'],
-                'promo' => '0' . ( substr(strftime('%Y'), 2) + 3)
+                'promo' => '0'.(substr(strftime('%Y'), 2) + 3)
             ];
 
             $user = $this->userFactory->createUser($username, [], $credentials);

back/var/SymfonyRequirements.php

Doc Comments +2 added lines, -2 removed lines

@@ -223,7 +223,7 @@ 
      * Adds a mandatory requirement in form of a php.ini configuration.
      *
      * @param string        $cfgName           The configuration name used for ini_get()
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
+     * @param boolean|string $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
@@ -241,7 +241,7 @@ 
      * Adds an optional recommendation in form of a php.ini configuration.
      *
      * @param string        $cfgName           The configuration name used for ini_get()
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.

Switch Indentation +8 added lines, -8 removed lines

@@ -782,14 +782,14 @@
         $size = trim($size);
         $unit = strtolower(substr($size, -1, 1));
         switch ($unit) {
-            case 'g':
-                return $size * 1024 * 1024 * 1024;
-            case 'm':
-                return $size * 1024 * 1024;
-            case 'k':
-                return $size * 1024;
-            default:
-                return (int) $size;
+        case 'g':
+            return $size * 1024 * 1024 * 1024;
+        case 'm':
+            return $size * 1024 * 1024;
+        case 'k':
+            return $size * 1024;
+        default:
+            return (int) $size;
         }
     }
 

Spacing +12 added lines, -12 removed lines

@@ -49,11 +49,11 @@ 
      */
     public function __construct($fulfilled, $testMessage, $helpHtml, $helpText = null, $optional = false)
     {
-        $this->fulfilled = (bool) $fulfilled;
-        $this->testMessage = (string) $testMessage;
-        $this->helpHtml = (string) $helpHtml;
-        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string) $helpText;
-        $this->optional = (bool) $optional;
+        $this->fulfilled = (bool)$fulfilled;
+        $this->testMessage = (string)$testMessage;
+        $this->helpHtml = (string)$helpHtml;
+        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string)$helpText;
+        $this->optional = (bool)$optional;
     }
 
     /**
@@ -544,7 +544,7 @@ 
             );
         }
 
-        $pcreVersion = defined('PCRE_VERSION') ? (float) PCRE_VERSION : null;
+        $pcreVersion = defined('PCRE_VERSION') ? (float)PCRE_VERSION : null;
 
         $this->addRequirement(
             null !== $pcreVersion,
@@ -739,7 +739,7 @@ 
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $this->addRecommendation(
-                $this->getRealpathCacheSize() > 5 * 1024 * 1024,
+                $this->getRealpathCacheSize() > 5*1024*1024,
                 'realpath_cache_size should be above 5242880 in php.ini',
                 'Setting "<strong>realpath_cache_size</strong>" to e.g. "<strong>5242880</strong>" or "<strong>5000k</strong>" in php.ini<a href="#phpini">*</a> may improve performance on Windows significantly in some cases.'
             );
@@ -783,13 +783,13 @@ 
         $unit = strtolower(substr($size, -1, 1));
         switch ($unit) {
             case 'g':
-                return $size * 1024 * 1024 * 1024;
+                return $size*1024*1024*1024;
             case 'm':
-                return $size * 1024 * 1024;
+                return $size*1024*1024;
             case 'k':
-                return $size * 1024;
+                return $size*1024;
             default:
-                return (int) $size;
+                return (int)$size;
         }
     }
 
@@ -811,7 +811,7 @@ 
                 continue;
             }
 
-            return (int) $package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
+            return (int)$package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
         }
 
         return false;