KI\PonthubBundle\Transformer\StringToActorsTransformer

Complexity

Total Complexity

6

Size/Duplication

Total Lines	41
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	transform()	4	4	1
A	reverseTransform()	23	23	4

<?php
namespace KI\PonthubBundle\Transformer;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use KI\PonthubBundle\Entity\Actor;
use Symfony\Component\Form\DataTransformerInterface;

class StringToActorsTransformer implements DataTransformerInterface
{
    protected $manager;
    protected $actorRepository;

    public function __construct(EntityManager $manager, EntityRepository $actorRepository)

You have injected the EntityManager via parameter $manager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->manager         = $manager;
        $this->actorRepository = $actorRepository;
    }

    // En théorie, ne sera jamais utilisé
    public function transform($actors)
    {
        return '';
    }

    public function reverseTransform($string)
    {
        if (!$string) {
            return null;
        }

        $array = new \Doctrine\Common\Collections\ArrayCollection();
        foreach (explode(',', $string) as $actor) {
            $item = $this->actorRepository->findOneByName($actor);

            if ($item instanceof Actor) {
                $array->add($item);
            } else {
                $actorItem = new Actor();
                $actorItem->setName($actor);
                $this->manager->persist($actorItem);
                $array->add($actorItem);
            }
        }
        $this->manager->flush();

        return $array;
    }
}