osm_poi_matchmaker.libs.xml

Complexity

Total Complexity

10

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes

0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	download_xml()	0	7	3
B	save_downloaded_xml()	0	14	7

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import requests
    import os
    from lxml import etree

Unused etree imported from lxml

    from osm_poi_matchmaker.utils import config
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


def download_xml(link, verify_link=config.get_download_verify_link()):

Missing function or method docstring

    try:
        page = requests.get(link, verify=verify_link)
    except requests.exceptions.ConnectionError as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

The variable e seems to be unused.

        logging.warning('Unable to open connection.')
        return None
    return page.content if page.status_code == 200 else None


def save_downloaded_xml(link, file, verify=config.get_download_verify_link()):

Missing function or method docstring

    if config.get_download_use_cached_data() == True and os.path.isfile(file):

Comparison to True should be just 'expr'

        with open(file, 'r', encoding='utf-8') as content_file:
            page = content_file.read()
    else:
        page = download_xml(link, verify)
        if page is not None:
            if not os.path.exists(config.get_directory_cache_url()):
                os.makedirs(config.get_directory_cache_url())
            with open(file, mode='w', encoding='utf-8') as code:
                code.write(page.decode('utf-8'))
        else:
            logging.warning('Skipping dataset.')
    return page