osm_poi_matchmaker.libs.poi_qc

Complexity

Total Complexity

18

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	POIQC.__is_name_metaphone_road_around()	0	6	2
A	POIQC.__init__()	0	10	1
A	POIQC.process()	0	2	1
A	POIQC.__is_in_water()	0	6	2
A	POIQC.__check()	0	6	2
B	POIQC.__custom_opening_hours()	0	8	8
A	POIQC.__is_name_road_around()	0	6	2

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import sqlalchemy

The import sqlalchemy seems to be unused.

    from sqlalchemy.orm import scoped_session, sessionmaker

Unused scoped_session imported from sqlalchemy.orm

Unused sessionmaker imported from sqlalchemy.orm

    import geopandas as gpd

Unused geopandas imported as gpd

except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


class POIQC:

Missing class docstring

Too many instance attributes (8/7)

    def __init__(self, db, lon, lat, opening_hours=None, street=None):

Too many arguments (6/5)

        self.__db = db
        self.__lon = lon
        self.__lat = lat
        self.__good = []
        self.__bad = []
        self.__distance = 1
        self.__opening_hours = opening_hours
        self.__street = street
        self.__check()

    def __check(self):
        self.__is_in_water()
        self.__is_name_road_around()
        self.__is_name_metaphone_road_around()
        if self.__opening_hours is not None:
            self.__custom_opening_hours()

    def process(self):

Missing function or method docstring

        return self.__good, self.__bad

    def __is_in_water(self):
        data = self.__db.query_poi_in_water(self.__lon, self.__lat)
        if data.empty:
            self.__good.append('not_in_water')
        else:
            self.__bad.append('in_water')

    def __custom_opening_hours(self):
        if self.__opening_hours is not None:
            if 'comment' in self.__opening_hours or 'status' in self.__opening_hours or \

Too many boolean expressions in if statement (6/5)

               'dawn' in self.__opening_hours or 'sunrise' in self.__opening_hours or \
               'sunset' in self.__opening_hours or 'dusk' in self.__opening_hours:
                self.__bad.append('custom_opening_hours')
            else:
                self.__good.append('standard_opening_hours')

    def __is_name_road_around(self):
        data = self.__db.query_name_road_around(self.__lon, self.__lat, self.__street, True, 'name')
        if data.empty:
            self.__bad.append('street_is_not_around')
        else:
            self.__good.append('street_is_around')

    def __is_name_metaphone_road_around(self):
        data = self.__db.query_name_road_around(self.__lon, self.__lat, self.__street, True, 'metaphone')

This line is too long as per the coding-style (105/100).

        if data.empty:
            self.__bad.append('street_metaphone_is_not_around')
        else:
            self.__good.append('street_metaphone_is_around')