osm_poi_matchmaker.libs.geo

Complexity

Total Complexity

26

Size/Duplication

Total Lines	94
Duplicated Lines	29.79 %

Importance

Changes

0

3 Functions

Rating	Name	Duplication	Size	Complexity
A	geom_point()	0	5	3
C	check_geom()	28	44	11
D	check_hu_boundary()	0	23	12

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import re
    from geoalchemy2 import WKTElement
    from osm_poi_matchmaker.utils import config
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)

PATTERN_COORDINATE = re.compile('[\d]{1,3}.[\d]{2,5}')

A suspicious escape sequence \d was found. Did you maybe forget to add an r prefix?

def geom_point(latitude, longitude, projection):

Missing function or method docstring

    if latitude is not None and longitude is not None:

Unnecessary "else" after "return"

        return WKTElement('POINT({} {})'.format(latitude, longitude), srid=projection)
    else:
        return None


def check_geom(latitude, longitude, proj=config.get_geo_default_projection()):
    """
    Basic check of latitude and longitude geom point
    Are both coordinates are exist and extract only the right format

    :param latitude: Coordinate latitude part of geom
    :param longitude: Coordinate longitude part of geom
    :param proj: Projection of geom
    :return: Validated coordinates or None on error
    """
    if (latitude is not None and latitude != '') and (longitude is not None and longitude != ''):

Unnecessary "else" after "return"

        if not isinstance(latitude, float):

This code seems to be duplicated in your project.

            la = PATTERN_COORDINATE.search(latitude.replace(',', '.').strip())

Variable name "la" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            try:
                if la is not None:
                    lat = la.group()
                else:
                    return None
            except (AttributeError, IndexError) as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.error('%s;%s', latitude, longitude)
                logging.error(e)
                logging.exception('Exception occurred')

                return None
        else:
            lat = latitude
        if not isinstance(longitude, float):

This code seems to be duplicated in your project.

            lo = PATTERN_COORDINATE.search(longitude.replace(',', '.').strip())

Variable name "lo" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            try:
                if lo is not None:
                    lon = lo.group()
                else:
                    return None
            except (AttributeError, IndexError) as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.error('%s;%s', latitude, longitude)
                logging.error(e)
                logging.exception('Exception occurred')

                return None
        else:
            lon = longitude
        return geom_point(lat, lon, proj)
    else:
        return None


def check_hu_boundary(latitude, longitude):

Missing function or method docstring

    if (latitude is not None and latitude != '' and latitude != 0.0) and (

Unnecessary "else" after "return"

Too many boolean expressions in if statement (6/5)

            longitude is not None and longitude != '' and longitude != 0.0):
        # This is a workaround because original datasource may contains swapped lat / lon parameters
        if float(latitude) < 44:
            logging.warning(
                'Latitude-longitude replacement. Originally was: latitude: %s, longitude: %s.',
                latitude, longitude)
            longitude, latitude = latitude, longitude
        # Another workaround to insert missing decimal point
        if float(longitude) > 200:
            longitude = '{}.{}'.format(longitude[:2], longitude[3:])
            if longitude.count('.') > 1:
                lon_tmp = longitude.split('.')
                longitude = '.'.join(lon_tmp[0:1])
        if float(latitude) > 200:
            latitude = '{}.{}'.format(latitude[:2], latitude[3:])
            if latitude.count('.') > 1:
                lat_tmp = latitude.split('.')
                latitude = '.'.join(lat_tmp[0:1])
        return latitude, longitude
    else:
        return None, None