osm_poi_matchmaker.libs.file_output

Complexity

Total Complexity

107

Size/Duplication

Total Lines	438
Duplicated Lines	0 %

Importance

Changes

0

7 Functions

Rating	Name	Duplication	Size	Complexity
A	add_osm_link_comment()	0	12	1
A	add_osm_way()	0	20	3
F	generate_osm_xml()	0	265	90
A	list_osm_node()	0	26	5
A	save_csv_file()	0	17	2
A	add_osm_node()	0	24	3
A	ascii_numcoder()	0	8	3

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import math
    import os
    import datetime
    from urllib.parse import quote
    from osm_poi_matchmaker.dao.data_structure import OSM_object_type
    from osm_poi_matchmaker.utils import config
    from osm_poi_matchmaker.libs.address import clean_url
    from osm_poi_matchmaker.libs.osm import relationer, timestamp_now

Unused timestamp_now imported from osm_poi_matchmaker.libs.osm

    from osm_poi_matchmaker.libs.compare_strings import compare_strings
    from sqlalchemy.orm import scoped_session, sessionmaker
    from osm_poi_matchmaker.dao.poi_base import POIBase

Imports from package osm_poi_matchmaker are not grouped

    from lxml import etree
    import lxml
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)

POI_TAGS = {'poi_name': 'name', 'poi_city': 'addr:city', 'poi_postcode': 'addr:postcode',
            'poi_addr_street': 'addr:street', 'poi_addr_housenumber': 'addr:housenumber',
            'poi_conscriptionnumber': 'addr:conscriptionnumber', 'poi_branch': 'branch', 'poi_email': 'email'}

This line is too long as per the coding-style (110/100).

POI_YESNO_TAGS = {'poi_fuel_adblue': 'fuel:adblue', 'poi_fuel_octane_100': 'fuel:octane_100',
                  'poi_fuel_octane_98': 'fuel:octane_98', 'poi_fuel_octane_95': 'fuel:octane_95',
                  'poi_fuel_diesel_gtl': 'fuel:GTL_diesel', 'poi_fuel_diesel': 'fuel:diesel',
                  'poi_fuel_lpg': 'fuel:lpg', 'poi_fuel_e85': 'fuel:e85', 'poi_rent_lpg_bottles': 'rent:lpg_bottles',

This line is too long as per the coding-style (117/100).

                  'poi_compressed_air': 'compressed_air', 'poi_restaurant': 'restaurant', 'poi_food': 'food',

This line is too long as per the coding-style (109/100).

                  'poi_truck': 'truck', 'poi_authentication_app': 'authentication:app',
                  'poi_authentication_membership_card': 'authentication:membership_card', 'poi_fee': 'fee',

This line is too long as per the coding-style (107/100).

                  'poi_parking_fee': 'parking_fee', 'poi_motorcar': 'motorcar'}

POI_EV_TAGS = {'poi_capacity': 'capacity',
               'poi_socket_chademo': 'socket:chademo', 'poi_socket_chademo_output': 'socket:chademo:output',

This line is too long as per the coding-style (108/100).

               'poi_socket_type2_combo': 'socket:type2_combo',
               'poi_socket_type2_combo_output': 'socket:type2_combo:output',
               'poi_socket_type2_cable': 'socket:type2_cable',
               'poi_socket_type2_cable_output': 'socket:type2_cable:output',
               'poi_socket_type2': 'socket:type2', 'poi_socket_type2_output': 'socket:type2:output',
               'poi_manufacturer': 'manufacturer', 'poi_model': 'model'}

TESTCASE_GEN_KEYS = ('original', 'poi_postcode', 'poi_city', 'poi_addr_street', 'poi_addr_housenumber', 'poi_conscriptionnumber')

This line is too long as per the coding-style (129/100).

TIMESTAMP_FORMAT = '{:{dfmt}T{tfmt}Z}'
DATE_FOTMAT = '%Y-%m-%d'
TIME_FORMAT = '%H:%M:%S'


def ascii_numcoder(text):

Missing function or method docstring

    output = ''
    for i in text:
        if i in range(0, 10, 1):
            output += i
        else:
            output += str(ord(i))
    return output


def save_csv_file(path: str, file: str, data, message: str):
    """Save Pandas dataframe to a CSV file

    Args:
        path (str): Path of newly created CVS file
        file (str): Filename of newly created CVS file
        data (pd.DataFrame): Pandas dataframe to write
        message (str): Addtion information to display
    """
    try:
        # Save file to CSV file
        logging.info('Saving {%s to file: %s', message, file)
        res = data.to_csv(os.path.join(path, file))

The variable res seems to be unused.

        logging.info('The %s was sucessfully saved', file)
    except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        logging.error(e)
        logging.exception('Exception occurred')


def add_osm_node(osm_id: int, node_data: dict, prefix: str = 'poi') -> dict:
    """Generate OpenStreetMap node header information as string

    Args:
        osm_id (int): OpenStreetMap ID
        node_data (dict): [description]
        prefix (str): Prefix for field names in database

    Returns:
        str: [description]
    """
    logging.info(node_data.to_string())
    if node_data.get('osm_timestamp') is None:
        osm_timestamp = datetime.datetime.now()
    else:
        osm_timestamp = node_data.get('osm_timestamp')
    osm_version = '99999' if node_data.get('osm_version') is None else node_data.get('osm_version')
    osm_data = {'action': 'modify', 'id': str(osm_id),
                'lat': '{}'.format(node_data.get('{}_lat'.format(prefix))),
                'lon': '{}'.format(node_data.get('{}_lon'.format(prefix))),
                'user': '{}'.format('osm_poi_matchmaker'), 'uid': '{}'.format('8635934'), 'version': '{}'.format(osm_version),

This line is too long as per the coding-style (126/100).

                'timestamp': TIMESTAMP_FORMAT.format(osm_timestamp, dfmt=DATE_FOTMAT, tfmt=TIME_FORMAT)}

This line is too long as per the coding-style (104/100).

    logging.info(osm_data)
    return osm_data


def list_osm_node(osm_id: int, node_data: dict, prefix='poi') -> dict:
    """Generate OpenStreetMap node header information as string

    Args:
        osm_id (int): OpenStreetMap ID
        node_data (dict): [description]
        prefix (str): Prefix for field names in database

    Returns:
        str: [description]
    """
    logging.debug(node_data)
    osm_user = 'osm_poi_matchmaker' if node_data.get('osm_user') is None else node_data.get('osm_user')

This line is too long as per the coding-style (103/100).

    osm_user_id = '8635934' if node_data.get('osm_user_id') is None else node_data.get('osm_user_id')

This line is too long as per the coding-style (101/100).

    if node_data.get('osm_timestamp') is None:
        osm_timestamp = datetime.datetime.now()
    else:
        osm_timestamp = node_data.get('osm_timestamp')
    osm_version = '99999' if node_data.get('osm_version') is None else node_data.get('osm_version')
    osm_data = {'id': str(osm_id),
                'lat': '{}'.format(node_data.get('{}_lat'.format(prefix))),
                'lon': '{}'.format(node_data.get('{}_lon'.format(prefix))),
                'user': '{}'.format(osm_user), 'uid': '{}'.format(osm_user_id), 'version': '{}'.format(osm_version),

This line is too long as per the coding-style (116/100).

                'timestamp': TIMESTAMP_FORMAT.format(osm_timestamp, dfmt=DATE_FOTMAT, tfmt=TIME_FORMAT)}

This line is too long as per the coding-style (104/100).

    logging.debug(osm_data)
    return osm_data


def add_osm_way(osm_id: int, node_data: dict) -> dict:
    """Generate OpenStreetMap way header information as dictionary

    Args:
        osm_id (int): [description]
        node_data (dict): [description]

    Returns:
        str: [description]
    """
    if node_data.get('osm_timestamp') is None:
        osm_timestamp = datetime.datetime.now()
    else:
        osm_timestamp = node_data.get('osm_timestamp')
    osm_version = '99999' if node_data.get('osm_version') is None else node_data.get('osm_version')
    osm_data = {'action': 'modify', 'id': str(osm_id),
                'user': '{}'.format('osm_poi_matchmaker'), 'uid': '{}'.format('8635934'),
                'version': '{}'.format(osm_version),
                'timestamp': TIMESTAMP_FORMAT.format(osm_timestamp, dfmt=DATE_FOTMAT, tfmt=TIME_FORMAT)}

This line is too long as per the coding-style (104/100).

    return osm_data


def add_osm_link_comment(osm_id: int, osm_type) -> str:
    """Create OpenStreetMap osm.org link from OSM object

    Args:
        osm_id (int): [description]
        osm_type ([type]): [description]

    Returns:
        str: [description]
    """
    osm_comment = ' OSM link: https://osm.org/{}/{} '.format(osm_type.name, str(osm_id))
    return osm_comment


def generate_osm_xml(df, session=None):

Argument name "df" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

This function exceeds the maximum number of variables (38/15).

    """Crete OpenStreetMap (OSM XML) file from passed Panda Dataframe

    Args:
        df ([type]): [description]
        session ([type], optional): [description]. Defaults to None.

    Returns:
        [type]: [description]
    """
    db = POIBase('{}://{}:{}@{}:{}/{}'.format(config.get_database_type(), config.get_database_writer_username(),

This line is too long as per the coding-style (112/100).

Variable name "db" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                                              config.get_database_writer_password(),
                                              config.get_database_writer_host(),
                                              config.get_database_writer_port(),
                                              config.get_database_poi_database()))
    pgsql_pool = db.pool
    session_factory = sessionmaker(pgsql_pool)
    Session = scoped_session(session_factory)

Variable name "Session" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

    session = Session()
    osm_xml_data = etree.Element('osm', version='0.6', generator='JOSM')

Module 'lxml.etree' has no 'Element' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

    default_osm_id = -1
    current_osm_id = default_osm_id
    added_nodes = []
    try:

Too many nested blocks (10/5)

Too many nested blocks (6/5)

Too many nested blocks (7/5)

        for index, row in df.iterrows():

Possibly unused variable 'index'

            tags = {}
            osm_live_tags = {}
            main_data = {}
            current_osm_id = default_osm_id if row.get('osm_id') is None else row.get('osm_id')
            osm_version = '99999' if row.get('osm_version') is None else row.get('osm_version')

Possibly unused variable 'osm_version'

            if row.get('osm_node') is None or row.get('osm_node') == OSM_object_type.node:
                try:
                    josm_object = 'n{}'.format(current_osm_id)
                    main_data = etree.SubElement(osm_xml_data, 'node', add_osm_node(current_osm_id, row))

This line is too long as per the coding-style (105/100).

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    logging.exception('Exception occurred')
            elif row.get('osm_node') is not None and row.get('osm_node') == OSM_object_type.way:
                try:
                    main_data = etree.SubElement(osm_xml_data, 'way', add_osm_way(current_osm_id, row))

This line is too long as per the coding-style (103/100).

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                    josm_object = 'w{}'.format(current_osm_id)
                # Add way nodes without any modification)
                    node_data = []
                    for n in row.get('osm_nodes'):

Variable name "n" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                        data = etree.SubElement(main_data, 'nd', ref=str(n))

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

Possibly unused variable 'data'

                    if session is not None:
                        # Go through the list except the last value (which is same as the first)
                        for n in row.get('osm_nodes'):

Variable name "n" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                            # Add nodes only when it is not already added.
                            if n not in added_nodes:
                                added_nodes.append(n)
                                way_node = db.query_from_cache(n, OSM_object_type.node)
                                if way_node is not None:
                                    node_data = etree.SubElement(osm_xml_data, 'node',

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                                                                 list_osm_node(n, way_node, 'osm'))
                                    if node_data.get('osm_live_tags') is not None and \
                                       node_data.get('osm_live_tags') != '':
                                        node_osm_live_tags = node_data.get('osm_live_tags')
                                        for k, v in sorted(node_osm_live_tags).items():

Variable name "v" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                                            xml_node_tags = etree.SubElement(node_data, 'tag', k=k, v='{}'.format(v))

This line is too long as per the coding-style (117/100).

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                except TypeError as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    logging.warning('Missing nodes on this way: %s.', row.get('osm_id'))
                    logging.exception('Exception occurred')
            elif row.get('osm_node') is not None and row.get('osm_node') == OSM_object_type.relation:

This line is too long as per the coding-style (101/100).

                try:
                    main_data = etree.SubElement(osm_xml_data, 'relation', add_osm_way(current_osm_id, row))

This line is too long as per the coding-style (108/100).

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                    josm_object = 'r{}'.format(current_osm_id)
                    relations = relationer(row.get('osm_nodes'))
                    for i in relations:
                        data = etree.SubElement(main_data, 'member', type=i.get('type'), ref=i.get('ref'),

This line is too long as per the coding-style (106/100).

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                                                role=i.get('role'))
                except TypeError as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    logging.warning('Missing nodes on this relation: %s.', row['osm_id'])
                    logging.exception('Exception occurred')
            # Add already existing node, way, relation OpenStreetMap reference as comment
            try:
                if current_osm_id > 0:
                    osm_xml_data.append(etree.Comment(add_osm_link_comment(current_osm_id, row.get('osm_node'))))

This line is too long as per the coding-style (113/100).

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                # Add original POI coordinates as comment
                comment = etree.Comment(' Original coordinates: {} '.format(row.get('poi_geom')))

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                osm_xml_data.append(comment)
                if 'poi_distance' in row:
                    if row.get('poi_distance') is not None:
                        comment = etree.Comment(' OSM <-> POI distance: {} m'.format(row.get('poi_distance')))

This line is too long as per the coding-style (110/100).

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                    else:
                        comment = etree.Comment(' OSM <-> POI distance: Non exist')

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                    osm_xml_data.append(comment)
                if 'poi_good' in row and 'poi_bad' in row:
                    comment = etree.Comment(' Checker good: {}; bad {}'.format(row.get('poi_good'), row.get('poi_bad')))

This line is too long as per the coding-style (120/100).

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                    osm_xml_data.append(comment)
                # Using already definied OSM tags if exists
                if row.get('osm_live_tags') is not None:
                    tags.update(row.get('osm_live_tags').copy())
                    logging.critical(row.get('osm_live_tags'))
                    osm_live_tags.update(row.get('osm_live_tags').copy())
                # Adding POI common tags
                if row.get('poi_tags') is not None:
                    tags.update(row.get('poi_tags'))
                # Save live name tags if preserve name is enabled
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                if row.get('preserve_original_name') is True:
                    preserved_name = tags.get('name')
            except KeyError as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.debug('No name tag is specified to save in original OpenStreetMap data.')
            try:
                # Overwriting with data from data providers
                for k, v in POI_TAGS.items():

Variable name "v" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    if row.get(k) is not None:
                        tags[v] = row.get(k)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                if config.get_geo_alternative_opening_hours():
                    alternative_oh_tag = config.get_geo_alternative_opening_hours_tag()
                    # Alternative opening_hours handling for COVID-19 code path
                    if tags.get('opening_hours') is not None and tags.get('opening_hours') != '':
                        if row.get('poi_opening_hours') is not None and row.get('poi_opening_hours') != '':

This line is too long as per the coding-style (107/100).

                            if tags.get('opening_hours') == row.get('poi_opening_hours'):
                                tags[alternative_oh_tag] = 'same'
                            else:
                                tags[alternative_oh_tag] = row.get('poi_opening_hours')
                    else:
                        if row.get('poi_opening_hours') is not None and row.get('poi_opening_hours') != '':

This line is too long as per the coding-style (107/100).

                            tags['opening_hours'] = row.get('poi_opening_hours')
                            tags[alternative_oh_tag] = 'same'
                else:
                    # Alternative opening_hours handling for NON COVID-19 code path: just simply add opening_hours to tags

This line is too long as per the coding-style (122/100).

                    if row.get('poi_opening_hours') is not None and row.get('poi_opening_hours') != '':

This line is too long as per the coding-style (103/100).

                        tags['opening_hours'] = row.get('poi_opening_hours')
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # If we got POI phone tag use it as OSM contact:phone tag
                if row.get('poi_phone') is not None and row.get('poi_phone') != '':
                    tags['contact:phone'] = row.get('poi_phone')
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # If we got POI website tag use it as OSM contact:website tag
                if row.get('poi_url_base') is not None and row.get('poi_website') is not None:
                    if row['poi_url_base'] in row.get('poi_website'):
                        # The POI website contains the base URL use the POI website field only
                        tags['contact:website'] = clean_url('{}'.format((row.get('poi_website'))))
                    else:
                        # The POI website does not contain the base URL use the merged base URL and POI website field

This line is too long as per the coding-style (117/100).

                        tags['contact:website'] = clean_url('{}/{}'.format(row.get('poi_url_base'), row.get('poi_website')))

This line is too long as per the coding-style (124/100).

                # If only the base URL is available
                elif row.get('poi_url_base') is not None:
                    tags['contact:website'] = row.get('poi_url_base')
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # Short URL for source
                if row['poi_url_base'] is not None:
                    source_url = 'source:{}:date'.format(row.get('poi_url_base').split('/')[2])
                else:
                    source_url = 'source:website:date'
                tags[source_url] = '{:{dfmt}}'.format(datetime.datetime.now(), dfmt=DATE_FOTMAT)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # Write back the saved name tag
                if 'preserved_name' in locals():
                    tags['name'] = preserved_name
                # Rewrite old contact tags to contact:* tag form
                tags_rewrite = ['website', 'phone', 'email', 'facebook', 'instagram', 'youtube', 'pinterest', 'fax']

This line is too long as per the coding-style (116/100).

                for tr in tags_rewrite:

Variable name "tr" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    if tr in tags:
                        # Never overwrite already existing contact:* tags
                        if 'contact:' + tr in tags:
                            # We already have this contact:* tag so remove the simple contact tag
                            tags.pop(tr, None)
                        else:
                            # Rewrite simple contact tag to contact:* tag
                            tags['contact:' + tr] = tags.pop(tr, None)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                if row.get('poi_description') is not None and row.get('poi_description') != '':
                    tags['description'] = row.get('poi_description')
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # Write tags with yes/no value
                for k, v in POI_YESNO_TAGS.items():

Variable name "v" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    if row.get(k) is not None and row.get(k) != '':
                        tags[v] = 'yes' if row.get(k) is True else 'no'
                for k, v in POI_EV_TAGS.items():

Variable name "v" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    if row.get(k) is not None and row.get(k) != '':
                        if isinstance(row.get(k), float):
                            if not math.isnan(row.get(k)):
                                tags[v] = int(row.get(k))
                        else:
                            tags[v] = row.get(k)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # This is a new POI - will add fix me tag to the new items.
                if row.get('poi_new') is not None and row.get('poi_new') is True:
                    tags['fixme'] = 'verify import'
                # Remove unwanted addr:country from file output as we discussed in Issue #33
                tags.pop('addr:country', None)
                # tags['import'] = 'osm_poi_matchmaker'
                # Rendering tags to the XML file and JOSM magic link
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                josm_link = ''
                comment = '\nKey\t\t\t\tStatus\t\tNew value\t\tOSM value\n'
                for k, v in sorted(tags.items()):

Variable name "v" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    xml_tags = etree.SubElement(main_data, 'tag', k=k, v='{}'.format(v))

Module 'lxml.etree' has no 'SubElement' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

The variable xml_tags seems to be unused.

                    josm_link = '{}|{}={}'.format(josm_link, k, v)
                    # Add original POI tags as comment
                    try:
                        if isinstance(v, str):
                            v = v.replace('-', '\-').replace('\n', '')

A suspicious escape sequence \- was found. Did you maybe forget to add an r prefix?

Variable name "v" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                        w = osm_live_tags[k]

Variable name "w" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    except KeyError:
                        comment += "{:32} N\t\t'{}'\n".format(k, v)
                    else:
                        if isinstance(w, str):
                            w = w.replace('-', '\-').replace('\n', '')

A suspicious escape sequence \- was found. Did you maybe forget to add an r prefix?

Variable name "w" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                        comment += "{:32} {}\t\t'{}'\t\t\t'{}'\n".format(k, compare_strings(v, w), v, w)

This line is too long as per the coding-style (104/100).

                comment = etree.Comment(comment)

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                osm_xml_data.append(comment)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                # URL encode link and '--' in comment
                josm_link = quote(josm_link)
                josm_link = josm_link.replace('--', '%2D%2D')
                comment = etree.Comment(' JOSM magic link: {}?new_layer=false&objects={}&addtags={} '.format

This line is too long as per the coding-style (108/100).

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                                        ('http://localhost:8111/load_object', josm_object, josm_link))

The variable josm_object does not seem to be defined for all execution paths.

This line is too long as per the coding-style (102/100).

                osm_xml_data.append(comment)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                test_case = {k: row.get(k, None) for k in TESTCASE_GEN_KEYS}
                comment = etree.Comment("ˇ'original': '{t[original]}', 'postcode': '{t[poi_postcode]}', 'city': '{t[poi_city]}', 'street': '{t[poi_addr_street]}', 'housenumber': '{t[poi_addr_housenumber]}', 'conscriptionnumber': '{t[poi_conscriptionnumber]}'°".format(t=test_case))

This line is too long as per the coding-style (281/100).

Module 'lxml.etree' has no 'Comment' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.

                osm_xml_data.append(comment)
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
            try:
                osm_xml_data.append(xml_node_tags)

The variable xml_node_tags does not seem to be defined for all execution paths.

            except UnboundLocalError as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.debug('Unbound local error extra node tags')
            try:
                osm_xml_data.append(main_data)
                # Next deafult OSM id is one more less for non existing objects
                default_osm_id -= 1
            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                logging.exception('Exception occurred')
    except ValueError as e:

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        logging.error(e)
        logging.exception('Exception occurred')

    except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        logging.error(e)
        logging.exception('Exception occurred')

    return lxml.etree.tostring(osm_xml_data, pretty_print=True, xml_declaration=True, encoding="UTF-8")

This line is too long as per the coding-style (103/100).

Module 'lxml.etree' has no 'tostring' member, but source is unavailable. Consider adding this module to extension-pkg-whitelist if you want to perform analysis based on run-time introspection of living objects.