osm_poi_matchmaker.libs.compare_strings

Complexity

Total Complexity

11

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

0

1 Function

Rating	Name	Duplication	Size	Complexity
C	compare_strings()	0	13	11

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import re

The import re seems to be unused.

except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


def compare_strings(string1, string2=''):

Missing function or method docstring

Either all return statements in a function should return an expression, or none of them should.

    # New string
    if (string1 is '' or string1 is None) and (string2 is not '' and string2 is not None):

Unnecessary "elif" after "return"

Comparison to literal

        return 'N'
    # Deleted string
    elif (string1 is not '' and string1 is not None) and (string2 is '' or string2 is None):

Comparison to literal

        return 'D'
    # Modified string
    elif str(string1) != str(string2):
        return 'M'
    # Equal string
    elif str(string1) == str(string2):
        return 'E'