osm_poi_matchmaker.dataproviders.hu_spar

Complexity

Total Complexity

11

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hu_spar.constains()	0	13	1
A	hu_spar.types()	0	25	1
C	hu_spar.process()	0	44	9

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import os
    import re
    import json
    from osm_poi_matchmaker.libs.soup import save_downloaded_soup
    from osm_poi_matchmaker.libs.address import extract_street_housenumber_better_2, clean_city
    from osm_poi_matchmaker.libs.geo import check_hu_boundary
    from osm_poi_matchmaker.libs.osm_tag_sets import POS_OTP, PAY_CASH
    from osm_poi_matchmaker.utils.data_provider import DataProvider
    from osm_poi_matchmaker.utils.enums import FileType
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)

PATTERN_SPAR_REF = re.compile('\((.*?)\)')

A suspicious escape sequence \( was found. Did you maybe forget to add an r prefix?

A suspicious escape sequence \) was found. Did you maybe forget to add an r prefix?

class hu_spar(DataProvider):

Class name "hu_spar" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

Missing class docstring

    def constains(self):
        self.link = 'https://www.spar.hu/uzletek/_jcr_content.stores.v2'
        self.tags = {'operator': 'SPAR Magyarország Kereskedelmi Kft.', 'brand': 'Spar',
                     'brand:wikipedia': 'hu:Spar', 'brand:wikidata': 'Q610492',
                     'contact:email': 'vevoszolgalat@spar.hu',
                     'phone': '+36208237727', 'contact:facebook': 'https://www.facebook.com/sparmagyarorszag',

This line is too long as per the coding-style (110/100).

                     'contact:youtube': 'https://www.youtube.com/channel/UC9tu8COHiy4WkeTIN1k_Y8A',
                     'contact:instagram': 'https://www.instagram.com/sparmagyarorszag'}
        self.tags.update(POS_OTP)
        self.tags.update(PAY_CASH)
        self.filetype = FileType.json
        self.filename = '{}.{}'.format(
            self.__class__.__name__, self.filetype.name)

    def types(self):
        husparecon = {'shop': 'convenience'}
        husparecon.update(self.tags)
        husparisup = {'shop': 'supermarket'}
        husparisup.update(self.tags)
        husparsup = {'shop': 'supermarket'}
        husparsup.update(self.tags)
        huspardcon = {'shop': 'convenience'}
        huspardcon.update(self.tags)
        self.__types = [
            {'poi_code': 'husparecon', 'poi_name': 'Spar Expressz', 'poi_type': 'shop',
             'poi_tags': husparecon, 'poi_url_base': 'https://www.spar.hu',
             'poi_search_name': '(spar|spar express|spar expressz)',
             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 15},

This line is too long as per the coding-style (117/100).

            {'poi_code': 'husparisup', 'poi_name': 'Interspar', 'poi_type': 'shop',
             'poi_tags': husparisup, 'poi_url_base': 'https://www.spar.hu', 'poi_search_name': '(spar|interspar)',

This line is too long as per the coding-style (114/100).

             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 15},

This line is too long as per the coding-style (117/100).

            {'poi_code': 'husparsup', 'poi_name': 'Spar', 'poi_type': 'shop',
             'poi_tags': husparsup, 'poi_url_base': 'https://www.spar.hu', 'poi_search_name': '(spar|spar supermarket)',

This line is too long as per the coding-style (120/100).

             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 15},

This line is too long as per the coding-style (117/100).

            {'poi_code': 'huspardcon', 'poi_name': 'DeSpar', 'poi_type': 'shop',
             'poi_tags': huspardcon, 'poi_url_base': 'https://www.spar.hu', 'poi_search_name': '(spar|despar)',

This line is too long as per the coding-style (111/100).

             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 15},

This line is too long as per the coding-style (117/100).

        ]
        return self.__types

    def process(self):
        try:
            soup = save_downloaded_soup('{}'.format(self.link), os.path.join(self.download_cache, self.filename),

This line is too long as per the coding-style (113/100).

                                        self.filetype)
            if soup is not None:
                text = json.loads(soup)
                for poi_data in text:
                    # Assign: code, postcode, city, name, branch, website, original, street, housenumber, conscriptionnumber, ref, geom

This line is too long as per the coding-style (135/100).

                    if 'xpres' in poi_data['name']:
                        self.data.name = 'Spar Expressz'
                        self.data.code = 'husparecon'
                    elif 'INTER' in poi_data['name']:
                        self.data.name = 'Interspar'
                        self.data.code = 'husparisup'
                    elif 'market' in poi_data['name']:
                        self.data.name = 'Spar'
                        self.data.code = 'husparsup'
                    elif 'DESPAR' in poi_data['name']:
                        self.data.name = 'DeSpar'
                        self.data.code = 'huspardcon'
                    else:
                        self.data.name = 'Spar'
                        self.data.code = 'husparsup'
                    poi_data['name'] = poi_data['name'].replace(
                        'INTERSPAR', 'Interspar')
                    poi_data['name'] = poi_data['name'].replace('SPAR', 'Spar')
                    ref_match = PATTERN_SPAR_REF.search(poi_data['name'])
                    self.data.ref = ref_match.group(
                        1).strip() if ref_match is not None else None
                    self.data.city = clean_city(poi_data['city'])
                    self.data.postcode = poi_data.get('zipCode').strip()
                    self.data.branch = poi_data['name'].split('(')[0].strip()
                    self.data.website = poi_data['pageUrl'].strip()
                    self.data.lat, self.data.lon = check_hu_boundary(
                        poi_data['latitude'], poi_data['longitude'])
                    self.data.street, self.data.housenumber, self.data.conscriptionnumber = extract_street_housenumber_better_2(

This line is too long as per the coding-style (128/100).

                        poi_data['address'])
                    self.data.original = poi_data['address']
                    self.data.public_holiday_open = False
                    self.data.add()
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            logging.exception('Exception occurred')

            logging.error(e)