osm_poi_matchmaker.dataproviders.hu_sber_bank

Complexity

Total Complexity

16

Size/Duplication

Total Lines	115
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hu_sber_bank.constains()	0	10	1
F	hu_sber_bank.process()	0	63	14
A	hu_sber_bank.types()	0	18	1

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import json
    import os
    from osm_poi_matchmaker.libs.soup import save_downloaded_soup
    from osm_poi_matchmaker.libs.address import extract_street_housenumber_better_2
    from osm_poi_matchmaker.libs.geo import check_hu_boundary
    from osm_poi_matchmaker.utils.data_provider import DataProvider
    from osm_poi_matchmaker.utils.enums import FileType
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


class hu_sber_bank(DataProvider):

Class name "hu_sber_bank" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

Missing class docstring

    def constains(self):
        self.link = 'https://www.sberbank.hu/servlet/maplocatorServlet'
        self.tags = {'brand': 'Sberbank', 'brand:wikidata': 'Q17379757', 'bic': 'MAVOHUHB',
                     'brand:wikipedia': 'en:Sberbank of Russia', 'operator': 'Sberbank Magyarország Zrt.',

This line is too long as per the coding-style (106/100).

                     'operator:addr': '1088 Budapest, Rákóczi út 1-3.', 'brand:ru': 'Сбербанк',
                     'name:ru': 'Сбербанк', 'ref:vatin': 'HU10776999', 'ref:vatin:hu': '10776999-2-44',

This line is too long as per the coding-style (103/100).

                     'ref:HU:company': '01 10 041720'}
        self.filetype = FileType.json
        self.filename = '{}.{}'.format(
            self.__class__.__name__, self.filetype.name)

    def types(self):
        husberbank = {'amenity': 'bank',
                      'atm': 'yes', 'air_conditioning': 'yes'}
        husberbank.update(self.tags)
        husberatm = {'amenity': 'atm'}
        husberatm.update(self.tags)
        self.__types = [
            {'poi_code': 'husberbank', 'poi_name': 'Sberbank', 'poi_type': 'bank',
             'poi_tags': husberbank, 'poi_url_base': 'https://www.sberbank.hu', 'poi_search_name': '(sber|sberbank)',

This line is too long as per the coding-style (117/100).

             # Note: Volksbank is Sberbank
             # https://www.sberbank.at/press-releases/sberbank-completes-acquisition-volksbank-international
             'poi_search_avoid_name': '(erste|raiffeisen)',
             'osm_search_distance_perfect': 300, 'osm_search_distance_safe': 100, 'osm_search_distance_unsafe': 40},

This line is too long as per the coding-style (116/100).

            {'poi_code': 'husberatm', 'poi_name': 'Sberbank ATM', 'poi_type': 'atm',
             'poi_tags': husberatm, 'poi_url_base': 'https://www.sberbank.hu', 'poi_search_name': '(sber|sberbank)',

This line is too long as per the coding-style (116/100).

             'osm_search_distance_perfect': 50, 'osm_search_distance_safe': 30, 'osm_search_distance_unsafe': 10},

This line is too long as per the coding-style (114/100).

        ]
        return self.__types

    def process(self):
        try:

Too many nested blocks (6/5)

            soup = save_downloaded_soup('{}'.format(self.link), os.path.join(self.download_cache, self.filename),

This line is too long as per the coding-style (113/100).

                                        self.filetype)
            if soup is not None:
                text = json.loads(soup)
                for poi_data in text['atmList']:
                    self.data.name = 'Sberbank ATM'
                    self.data.code = 'husberatm'
                    self.data.public_holiday_open = True if poi_data.get(

The if expression can be replaced with 'test'

                        'atmNonstop') is True else False
                    self.data.postcode = poi_data.get('address')['zipCode']
                    ctmp = poi_data.get('address')['city']
                    self.data.city = ctmp if 'kerület' not in ctmp else poi_data.get('address')[
                        'county']
                    self.data.lat, self.data.lon = check_hu_boundary(poi_data.get('address')['coordinateX'],

This line is too long as per the coding-style (108/100).

                                                                     poi_data.get('address')['coordinateY'])

This line is too long as per the coding-style (108/100).

                    street_tmp = '{} {}'.format(poi_data.get('address')['street'],
                                                poi_data.get('address')['houseNumber'].split('.')[0])

This line is too long as per the coding-style (101/100).

                    self.data.street, self.data.housenumber, self.data.conscriptionnumber = \
                        extract_street_housenumber_better_2(street_tmp)
                    self.data.original = street_tmp
                    self.data.add()
                for poi_data in text['branchList']:
                    self.data.name = 'Sberbank'
                    self.data.code = 'husberbank'
                    self.data.public_holiday_open = False
                    self.data.postcode = poi_data.get('address')['zipCode']
                    ctmp = poi_data.get('address')['city']
                    self.data.city = ctmp if 'kerület' not in ctmp else poi_data.get('address')[
                        'county']
                    self.data.lat, self.data.lon = check_hu_boundary(poi_data.get('address')['coordinateX'],

This line is too long as per the coding-style (108/100).

                                                                     poi_data.get('address')['coordinateY'])

This line is too long as per the coding-style (108/100).

                    street_tmp = '{} {}'.format(poi_data.get('address')['street'],
                                                poi_data.get('address')['houseNumber'].split('.')[0])

This line is too long as per the coding-style (101/100).

                    self.data.street, self.data.housenumber, self.data.conscriptionnumber = \
                        extract_street_housenumber_better_2(street_tmp)
                    self.data.original = street_tmp
                    self.data.email = poi_data.get('emailAppointment')
                    self.data.phone = poi_data.get('phone'.split('/')[0])
                    for i, opening in enumerate(poi_data.get('openTime')):
                        if opening is not None and opening != '':
                            try:
                                oh = opening.get('from') if opening.get(

Variable name "oh" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                                    'from') != '' else None
                                self.data.day_open(i, oh)
                                ch = opening.get('to') if opening.get(

Variable name "ch" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                                    'to') != '' else None
                                self.data.day_close(i, ch)
                            except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                                logging.info(opening)
                                logging.exception('Exception occurred')

                                logging.error(e)
                                continue
                        else:
                            logging.debug(
                                'There is no opening hours on day: {}.'.format(i))

Use lazy % formatting in logging functions

                    self.data.add()
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            logging.exception('Exception occurred')

            logging.error(e)