osm_poi_matchmaker.dataproviders.hu_posta_json

Complexity

Total Complexity

12

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hu_posta_json.types()	0	25	1
A	hu_posta_json.__init__()	0	15	1
C	hu_posta_json.process()	0	42	10

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import os
    import json
    from osm_poi_matchmaker.dao.data_handlers import insert_poi_dataframe
    from osm_poi_matchmaker.libs.soup import save_downloaded_soup
    from osm_poi_matchmaker.libs.address import extract_street_housenumber_better_2, clean_city
    from osm_poi_matchmaker.libs.poi_dataset import POIDataset
    from osm_poi_matchmaker.utils.data_provider import DataProvider
    from osm_poi_matchmaker.utils.enums import FileType
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)

POI_POSTA = 'https://www.posta.hu/szolgaltatasok/posta-srv-postoffice/rest/postoffice/list?searchField=&searchText=&types=posta'

This line is too long as per the coding-style (128/100).

POI_CSEKK = 'https://www.posta.hu/szolgaltatasok/posta-srv-postoffice/rest/postoffice/list?searchField=&searchText=&types=csekkautomata',

Disallow trailing comma tuple

This line is too long as per the coding-style (137/100).

POI_CSOMAG = 'https://www.posta.hu/szolgaltatasok/posta-srv-postoffice/rest/postoffice/list?searchField=&searchText=&types=postamachine',

Disallow trailing comma tuple

This line is too long as per the coding-style (137/100).

POI_POSTA_PONT = 'https://www.posta.hu/szolgaltatasok/posta-srv-postoffice/rest/postoffice/list?searchField=&searchText=&types=postapoint',

Disallow trailing comma tuple

This line is too long as per the coding-style (139/100).

class hu_posta_json(DataProvider):

Class name "hu_posta_json" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

Missing class docstring

    def __init__(self, session, link, download_cache, filename='hu_posta.json'):

The __init__ method of the super-class DataProvider is not called.

        self.session = session
        self.link = link
        self.tags = {'brand': 'Magyar Posta', 'operator': 'Magyar Posta Zrt.', 'ref:vatin:hu': '10901232-2-44',

This line is too long as per the coding-style (111/100).

                     'ref:vatin': 'HU10901232', 'brand:wikipedia': 'hu:Magyar Posta Zrt.', 'brand:wikidata': 'Q145614',

This line is too long as per the coding-style (119/100).

                     'contact:email': 'ugyfelszolgalat@posta.hu', 'phone': '+3617678200',
                     'contact:facebook': 'https://www.facebook.com/MagyarPosta',
                     'contact:youtube': 'https://www.youtube.com/user/magyarpostaofficial',
                     'contact:instagram': 'https://www.instagram.com/magyar_posta_zrt/',
                     'payment:cash': 'yes', 'payment:debit_cards': 'yes'}
        self.filetype = FileType.json
        self.filename = '{}.{}'.format(
            self.__class__.__name__, self.filetype.name)
        self.download_cache = download_cache
        self.filename = filename

    def types(self):
        hupostapo = {'amenity': 'post_office'}
        hupostapo.update(self.tags)
        hupostacse = {'amenity': 'vending_machine', 'vending': 'cheques'}
        hupostacse.update(self.tags)
        hupostacso = {'amenity': 'vending_machine', 'vending': 'parcel_pickup'}
        hupostacso.update(self.tags)
        hupostapp = {'amenity': 'post_office'}
        hupostapp.update(self.tags)
        hupostamp = {'amenity': 'post_office'}
        hupostamp.update(self.tags)

        data = [
            {'poi_code': 'hupostapo', 'poi_name': 'Posta', 'poi_type': 'post_office',
             'poi_tags': hupostapo, 'poi_url_base': 'https://www.posta.hu', 'poi_search_name': 'posta'},

This line is too long as per the coding-style (104/100).

            {'poi_code': 'hupostacse', 'poi_name': 'Posta csekkautomata', 'poi_type': 'vending_machine_cheques',

This line is too long as per the coding-style (112/100).

             'poi_tags': hupostacse, 'poi_url_base': 'https://www.posta.hu', 'poi_search_name': 'posta'},

This line is too long as per the coding-style (105/100).

            {'poi_code': 'hupostacso', 'poi_name': 'Posta csomagautomata',
             'poi_type': 'vending_machine_parcel_pickup',
             'poi_tags': hupostacso, 'poi_url_base': 'https://www.posta.hu', 'poi_search_name': '(mpl|posta)'},

This line is too long as per the coding-style (111/100).

            {'poi_code': 'hupostapp', 'poi_name': 'PostaPont', 'poi_type': 'post_office',
             'poi_tags': hupostapp, 'poi_url_base': 'https://www.posta.hu', 'poi_search_name': '(postapont|posta)'},

This line is too long as per the coding-style (116/100).

            {'poi_code': 'hupostamp', 'poi_name': 'Mobilposta', 'poi_type': 'post_office',
             'poi_tags': hupostamp, 'poi_url_base': 'https://www.posta.hu', 'poi_search_name': 'posta'}]

This line is too long as per the coding-style (104/100).

        return data

    def process(self):
        soup = save_downloaded_soup('{}'.format(self.link), os.path.join(self.download_cache, self.filename),

This line is too long as per the coding-style (109/100).

                                    self.filetype)
        if soup is not None:
            text = json.loads(soup)
            data = POIDataset()
            for poi_data in text['items']:
                if poi_data['type'] == 'posta':
                    if 'mobilposta' in poi_data['name']:
                        data.name = 'Mobilposta'
                        data.code = 'hupostamp'
                    else:
                        data.name = 'Posta'
                        data.code = 'hupostapo'
                        data.public_holiday_open = False
                elif poi_data['type'] == 'csekkautomata':
                    data.name = 'Posta csekkautomata'
                    data.code = 'hupostacse'
                    data.public_holiday_open = True
                elif poi_data['type'] == 'postamachine':
                    data.name = 'Posta csomagautomata'
                    data.code = 'hupostacso'
                    data.public_holiday_open = True
                elif poi_data['type'] == 'postapoint':
                    data.name = 'PostaPont'
                    data.code = 'hupostapp'
                    data.public_holiday_open = False
                else:
                    logging.error('Non existing Posta type.')
                data.postcode = poi_data['zipCode'].strip()
                data.city = clean_city(poi_data['city'])
                data.branch = poi_data['name']
                data.lat = poi_data['lat']
                data.lon = poi_data['lng']
                data.street, data.housenumber, data.conscriptionnumber = extract_street_housenumber_better_2(

This line is too long as per the coding-style (109/100).

                    poi_data['address'])
                data.original = poi_data['address']
                data.add()
            if data is None or data.lenght() < 1:
                logging.warning('Resultset is empty. Skipping ...')
            else:
                insert_poi_dataframe(self.session, data.process())