osm_poi_matchmaker.dataproviders.hu_kh_bank

Complexity

Total Complexity

16

Size/Duplication

Total Lines	98
Duplicated Lines	11.22 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hu_kh_bank.types()	0	18	1
A	hu_kh_bank.__init__()	11	12	1
F	hu_kh_bank.process()	0	44	14

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import json
    from osm_poi_matchmaker.dao.data_handlers import insert_poi_dataframe
    from osm_poi_matchmaker.libs.address import extract_all_address, clean_phone_to_str
    from osm_poi_matchmaker.libs.geo import check_hu_boundary
    from osm_poi_matchmaker.libs.poi_dataset import POIDataset
    from osm_poi_matchmaker.utils.data_provider import DataProvider
    from osm_poi_matchmaker.utils.enums import FileType
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


class hu_kh_bank(DataProvider):

Class name "hu_kh_bank" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

Missing class docstring

Too many instance attributes (9/7)

    def __init__(self, session, download_cache, prefer_osm_postcode, link, name):

This code seems to be duplicated in your project.

The __init__ method of the super-class DataProvider is not called.

Too many arguments (6/5)

        self.session = session
        self.download_cache = download_cache
        self.link = link
        self.tags = {'brand': 'K&H', 'operator': 'K&H Bank Zrt.',
                     'operator:addr': '1095 Budapest, Lechner Ödön fasor 9.', 'bic': 'OKHBHUHB',
                     'ref:vatin': 'HU10195664', 'ref:vatin:hu': '10195664-4-44', 'ref:HU:company': '01 10 041043', }

This line is too long as per the coding-style (116/100).

        self.prefer_osm_postcode = prefer_osm_postcode
        self.name = name
        self.filetype = FileType.json
        self.filename = '{}.{}'.format(
            self.__class__.__name__, self.filetype.name)

    def types(self):
        hukhbank = {'amenity': 'bank', 'atm': 'yes',
                    'air_conditioning': 'yes', }
        hukhbank.update(self.tags)
        hukhatm = {'amenity': 'atm'}
        hukhatm.update(self.tags)
        self.__types = [
            {'poi_code': 'hukhbank', 'poi_name': 'K&H Bank', 'poi_type': 'bank',
             'poi_tags': hukhbank, 'poi_url_base': 'https://www.kh.hu',
             'poi_search_name': '(kh bank|k&h bank|k&h|kh)', 'osm_search_distance_perfect': 2000,
             'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 4},
            {'poi_code': 'hukhatm', 'poi_name': 'K&H Bank ATM', 'poi_type': 'atm',
             'poi_tags': hukhatm, 'poi_url_base': 'https://www.kh.hu',
             'poi_search_name': '(kh bank atm|k&h bank atm|k&h atm|kh atm)',
             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 80,
             'osm_search_distance_unsafe': 3},
        ]
        return self.__types

    def process(self):
        try:
            if self.link:
                with open(self.link, 'r') as f:

Variable name "f" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                    text = json.load(f)
                    data = POIDataset()
                    for poi_data in text['results']:
                        first_element = next(iter(poi_data))
                        if self.name == 'K&H Bank':
                            data.name = 'K&H Bank'
                            data.code = 'hukhbank'
                            data.public_holiday_open = False
                        elif self.name == 'K&H Bank ATM':
                            data.name = 'K&H Bank ATM'
                            data.code = 'hukhatm'
                            data.public_holiday_open = True
                        if data.code == 'hukhatm':
                            data.nonstop = True
                        else:
                            data.nonstop = False
                        data.lat, data.lon = check_hu_boundary(poi_data.get(first_element)['latitude'],

This line is too long as per the coding-style (103/100).

                                                               poi_data.get(first_element)['longitude'])

This line is too long as per the coding-style (104/100).

                        if poi_data.get(first_element)['address'] is not None and \
                                poi_data.get(first_element)['address'] != '':
                            data.postcode, data.city, data.street, data.housenumber, data.conscriptionnumber = \

This line is too long as per the coding-style (112/100).

                                extract_all_address(
                                    poi_data.get(first_element)['address'])
                            data.original = poi_data.get(
                                first_element)['address']
                        if poi_data.get('phoneNumber') is not None and poi_data.get('phoneNumber') != '':

This line is too long as per the coding-style (105/100).

                            data.phone = clean_phone_to_str(
                                poi_data.get('phoneNumber'))
                        else:
                            data.phone = None
                        data.add()
                    if data is None or data.lenght() < 1:
                        logging.warning('Resultset is empty. Skipping ...')
                    else:
                        insert_poi_dataframe(self.session, data.process())
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            logging.exception('Exception occurred')

            logging.error(e)
            logging.error(poi_data)

The variable poi_data does not seem to be defined for all execution paths.