osm_poi_matchmaker.dataproviders.hu_foxpost

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	16.25 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hu_foxpost.types()	0	10	1
B	hu_foxpost.process()	0	32	6
A	hu_foxpost.constains()	13	13	1

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import os
    import json
    from osm_poi_matchmaker.libs.soup import save_downloaded_soup
    from osm_poi_matchmaker.libs.address import extract_street_housenumber_better_2, clean_city, clean_opening_hours

This line is too long as per the coding-style (116/100).

    from osm_poi_matchmaker.libs.geo import check_hu_boundary
    from osm_poi_matchmaker.utils.enums import WeekDaysLongHUUnAccented
    from osm_poi_matchmaker.utils.data_provider import DataProvider
    from osm_poi_matchmaker.utils.enums import FileType
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


class hu_foxpost(DataProvider):

Class name "hu_foxpost" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

Missing class docstring

    def constains(self):

This code seems to be duplicated in your project.

        self.link = 'https://cdn.foxpost.hu/foxpost_terminals_extended_v3.json'
        self.tags = {'brand': 'Foxpost', 'operator': 'FoxPost Zrt.',
                     'operator:addr': '3200 Gyöngyös, Batsányi János utca 9.', 'ref:vatin': 'HU25034644',

This line is too long as per the coding-style (105/100).

                     'ref:vatin:hu': '25034644-2-10', 'ref:HU:company': '10 10 020309',
                     'contact:facebook': 'https://www.facebook.com/foxpostzrt',
                     'contact:youtube': 'https://www.youtube.com/channel/UC3zt91sNKPimgA32Nmcu97w',
                     'contact:email': 'info@foxpost.hu', 'phone': '+36 1 999 03 69',
                     'payment:contactless': 'yes', 'payment:mastercard': 'yes', 'payment:visa': 'yes',

This line is too long as per the coding-style (102/100).

                     'payment:cash': 'no', }
        self.filetype = FileType.json
        self.filename = '{}.{}'.format(
            self.__class__.__name__, self.filetype.name)

    def types(self):
        hufoxpocso = {'amenity': 'vending_machine',
                      'vending': 'parcel_pickup;parcel_mail_in'}
        hufoxpocso.update(self.tags)
        self.__types = [
            {'poi_code': 'hufoxpocso', 'poi_name': 'Foxpost', 'poi_type': 'vending_machine_parcel_pickup_and_mail_in',

This line is too long as per the coding-style (118/100).

             'poi_tags': hufoxpocso, 'poi_url_base': 'https://www.foxpost.hu', 'poi_search_name': 'foxpost',

This line is too long as per the coding-style (108/100).

             'osm_search_distance_perfect': 1000, 'osm_search_distance_safe': 400, 'osm_search_distance_unsafe': 20},

This line is too long as per the coding-style (117/100).

        ]
        return self.__types

    def process(self):
        try:
            soup = save_downloaded_soup('{}'.format(self.link), os.path.join(self.download_cache, self.filename),

This line is too long as per the coding-style (113/100).

                                        self.filetype)
            if soup is not None:
                text = json.loads(soup)
                for poi_data in text:
                    self.data.name = 'Foxpost'
                    self.data.code = 'hufoxpocso'
                    self.data.postcode = poi_data['zip'].strip()
                    self.data.city = clean_city(poi_data['city'])
                    self.data.branch = poi_data['name']
                    for i in range(0, 7):
                        if poi_data['open'][WeekDaysLongHUUnAccented(i).name.lower()] is not None:
                            opening, closing = clean_opening_hours(
                                poi_data['open'][WeekDaysLongHUUnAccented(i).name.lower()])
                            self.data.day_open(i, opening)
                            self.data.day_close(i, closing)
                        else:
                            self.data.day_open_close(i, None, None)
                    self.data.original = poi_data['address']
                    self.data.lat, self.data.lon = check_hu_boundary(
                        poi_data['geolat'], poi_data['geolng'])
                    self.data.street, self.data.housenumber, self.data.conscriptionnumber = extract_street_housenumber_better_2(

This line is too long as per the coding-style (128/100).

                        poi_data['street'])
                    self.data.public_holiday_open = False
                    self.data.description = poi_data.get('findme')
                    self.data.add()
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            logging.exception('Exception occurred')

            logging.error(e)