osm_poi_matchmaker.dataproviders.hu_cba

Complexity

Total Complexity

16

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hu_cba.constains()	0	8	1
A	hu_cba.types()	0	28	2
D	hu_cba.process()	0	44	13

# -*- coding: utf-8 -*-

Missing module docstring

try:
    import logging
    import sys
    import os
    import re

The import re seems to be unused.

    import json
    from osm_poi_matchmaker.libs.soup import save_downloaded_soup
    from osm_poi_matchmaker.libs.address import extract_street_housenumber_better_2, clean_city, \
        extract_javascript_variable, clean_opening_hours_2, clean_phone_to_str
    from osm_poi_matchmaker.libs.geo import check_hu_boundary
    from osm_poi_matchmaker.libs.osm_tag_sets import POS_HU_GEN, PAY_CASH
    from osm_poi_matchmaker.utils.data_provider import DataProvider
    from osm_poi_matchmaker.utils.enums import FileType
except ImportError as err:
    logging.error('Error %s import module: %s', __name__, err)
    logging.exception('Exception occurred')

    sys.exit(128)


class hu_cba(DataProvider):

Class name "hu_cba" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

Missing class docstring

    def constains(self):
        self.link = 'http://www.cba.hu/uzletlista'
        self.tags = {}
        self.tags.update(POS_HU_GEN)
        self.tags.update(PAY_CASH)
        self.filetype = FileType.html
        self.filename = '{}.{}'.format(
            self.__class__.__name__, self.filetype.name)

    def types(self):
        hucbacon = {'shop': 'convenience', 'brand': 'CBA', }
        hucbasup = {'shop': 'supermarket', 'brand': 'CBA', }
        huprimacon = {'shop': 'convenience', 'brand': 'Príma', }
        huprimasup = {'shop': 'supermarket', 'brand': 'Príma', }
        for i in [hucbacon, hucbasup, huprimacon, huprimasup]:
            i.update(self.tags)
        self.__types = [
            {'poi_code': 'hucbacon', 'poi_name': 'CBA', 'poi_type': 'shop',
             'poi_tags': hucbacon, 'poi_url_base': 'https://www.cba.hu', 'poi_search_name': '(cba abc|cba)',

This line is too long as per the coding-style (108/100).

             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 5,

This line is too long as per the coding-style (115/100).

             'preserve_original_name': True},
            {'poi_code': 'hucbasup', 'poi_name': 'CBA', 'poi_type': 'shop',
             'poi_tags': hucbasup, 'poi_url_base': 'https://www.cba.hu', 'poi_search_name': '(cba abc|cba)',

This line is too long as per the coding-style (108/100).

             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 5,

This line is too long as per the coding-style (115/100).

             'preserve_original_name': True},
            {'poi_code': 'huprimacon', 'poi_name': 'Príma', 'poi_type': 'shop',
             'poi_tags': huprimacon, 'poi_url_base': 'https://www.prima.hu',
             'poi_search_name': '(príma abc|prima abc|príma|prima)',
             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 23,

This line is too long as per the coding-style (116/100).

             'preserve_original_name': True},
            {'poi_code': 'huprimasup', 'poi_name': 'Príma', 'poi_type': 'shop',
             'poi_tags': huprimasup, 'poi_url_base': 'https://www.prima.hu',
             'poi_search_name': '(príma abc|prima abc|príma|prima)',
             'osm_search_distance_perfect': 2000, 'osm_search_distance_safe': 200, 'osm_search_distance_unsafe': 23,

This line is too long as per the coding-style (116/100).

             'preserve_original_name': True},
        ]
        return self.__types

    def process(self):
        try:
            soup = save_downloaded_soup('{}'.format(self.link), os.path.join(self.download_cache, self.filename),

This line is too long as per the coding-style (113/100).

                                        self.filetype)
            if soup is not None:
                # parse the html using beautiful soap and store in variable `soup`
                text = json.loads(
                    extract_javascript_variable(soup, 'boltok_nyers'))
                for poi_data in text:
                    # Assign: code, postcode, city, name, branch, website, original, street, housenumber, conscriptionnumber, ref, geom

This line is too long as per the coding-style (135/100).

                    self.data.city = clean_city(poi_data.get('A_VAROS'))
                    self.data.postcode = poi_data.get('A_IRSZ').strip()
                    self.data.branch = poi_data.get('P_NAME').strip()
                    self.data.name = 'Príma' if 'Príma' in self.data.branch else 'CBA'
                    self.data.code = 'huprimacon' if 'Príma' in self.data.branch else 'hucbacon'
                    for i in range(0, 7):
                        self.data.day_open(i, clean_opening_hours_2(
                            poi_data.get('PS_OPEN_FROM_{}'.format(i + 1))) if poi_data.get(
                            'PS_OPEN_FROM_{}'.format(

Wrong hanging indentation (add 4 spaces).

                                i + 1)) is not None else None)
                        self.data.day_close(i, clean_opening_hours_2(
                            poi_data.get('PS_OPEN_TO_{}'.format(i + 1))) if poi_data.get(
                            'PS_OPEN_TO_{}'.format(

Wrong hanging indentation (add 4 spaces).

                                i + 1)) is not None else None)
                    self.data.original = poi_data.get('A_CIM')
                    self.data.lat, self.data.lon = check_hu_boundary(poi_data.get('PS_GPS_COORDS_LAT'),

This line is too long as per the coding-style (103/100).

                                                                     poi_data.get('PS_GPS_COORDS_LNG'))

This line is too long as per the coding-style (103/100).

                    self.data.street, self.data.housenumber, self.data.conscriptionnumber = extract_street_housenumber_better_2(

This line is too long as per the coding-style (128/100).

                        poi_data.get('A_CIM'))
                    if 'PS_PUBLIC_TEL' in poi_data and poi_data.get('PS_PUBLIC_TEL') != '':
                        self.data.phone = clean_phone_to_str(
                            poi_data.get('PS_PUBLIC_TEL'))
                    else:
                        self.data.phone = None
                    if 'PS_PUBLIC_EMAIL' in poi_data and poi_data.get('PS_PUBLIC_EMAIL') != '':
                        self.data.email = poi_data.get('PS_PUBLIC_EMAIL')
                    else:
                        self.data.email = None
                    self.data.public_holiday_open = False
                    self.data.add()
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

Variable name "e" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            logging.exception('Exception occurred')

            logging.error(e)