osm_poi_matchmaker.dataproviders.attic.hu_tesco.hu_tesco.process()

Complexity

Conditions

8

Size

Total Lines	65
Code Lines	61

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

# -*- coding: utf-8 -*-
    def process(self):

Missing function or method docstring

This function exceeds the maximum number of variables (39/15).

        soup = save_downloaded_soup('{}'.format(self.link), os.path.join(self.download_cache, self.filename))

This line is too long as per the coding-style (109/100).

It seems like a value for argument filetype is missing in the function call.

        data = []
        if soup is not None:
            # parse the html using beautiful soap and store in variable `soup`
            table = soup.find('table', attrs={'class': 'tescoce-table'})
            table_body = table.find('tbody')
            rows = table_body.find_all('tr')
            for row in rows:
                cols = row.find_all('td')
                link = cols[0].find('a').get('href') if cols[0].find('a') is not None else []
                cols = [element.text.strip() for element in cols]
                cols[0] = cols[0].split('\n')[0]
                del cols[-1]
                del cols[-1]
                cols.append(link)
                data.append(cols)
            for poi_data in data:
                # Assign: code, postcode, city, name, branch, website, original, street, housenumber, conscriptionnumber, ref, geom

This line is too long as per the coding-style (131/100).

                street, housenumber, conscriptionnumber = extract_street_housenumber_better_2(poi_data[3])

This line is too long as per the coding-style (106/100).

                tesco_replace = re.compile('(expressz{0,1})', re.IGNORECASE)
                poi_data[0] = tesco_replace.sub('Expressz', poi_data[0])
                if 'xpres' in poi_data[0]:
                    name = 'Tesco Expressz'
                    code = 'hutescoexp'
                elif 'xtra' in poi_data[0]:
                    name = 'Tesco Extra'
                    code = 'hutescoext'
                else:
                    name = 'Tesco'
                    code = 'hutescosup'
                poi_data[0] = poi_data[0].replace('TESCO', 'Tesco')
                poi_data[0] = poi_data[0].replace('Bp.', 'Budapest')
                postcode = poi_data[1].strip()
                city = clean_city(poi_data[2].split(',')[0])
                branch = poi_data[0]
                website = poi_data[4]
                nonstop = None
                mo_o = None
                th_o = None
                we_o = None
                tu_o = None
                fr_o = None
                sa_o = None
                su_o = None
                mo_c = None
                th_c = None
                we_c = None
                tu_c = None
                fr_c = None
                sa_c = None
                su_c = None
                original = poi_data[3]
                geom = None
                ref = None
                insert_data.append(

The variable insert_data does not seem to be defined.

Undefined variable 'insert_data'

                    [code, postcode, city, name, branch, website, original, street, housenumber, conscriptionnumber,

This line is too long as per the coding-style (116/100).

                     ref, geom, nonstop, mo_o, tu_o, we_o, th_o, fr_o, sa_o, su_o, mo_c, th_c, we_c, tu_c, fr_c, sa_c,

This line is too long as per the coding-style (118/100).

                     su_c])
            if len(insert_data) < 1:

Undefined variable 'insert_data'

                logging.warning('Resultset is empty. Skipping ...')
            else:
                df = pd.DataFrame(insert_data)

Variable name "df" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Undefined variable 'insert_data'

                df.columns = POI_COLS
                insert_poi_dataframe(self.session, df)