GenericSqlDefinitions::create() - Code Metrics - Inspection of "Fixes a bug where you cannot use a runtime operato..." - K-Phoen/rulerz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#82)

unknown

created 2018-01-09 13:43 UTC

GenericSqlDefinitions::create() A

↳ Parent: GenericSqlDefinitions

Complexity

Conditions	2
Paths	1

Size

Total Lines	51
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	9.4109
c	0
b	0
f	0
cc	2
eloc	33
nc	1
nop	1

How to fix Long Method

<?php

namespace RulerZ\Target\Operators;

class GenericSqlDefinitions
{
    /**
     * @return Definitions
     */
    public static function create(Definitions $customOperators)
    {
        $defaultInlineOperators = [
            'and' => function ($a, $b) {
                return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'AND'));
            },
            'or' => function ($a, $b) {
                return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'OR'));
            },
            'not' => function ($a) {
                return sprintf('NOT (%s)', OperatorTools::inlineMixedInstructions([$a]));
            },
            '=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '=');
            },
            '!=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '!=');
            },
            '>' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '>');
            },
            '>=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '>=');
            },
            '<' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '<');
            },
            '<=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '<=');
            },
            'in' => function ($a, $b) {
                if ($b[0] === '(') {
                    return OperatorTools::inlineMixedInstructions([$a, $b], 'IN');
                } else {
                    return sprintf(
                        '%s IN (%s)',
                        OperatorTools::inlineMixedInstructions([$a]),
                        OperatorTools::inlineMixedInstructions([$b])
                    );
                }
            },
            'like' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], 'LIKE');
            },
        ];

        $definitions = new Definitions();
        $definitions->defineInlineOperators($defaultInlineOperators);

        return $definitions->mergeWith($customOperators);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace RulerZ\Target\Operators;
4
5			class GenericSqlDefinitions
6			{
7			/**
8			* @return Definitions
9			*/
10			public static function create(Definitions $customOperators)
11			{
12			$defaultInlineOperators = [
13			'and' => function ($a, $b) {
14			return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'AND'));
15			},
16			'or' => function ($a, $b) {
17			return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'OR'));
18			},
19			'not' => function ($a) {
20			return sprintf('NOT (%s)', OperatorTools::inlineMixedInstructions([$a]));
21			},
22			'=' => function ($a, $b) {
23			return OperatorTools::inlineMixedInstructions([$a, $b], '=');
24			},
25			'!=' => function ($a, $b) {
26			return OperatorTools::inlineMixedInstructions([$a, $b], '!=');
27			},
28			'>' => function ($a, $b) {
29			return OperatorTools::inlineMixedInstructions([$a, $b], '>');
30			},
31			'>=' => function ($a, $b) {
32			return OperatorTools::inlineMixedInstructions([$a, $b], '>=');
33			},
34			'<' => function ($a, $b) {
35			return OperatorTools::inlineMixedInstructions([$a, $b], '<');
36			},
37			'<=' => function ($a, $b) {
38			return OperatorTools::inlineMixedInstructions([$a, $b], '<=');
39			},
40			'in' => function ($a, $b) {
41			if ($b[0] === '(') {
42			return OperatorTools::inlineMixedInstructions([$a, $b], 'IN');
43			} else {
44			return sprintf(
45			'%s IN (%s)',
46			OperatorTools::inlineMixedInstructions([$a]),
47			OperatorTools::inlineMixedInstructions([$b])
48			);
49			}
50			},
51			'like' => function ($a, $b) {
52			return OperatorTools::inlineMixedInstructions([$a, $b], 'LIKE');
53			},
54			];
55
56			$definitions = new Definitions();
57			$definitions->defineInlineOperators($defaultInlineOperators);
58
59			return $definitions->mergeWith($customOperators);
			0 ignored issues – show Documentation introduced 2017-12-29 17:40 UTC by Report Bug Copy Issue Report `$customOperators` is of type `object<RulerZ\Target\Operators\Definitions>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60			}
61			}
62

K-Phoen / rulerz

Pull Request — master (#82)

GenericSqlDefinitions::create() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like