HSPHPTest - Code Metrics - Inspection of "add more tests" - Junker/HSAL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e78332...2967a5 )

by Dmitry

created 2016-01-24 10:16 UTC

HSPHPTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	30.25 %

Coupling/Cohesion

Components	0
Dependencies	1

Metric	Value
wmc	9
lcom	0
cbo	1
dl	36
loc	119
rs	10

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testFetchColumn()	0	8	1
A	testFetchAll()	0	15	1
A	testFetchArray()	0	12	1
A	testFetchAssoc()	0	12	1
A	testDelete()	0	12	1
A	testInsert()	0	12	1
A	testUpdate()	12	12	1
A	testIncrement()	12	12	1
A	testDecrement()	12	12	1

How to fix Duplicated Code

<?php

use HSAL\HSAL;

class HSPHPTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
	public function testFetchArray()
	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->fetchArray('test', ['id','name','cnt'], [HSAL::INDEX_PRIMARY => 3]);

		$this->assertTrue(is_array($result));
		$this->assertEquals(3, count($result));
		$this->assertEquals(3, $result[0]);
		$this->assertEquals('page 3', $result[1]);
		$this->assertEquals(0, $result[2]);
	}

	public function testFetchAssoc()
	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->fetchAssoc('test', ['id','name','cnt'], [HSAL::INDEX_PRIMARY => 3]);

		$this->assertTrue(is_array($result));
		$this->assertEquals(3, count($result));
		$this->assertEquals(3, $result['id']);
		$this->assertEquals('page 3', $result['name']);
		$this->assertEquals(0, $result['cnt']);
	}

	public function testFetchColumn()
	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->fetchColumn('test', 'name', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertEquals('page 3', $result);
	}

	public function testFetchAll()
	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->fetchAll('test', ['id', 'name'], [HSAL::INDEX_PRIMARY => 3], HSAL::OPERATOR_LESS_EQUAL);

		$this->assertTrue(is_array($result));
		$this->assertEquals(3, count($result));

		$this->assertEquals(3, $result[0]['id']);
		$this->assertEquals(1, $result[2]['id']);
		
		$this->assertEquals('page 3', $result[0]['name']);
		$this->assertEquals('page 1', $result[2]['name']);
	}

	public function testDelete()
	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->delete('test', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertTrue($result);

		$result = $hs->delete('test', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertFalse($result);
	}

	public function testInsert()
	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->insert('test', ['id' => 3, 'name' => 'new page', 'cnt' => 0]);

		$this->assertTrue($result);

		$result = $hs->fetchColumn('test', 'name', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertEquals('new page', $result);
	}

	public function testUpdate()

	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->update('test', ['name' => 'updated page'], [HSAL::INDEX_PRIMARY => 3]);

		$this->assertTrue($result);

		$result = $hs->fetchColumn('test', 'name', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertEquals('updated page', $result);
	}

	public function testIncrement()

	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->increment('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertTrue($result);

		$result = $hs->fetchColumn('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertEquals(1, $result);
	}

	public function testDecrement()

	{
		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);

		$result = $hs->decrement('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertTrue($result);

		$result = $hs->fetchColumn('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);

		$this->assertEquals(0, $result);
	}

}


1		<?php
2
3		use HSAL\HSAL;
4
5		class HSPHPTest extends PHPUnit_Framework_TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-24 10:00 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6		{
7		public function testFetchArray()
8		{
9		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
10
11		$result = $hs->fetchArray('test', ['id','name','cnt'], [HSAL::INDEX_PRIMARY => 3]);
12
13		$this->assertTrue(is_array($result));
14		$this->assertEquals(3, count($result));
15		$this->assertEquals(3, $result[0]);
16		$this->assertEquals('page 3', $result[1]);
17		$this->assertEquals(0, $result[2]);
18		}
19
20		public function testFetchAssoc()
21		{
22		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
23
24		$result = $hs->fetchAssoc('test', ['id','name','cnt'], [HSAL::INDEX_PRIMARY => 3]);
25
26		$this->assertTrue(is_array($result));
27		$this->assertEquals(3, count($result));
28		$this->assertEquals(3, $result['id']);
29		$this->assertEquals('page 3', $result['name']);
30		$this->assertEquals(0, $result['cnt']);
31		}
32
33		public function testFetchColumn()
34		{
35		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
36
37		$result = $hs->fetchColumn('test', 'name', [HSAL::INDEX_PRIMARY => 3]);
38
39		$this->assertEquals('page 3', $result);
40		}
41
42		public function testFetchAll()
43		{
44		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
45
46		$result = $hs->fetchAll('test', ['id', 'name'], [HSAL::INDEX_PRIMARY => 3], HSAL::OPERATOR_LESS_EQUAL);
47
48		$this->assertTrue(is_array($result));
49		$this->assertEquals(3, count($result));
50
51		$this->assertEquals(3, $result[0]['id']);
52		$this->assertEquals(1, $result[2]['id']);
53
54		$this->assertEquals('page 3', $result[0]['name']);
55		$this->assertEquals('page 1', $result[2]['name']);
56		}
57
58		public function testDelete()
59		{
60		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
61
62		$result = $hs->delete('test', [HSAL::INDEX_PRIMARY => 3]);
63
64		$this->assertTrue($result);
65
66		$result = $hs->delete('test', [HSAL::INDEX_PRIMARY => 3]);
67
68		$this->assertFalse($result);
69		}
70
71		public function testInsert()
72		{
73		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
74
75		$result = $hs->insert('test', ['id' => 3, 'name' => 'new page', 'cnt' => 0]);
76
77		$this->assertTrue($result);
78
79		$result = $hs->fetchColumn('test', 'name', [HSAL::INDEX_PRIMARY => 3]);
80
81		$this->assertEquals('new page', $result);
82		}
83
84	View Code Duplication	public function testUpdate()
		0 ignored issues – show Duplication introduced 2016-01-24 10:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		{
86		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
87
88		$result = $hs->update('test', ['name' => 'updated page'], [HSAL::INDEX_PRIMARY => 3]);
89
90		$this->assertTrue($result);
91
92		$result = $hs->fetchColumn('test', 'name', [HSAL::INDEX_PRIMARY => 3]);
93
94		$this->assertEquals('updated page', $result);
95		}
96
97	View Code Duplication	public function testIncrement()
		0 ignored issues – show Duplication introduced 2016-01-24 10:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		{
99		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
100
101		$result = $hs->increment('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);
102
103		$this->assertTrue($result);
104
105		$result = $hs->fetchColumn('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);
106
107		$this->assertEquals(1, $result);
108		}
109
110	View Code Duplication	public function testDecrement()
		0 ignored issues – show Duplication introduced 2016-01-24 10:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		{
112		$hs = new HSAL('localhost', 'hstest', HSAL::DRIVER_HSPHP);
113
114		$result = $hs->decrement('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);
115
116		$this->assertTrue($result);
117
118		$result = $hs->fetchColumn('test', 'cnt', [HSAL::INDEX_PRIMARY => 3]);
119
120		$this->assertEquals(0, $result);
121		}
122
123		}
124

Junker / HSAL

GitHub Access Token became invalid

Push — master ( e78332...2967a5 )

HSPHPTest A

Complexity

Size/Duplication

Coupling/Cohesion

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like