server/src/models/db.js - Code Metrics - Inspection of "J7" - JuliaLind/vteam-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#12)

by Julia

created 2023-12-03 01:19 UTC

server/src/models/db.js A

↳ Parent: Project

Complexity

Total Complexity	6
Complexity/F	3

Size

Lines of Code	60
Function Count	2

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
wmc	6
eloc	26
mnd	4
bc	4
fnc	2
dl	0
loc	60
rs	10
bpm	2
cpm	3
noi	4
c	0
b	0
f	0

import mariadb from 'mariadb';

const pool = mariadb.createPool({
    host: process.env.DB_HOST,
    user: 'root',
    database: process.env.DB_DATABASE,
    password: process.env.DB_PASSWORD,
    // connectionLimit: 10,
    // multipleStatements: true,
    // namedPlaceholders: true
});

export const db = {
    pool: pool,

    queryNoArgs: async function(sql) {
        let conn;

        try {
            conn = await pool.getConnection();

            let res = await conn.query(sql);
            return res;
        } catch (err) {

            // do something
        } finally {
            if (conn) conn.end();
if (a > 0)
    b = 42;
        }
    },

    queryWithArgs: async function(sql, args) {
        let conn;

        try {
            conn = await pool.getConnection();
            let res = await conn.query(sql, args);
            return res;
        } catch (err) {

            // do something
        } finally {
            if (conn) conn.end();
if (a > 0)
    b = 42;
        }
    },


    // getUsers: async function() {
    //     let conn;

    //     try {
    //         conn = await pool.getConnection();
    //         let sql = `CALL all_users();`;
    //         let res = await conn.query(sql);
    //         return res[0];
    //     } catch (err) {
    //         // do something
    //     } finally {
    //         if (conn) conn.end();
    //     }
    // }
}

1			import mariadb from 'mariadb';
2
3			const pool = mariadb.createPool({
4			host: process.env.DB_HOST,
5			user: 'root',
6			database: process.env.DB_DATABASE,
7			password: process.env.DB_PASSWORD,
8			// connectionLimit: 10,
9			// multipleStatements: true,
10			// namedPlaceholders: true
11			});
12
13			export const db = {
14			pool: pool,
15
16			queryNoArgs: async function(sql) {
17			let conn;
18
19			try {
20			conn = await pool.getConnection();
21
22			let res = await conn.query(sql);
23			return res;
24			} catch (err) {
			0 ignored issues – show Coding Style Comprehensibility Best Practice introduced 2023-11-30 00:54 UTC by Report Bug Copy Issue Report Empty catch clauses should be used with caution; consider adding a comment why this is needed. Loading history...
25			// do something
26			} finally {
27			if (conn) conn.end();
			0 ignored issues – show Coding Style Best Practice introduced 2023-12-03 01:06 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
28			}
29			},
30
31			queryWithArgs: async function(sql, args) {
32			let conn;
33
34			try {
35			conn = await pool.getConnection();
36			let res = await conn.query(sql, args);
37			return res;
38			} catch (err) {
			0 ignored issues – show Coding Style Comprehensibility Best Practice introduced 2023-12-03 01:06 UTC by Report Bug Copy Issue Report Empty catch clauses should be used with caution; consider adding a comment why this is needed. Loading history...
39			// do something
40			} finally {
41			if (conn) conn.end();
			0 ignored issues – show Coding Style Best Practice introduced 2023-12-03 01:06 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
42			}
43			},
44
45
46			// getUsers: async function() {
47			// let conn;
48
49			// try {
50			// conn = await pool.getConnection();
51			// let sql = `CALL all_users();`;
52			// let res = await conn.query(sql);
53			// return res[0];
54			// } catch (err) {
55			// // do something
56			// } finally {
57			// if (conn) conn.end();
58			// }
59			// }
60			}

JuliaLind / vteam-server

Pull Request — main (#12)

server/src/models/db.js A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like