Translator::getBackend() - Code Metrics - Inspection of "added class Translator, see #7 ." - JuKu/JuKuCMS - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 2bd40b...066834 )

by Justin

created 2018-04-07 10:26 UTC

Translator::getBackend() A

↳ Parent: Translator

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	12
rs	9.4285
cc	2
eloc	6
nc	2
nop	0

<?php

/**
 * Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */


/**
 * Project: JuKuCMS
 * License: Apache 2.0 license
 * User: Justin
 * Date: 07.04.2018
 * Time: 12:18
 */

class Translator {

	protected static $backend = null;

	public static function translate (string $key, string $category = "") : string {
		self::getBackend()->translate($key, $category);
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
	}

	public static function &getBackend () : Translator_Backend {
		if (self::$backend == null) {
			//get translator backend
			$class_name = Settings::get("translator_class_name", "GetTextBackend");

			self::$backend = new $class_name();

			//initialize backend with current language
			self::$backend->init(Registry::singleton()->getSetting("lang_token"));
		}

		return self::$backend;
	}

}

?>



1			<?php
2
3			/**
4			* Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19
20			/**
21			* Project: JuKuCMS
22			* License: Apache 2.0 license
23			* User: Justin
24			* Date: 07.04.2018
25			* Time: 12:18
26			*/
27
28			class Translator {
29
30			protected static $backend = null;
31
32			public static function translate (string $key, string $category = "") : string {
33			self::getBackend()->translate($key, $category);
			0 ignored issues – show Bug Best Practice introduced 2018-04-07 10:30 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
34			}
35
36			public static function &getBackend () : Translator_Backend {
37			if (self::$backend == null) {
38			//get translator backend
39			$class_name = Settings::get("translator_class_name", "GetTextBackend");
40
41			self::$backend = new $class_name();
42
43			//initialize backend with current language
44			self::$backend->init(Registry::singleton()->getSetting("lang_token"));
45			}
46
47			return self::$backend;
48			}
49
50			}
51
52			?>
			0 ignored issues – show Best Practice introduced 2018-04-07 10:30 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
53

JuKu / JuKuCMS

Push — master ( 2bd40b...066834 )

Translator::getBackend() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like