Test Failed
Branch master (d0d855)
by Justin
04:11
created
setup/db-repair.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -159,10 +159,10 @@  discard block
 block discarded – undo
159 159
 $table->addVarchar("home_page", 255, true, "home");
160 160
 $table->addEnum("wildcard", array("YES", "NO"), true, "NO");
161 161
 $table->addInt("styleID", 10, true, false, "-1");
162
-$table->addVarchar("redirect_url", 255, true, "none");#
162
+$table->addVarchar("redirect_url", 255, true, "none"); #
163 163
 $table->addInt("redirect_code", 10, true, false, "301");
164 164
 $table->addVarchar("base_dir", 255, true, "/");
165
-$table->addInt("force_ssl", 10, true, false, "0");//if 1 then all http urls would be rewritten to https urls
165
+$table->addInt("force_ssl", 10, true, false, "0"); //if 1 then all http urls would be rewritten to https urls
166 166
 $table->addTimestamp("lastUpdate", true, "CURRENT_TIMESTAMP");
167 167
 $table->addInt("activated", 10, true, false, "1");
168 168
 
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 $table->addInt("local_menu", 10, true, false, -1);
413 413
 $table->addVarchar("page_type", 255, true, "HTMLPage");
414 414
 $table->addVarchar("design", 255, true, "none");
415
-$table->addInt("sitemap", 10, true, false, 1);//should page be shown in sitemap?
415
+$table->addInt("sitemap", 10, true, false, 1); //should page be shown in sitemap?
416 416
 $table->addInt("published", 10, true, false, 0);
417 417
 $table->addInt("version", 10, true, false, 1);
418 418
 $table->addTimestamp("last_update", true, "0000-00-00 00:00:00", true);
@@ -449,9 +449,9 @@  discard block
 block discarded – undo
449 449
 //fields
450 450
 $table->addVarchar("page_type", 255, true);
451 451
 $table->addVarchar("title", 255, true);
452
-$table->addVarchar("create_permissions", 255, true, "none");//list with permissions (OR), one of this permissions is required to create pages with this page type
453
-$table->addInt("advanced", 10, true, false, 0);//flag, if page type is only shown in expert (advanced) mode
454
-$table->addInt("order", 10, true, false, 10);//order in admin area on page creation selection
452
+$table->addVarchar("create_permissions", 255, true, "none"); //list with permissions (OR), one of this permissions is required to create pages with this page type
453
+$table->addInt("advanced", 10, true, false, 0); //flag, if page type is only shown in expert (advanced) mode
454
+$table->addInt("order", 10, true, false, 10); //order in admin area on page creation selection
455 455
 $table->addInt("activated", 10, true, false, 1);
456 456
 
457 457
 //add keys to table
@@ -512,7 +512,7 @@  discard block
 block discarded – undo
512 512
 $table->addInt("menuID", 10, true, false);
513 513
 $table->addVarchar("title", 255, true);
514 514
 $table->addVarchar("url", 600, true);
515
-$table->addVarchar("type", 255, true, "page");//page / link / url / external_link / js_link
515
+$table->addVarchar("type", 255, true, "page"); //page / link / url / external_link / js_link
516 516
 $table->addVarchar("icon", 255, true, "none");
517 517
 $table->addVarchar("permissions", 600, true, "all");
518 518
 $table->addInt("login_required", 10, true, false, 0);
@@ -590,9 +590,9 @@  discard block
 block discarded – undo
590 590
 $table->addVarchar("color", 50, true, "#0066ff");
591 591
 $table->addVarchar("rank_title", 255, true, "none");
592 592
 $table->addVarchar("rank_image", 255, true, "none");
593
-$table->addInt("auto_assign_regist", 10, true, false, "0");//flag, if group is automatically assigned to registered users
593
+$table->addInt("auto_assign_regist", 10, true, false, "0"); //flag, if group is automatically assigned to registered users
594 594
 $table->addInt("system_group", 10, true, false, "0");
595
-$table->addInt("show", 10, true, false, "1");//show group name on index page
595
+$table->addInt("show", 10, true, false, "1"); //show group name on index page
596 596
 $table->addInt("activated", 10, true, false, "1");
597 597
 
598 598
 //https://www.w3schools.com/colors/colors_picker.asp
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
756 756
 $table->addVarchar("description", 600, true);
757 757
 $table->addVarchar("category", 255, true, "general");
758 758
 $table->addVarchar("owner", 255, true, "system");
759
-$table->addInt("show", 10, true, false, 1);//flag, if permission is shown on permissions page
759
+$table->addInt("show", 10, true, false, 1); //flag, if permission is shown on permissions page
760 760
 $table->addInt("order", 10, true, false, 100);
761 761
 $table->addInt("activated", 10, true, false, 1);
762 762
 
@@ -898,7 +898,7 @@  discard block
 block discarded – undo
898 898
 Settings::create("guest_username", "Guest", "Guest Username", "Username of not-logged-in users (default: Guest).", "system", "general");
899 899
 Settings::create("online_interval", 5, "Online Interval", "Interval-Angabe in minues, how long a user is set as online (since last page request). IMPORTANT: This is independent from login interval!", "system", "general");
900 900
 Settings::create("x_frame_options", "DENY", "X-Frame-Options header value (none = dont set header).", "values: DENY, SAMEORIGIN, ALLOW-FROM https://example.com/, none", "system", "security");
901
-Settings::create("login_page","login", "Alias of Login Page (incl. directory, if necessary)", "Alias of Login Page (incl. directory, if necessary). Default: login", "system", "general");
901
+Settings::create("login_page", "login", "Alias of Login Page (incl. directory, if necessary)", "Alias of Login Page (incl. directory, if necessary). Default: login", "system", "general");
902 902
 Settings::create("logout_page", "logout", "Alias of Logout Page (incl. directory, if necessary)", "Alias of Logout Page (incl. directory, if necessary). Default: logout", "system", "general");
903 903
 //Settings::create("base_dir", "/", "Base directory", "Base directory (if this CMS is installed in root directory, the right option is '/', but if it is installed in a sub directory, the right option is '/sub-dir/'). Default: /", "system", "general");
904 904
 Settings::create("css_cache_strategy", "expires_header", "CSS Browser Cache Strategy", "CSS Browser Cache Strategy, values: expires_header, etag_header, none", "system", "general");
@@ -978,7 +978,7 @@  discard block
 block discarded – undo
978 978
 
979 979
 echo "Create default page types if absent...<br />";
980 980
 
981
-PageType::createPageType("HTMLPage", "HTML page", false, 1);//order 1 - so show as first page type in admin area
981
+PageType::createPageType("HTMLPage", "HTML page", false, 1); //order 1 - so show as first page type in admin area
982 982
 PageType::createPageType("Error404Page", "Error 404 page", true);
983 983
 PageType::createPageType("Error403Page", "Error 403 page", true);
984 984
 PageType::createPageType("IndexPage", "index page (supports extra template)", true);
@@ -1009,7 +1009,7 @@  discard block
 block discarded – undo
1009 1009
 
1010 1010
 echo "Create default permission categories...<br />";
1011 1011
 Permissions::createOrUpdateCategory("general", "General", 1);
1012
-Permissions::createOrUpdateCategory("users", "Users", 3);//user permissions, like "can_create_user"
1012
+Permissions::createOrUpdateCategory("users", "Users", 3); //user permissions, like "can_create_user"
1013 1013
 Permissions::createOrUpdateCategory("groups", "Groups", 3);
1014 1014
 Permissions::createOrUpdateCategory("pages", "Pages", 4);
1015 1015
 Permissions::createOrUpdateCategory("permissions", "Permissions", 5);
@@ -1025,7 +1025,7 @@  discard block
 block discarded – undo
1025 1025
 Permissions::createPermission("can_see_own_permissions", "Can see own permissions", "User can see his own permissions", "permissions", "system", 1);
1026 1026
 Permissions::createPermission("can_see_permissions", "Can see permissions of other users", "Can see permissions of other users", "permissions", "system", 2);
1027 1027
 Permissions::createPermission("can_edit_group_permissions", "Can edit group permissions", "Can edit group permissions (expect administrator group)", "permissions", "system", 3);
1028
-Permissions::createPermission("can_edit_administrator_group_permissions", "Can edit administrator group permissions", "Can edit administrator group permissions", "permissions", "system", 4);//can edit permissions of group "administrator"
1028
+Permissions::createPermission("can_edit_administrator_group_permissions", "Can edit administrator group permissions", "Can edit administrator group permissions", "permissions", "system", 4); //can edit permissions of group "administrator"
1029 1029
 
1030 1030
 //user permissions
1031 1031
 Permissions::createPermission("can_see_all_users", "Can see all users", "Can see all users and see their private information like mail address, ip address and so on", "users", "system", 1);
Please login to merge, or discard this patch.
system/core/driver/mysqldriver.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
     protected $prepared_cache = array();
34 34
 
35
-    public function connect ($config_path) {
35
+    public function connect($config_path) {
36 36
         if (file_exists($config_path)) {
37 37
             require($config_path);
38 38
         } else if (file_exists(CONFIG_PATH . $config_path)) {
@@ -66,15 +66,15 @@  discard block
 block discarded – undo
66 66
         }
67 67
     }
68 68
 
69
-    public function update ($sql, $params = array()) {
69
+    public function update($sql, $params = array()) {
70 70
         $this->execute($sql, $params);
71 71
     }
72 72
 
73
-    public function close () {
73
+    public function close() {
74 74
         $this->conn = null;
75 75
     }
76 76
 
77
-    public function execute ($sql, $params = array()) {
77
+    public function execute($sql, $params = array()) {
78 78
         //dont allow SELECT statements
79 79
         if (strstr($sql, "SELECT")) {
80 80
             throw new IllegalArgumentException("method DBDriver::execute() isnt for select statements, its only for write statements, use getRow() or listRows() instead.");
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
             if (!$res) {
106 106
 				if (DEBUG_MODE) {
107
-					echo "SQL Query: " + $sql;
107
+					echo "SQL Query: " +$sql;
108 108
 				}
109 109
 
110 110
                 //TODO: throw exception instead
@@ -157,15 +157,15 @@  discard block
 block discarded – undo
157 157
         }
158 158
     }
159 159
 
160
-    public function listAllDrivers () {
160
+    public function listAllDrivers() {
161 161
         return $this->conn->getAvailableDrivers();
162 162
     }
163 163
 
164
-    public function quote ($str) : string {
164
+    public function quote($str) : string {
165 165
         return $this->conn->quote($str);
166 166
     }
167 167
 
168
-    protected function getQuery ($sql, bool $allow_information_schema = false) {
168
+    protected function getQuery($sql, bool $allow_information_schema = false) {
169 169
         /**
170 170
          * check, if sql query contains comments
171 171
          *
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         return $this->queries;
300 300
     }
301 301
 
302
-    public function beginTransaction () {
302
+    public function beginTransaction() {
303 303
         $this->conn->beginTransaction();
304 304
     }
305 305
 
Please login to merge, or discard this patch.
system/core/driver/memcacheimpl.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         $this->memcache = new Memcache();
36 36
     }
37 37
 
38
-    public function connect ($host, $port) {
38
+    public function connect($host, $port) {
39 39
         $this->memcache->connect($host, $port);
40 40
     }
41 41
 
@@ -88,11 +88,11 @@  discard block
 block discarded – undo
88 88
         }
89 89
     }
90 90
 
91
-    protected function getKey ($area, $key) {
91
+    protected function getKey($area, $key) {
92 92
         return md5($area) . md5($key);
93 93
     }
94 94
 
95
-    private function listAllKeys ($limit = 10000) {
95
+    private function listAllKeys($limit = 10000) {
96 96
         //list with keys
97 97
         $keys = array();
98 98
 
Please login to merge, or discard this patch.
system/core/driver/filecache.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -44,15 +44,15 @@  discard block
 block discarded – undo
44 44
         }
45 45
     }
46 46
 
47
-    public function contains ($area, $key) : bool {
47
+    public function contains($area, $key) : bool {
48 48
 		return CACHING && file_exists($this->getFilePath($area, $key));
49 49
     }
50 50
 
51
-    protected function getFilePath (string $area, string $key) : string {
51
+    protected function getFilePath(string $area, string $key) : string {
52 52
     	return CACHE_PATH . md5($area) . "/" . md5($key) . ".php";
53 53
 	}
54 54
 
55
-    private function check_directory ($name) {
55
+    private function check_directory($name) {
56 56
         if (!file_exists(CACHE_PATH . $name . "/")) {
57 57
             mkdir(CACHE_PATH . $name . "/");
58 58
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 			$area_path = CACHE_PATH . md5($area) . "/";
80 80
 
81 81
 			if (!empty($key)) {
82
-				$file_path = CACHE_PATH . md5($area) . "/" + md5($key) + ".php";
82
+				$file_path = CACHE_PATH . md5($area) . "/" +md5($key) + ".php";
83 83
 
84 84
 				//check, if file exists
85 85
 				if (file_exists($file_path)) {
@@ -94,15 +94,15 @@  discard block
 block discarded – undo
94 94
         // TODO: Implement clear() method.
95 95
     }
96 96
 
97
-    protected function rrmdir ($dir, $cache_dir) {
97
+    protected function rrmdir($dir, $cache_dir) {
98 98
         if (is_dir($dir)) {
99 99
             $objects = scandir($dir);
100 100
             foreach ($objects as $object) {
101 101
                 if ($object != "." && $object != "..") {
102
-                    if (is_dir($dir."/".$object))
103
-                        $this->rrmdir($dir."/".$object, $cache_dir);
102
+                    if (is_dir($dir . "/" . $object))
103
+                        $this->rrmdir($dir . "/" . $object, $cache_dir);
104 104
                     else
105
-                        unlink($dir."/".$object);
105
+                        unlink($dir . "/" . $object);
106 106
                 }
107 107
             }
108 108
 
Please login to merge, or discard this patch.
system/core/driver/postgresqldriver.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 
18 18
 class PostGreSQLDriver extends MySQLDriver {
19 19
 
20
-    public function connect ($config_path) {
20
+    public function connect($config_path) {
21 21
         if (file_exists($config_path)) {
22 22
             require($config_path);
23 23
         } else if (file_exists(CONFIG_PATH . $config_path)) {
Please login to merge, or discard this patch.
system/core/driver/memcachedimpl.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
         }
164 164
     }
165 165
 
166
-    protected function getKey ($area, $key) {
166
+    protected function getKey($area, $key) {
167 167
         return md5($area) . md5($key);
168 168
     }
169 169
 
Please login to merge, or discard this patch.
system/core/classes/packages.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 
19 19
 class Packages {
20 20
 
21
-    public static function listPackages (bool $installed_required = true) : array {
21
+    public static function listPackages(bool $installed_required = true) : array {
22 22
 
23 23
         if (!file_exists(ROOT_PATH . "store/package_list.php")) {
24 24
             return array();
Please login to merge, or discard this patch.
system/core/classes/cache.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     protected static $cache_instances = array();
34 34
 
35
-    public static function init () {
35
+    public static function init() {
36 36
         require(CONFIG_PATH . "cache.php");
37 37
         
38 38
         if (!isset($config['first_lvl_cache']) || !isset($config['first_lvl_cache']['class_name'])) {
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         //TODO: load other caches
97 97
     }
98 98
 
99
-    public static function &getCache ($name = "") : ICache {
99
+    public static function &getCache($name = "") : ICache {
100 100
         if (empty($name)) {
101 101
             return self::$instance;
102 102
         } else {
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         }
110 110
     }
111 111
 
112
-    public static function &get2ndLvlCache () : ICache {
112
+    public static function &get2ndLvlCache() : ICache {
113 113
         if (self::$second_level_cache == null) {
114 114
             throw new Exception("second level cache is null.");
115 115
         }
@@ -121,11 +121,11 @@  discard block
 block discarded – undo
121 121
         return self::$second_level_cache;
122 122
     }
123 123
 
124
-    public static function containsCache ($name) {
124
+    public static function containsCache($name) {
125 125
         return isset(self::$cache_instances[$name]);
126 126
     }
127 127
 
128
-    public static function putCache ($name, &$cache_instance) {
128
+    public static function putCache($name, &$cache_instance) {
129 129
         if ($name == null || $name == "") {
130 130
             throw new NullPointerException("cache name cannot be null.");
131 131
         }
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         }
145 145
     }
146 146
 
147
-    public static function removeCache ($name) {
147
+    public static function removeCache($name) {
148 148
         unset(self::$cache_instances[$name]);
149 149
     }
150 150
 
Please login to merge, or discard this patch.
system/core/classes/autoloadercache.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
 class AutoLoaderCache {
20 20
 
21
-	public static function init () {
21
+	public static function init() {
22 22
 		//check, if directory autoloader in cache exists
23 23
 		if (!file_exists(CACHE_PATH . "autoloader")) {
24 24
 			mkdir(CACHE_PATH . "autoloader");
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 			self::createCache();
35 35
 		}
36 36
 	}
37
-	public static function load () {
37
+	public static function load() {
38 38
 		if (!file_exists(STORE_PATH . "autoloader/autoloader.php")) {
39 39
 			throw new ConfigurationException("autoloader configuration not found in store.");
40 40
 		}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 		//load classes from cache to save I/O
46 46
 		require(CACHE_PATH . "autoloader/preloaded_classes.php");
47 47
 	}
48
-	private static function createCache () {
48
+	private static function createCache() {
49 49
 		require(STORE_PATH . "autoloader/autoloader.php");
50 50
 		//create new cache file
51 51
 		$data = "";
Please login to merge, or discard this patch.