EventInstaller::uninstall() - Code Metrics - Inspection of "added event installer extension for plugin install..." - JuKu/JuKuCMS - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 249189...0dbce5 )

by Justin

created 2018-04-09 09:14 UTC

EventInstaller::uninstall() A

↳ Parent: EventInstaller

Complexity

Conditions	3
Paths	2

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	5
rs	9.4285
cc	3
eloc	2
nc	2
nop	2

<?php

/**
 * Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */


/**
 * Project: JuKuCMS
 * License: Apache 2.0 license
 * User: Justin
 * Date: 09.04.2018
 * Time: 10:50
 */

class EventInstaller extends PluginInstaller_Plugin {

	public function install(Plugin $plugin, array $install_json): bool {
		//add events if absent
		return $this->addEvents($plugin, $install_json);
	}

	public function uninstall(Plugin $plugin, array $install_json): bool {
		//check, if events are specified
		if (isset($install_json['events']) && is_array($install_json['events'])) {
			//remove all events from this plugin
			Events::removePluginEvents($plugin->getName());
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
		}
	}

	public function upgrade(Plugin $plugin, array $install_json): bool {
		//add events if absent
		return $this->addEvents($plugin, $install_json);
	}

	protected function addEvents (Plugin $plugin, array $install_json) : bool {
		//check, if events are specified
		if (isset($install_json['events']) && is_array($install_json['events'])) {
			//create events
			foreach ($install_json['events'] as $event) {
				if (!is_array($event)) {
					throw new IllegalStateException("Invalide install.json, key 'events' has to contains arrays!");
				}

				$event_name = $event['event'];

				//get type
				$type = strtolower($event['type']);

				switch ($type) {
					case "file":
						throw new Exception("UnuspportedOperationException: event type 'file' is not supported yet.");
						break;
					case "function":
						throw new Exception("UnuspportedOperationException: event type 'function' is not supported yet.");
						break;
					case "class_static_method":
						Events::addEventClass($event_name, $event['class'], $event['method'], $plugin->getName());
						break;
					default:
						throw new IllegalArgumentException("Unknown event type: " . $type . " (event: " . $event_name . ") in install.json of plugin '" . $plugin->getName() . "'!");
						break;
				}
			}
		}

		return true;
	}

}

?>



1			<?php
2
3			/**
4			* Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19
20			/**
21			* Project: JuKuCMS
22			* License: Apache 2.0 license
23			* User: Justin
24			* Date: 09.04.2018
25			* Time: 10:50
26			*/
27
28			class EventInstaller extends PluginInstaller_Plugin {
29
30			public function install(Plugin $plugin, array $install_json): bool {
31			//add events if absent
32			return $this->addEvents($plugin, $install_json);
33			}
34
35			public function uninstall(Plugin $plugin, array $install_json): bool {
36			//check, if events are specified
37			if (isset($install_json['events']) && is_array($install_json['events'])) {
38			//remove all events from this plugin
39			Events::removePluginEvents($plugin->getName());
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 09:19 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
40			}
41			}
42
43			public function upgrade(Plugin $plugin, array $install_json): bool {
44			//add events if absent
45			return $this->addEvents($plugin, $install_json);
46			}
47
48			protected function addEvents (Plugin $plugin, array $install_json) : bool {
49			//check, if events are specified
50			if (isset($install_json['events']) && is_array($install_json['events'])) {
51			//create events
52			foreach ($install_json['events'] as $event) {
53			if (!is_array($event)) {
54			throw new IllegalStateException("Invalide install.json, key 'events' has to contains arrays!");
55			}
56
57			$event_name = $event['event'];
58
59			//get type
60			$type = strtolower($event['type']);
61
62			switch ($type) {
63			case "file":
64			throw new Exception("UnuspportedOperationException: event type 'file' is not supported yet.");
65			break;
66			case "function":
67			throw new Exception("UnuspportedOperationException: event type 'function' is not supported yet.");
68			break;
69			case "class_static_method":
70			Events::addEventClass($event_name, $event['class'], $event['method'], $plugin->getName());
71			break;
72			default:
73			throw new IllegalArgumentException("Unknown event type: " . $type . " (event: " . $event_name . ") in install.json of plugin '" . $plugin->getName() . "'!");
74			break;
75			}
76			}
77			}
78
79			return true;
80			}
81
82			}
83
84			?>
			0 ignored issues – show Best Practice introduced 2018-04-09 09:19 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
85

JuKu / JuKuCMS

Push — master ( 249189...0dbce5 )

EventInstaller::uninstall() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like