PluginsPage::getContent() - Code Metrics - Inspection of "changed plugin documentation, see #124 ." - JuKu/JuKuCMS - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 0e5acb...8b15ea )

by Justin

created 2018-04-08 14:56 UTC

PluginsPage::getContent() B

↳ Parent: PluginsPage

Complexity

Conditions	3
Paths	4

Size

Total Lines	76
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	12
Bugs	2	Features	4

Metric	Value
c	12
b	2
f	4
dl	0
loc	76
rs	8.9667
cc	3
eloc	54
nc	4
nop	0

How to fix Long Method

<?php

/**
 * Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */


/**
 * Project: JuKuCMS
 * License: Apache 2.0 license
 * User: Justin
 * Date: 07.04.2018
 * Time: 21:17
 */

class PluginsPage extends PageType {

	public function getContent(): string {
		$template = new DwooTemplate("pages/plugins");

		//get list with installed plugins
		$installed_plugins = Plugins::listInstalledPlugins();

		$array = array();

		$lang_token = substr(Registry::singleton()->getSetting("lang_token"), 0, 2);

		foreach ($installed_plugins as $plugin) {
			$plugin = PLugin::castPlugin($plugin);

			$array[] = array(
				'name' => $plugin->getName(),
				'title' => $plugin->getTitle(),
				'description' => $plugin->getDescription($lang_token),
				'version' => $plugin->getVersion(),
				'installed_version' => $plugin->getInstalledVersion(),
				'homepage' => $plugin->getHomepage(),
				'authors' => $plugin->listAuthors(),
				'license' => $plugin->getLicense(),
				'keywords' => $plugin->listKeywords(),
				'categories' => $plugin->listCategories(),
				'text' => "",
				'issues' => $plugin->getIssuesLink(),
				'source' => $plugin->getSourceLink(),
				'support_mail' => $plugin->getSupportMail(),
				'support_links' => $plugin->listSupportLinks(),
				'installed' => $plugin->isInstalled(),
				'activated' => $plugin->isActivated()
			);
		}

		//assign list with installed plugins
		$template->assign("installed_plugins", $array);

		//get list with all uninstalled plugins
		$plugins = Plugins::listUninstalledPlugins();

		$plugin_list = array();

		foreach ($plugins as $plugin) {
			$plugin = PLugin::castPlugin($plugin);

			//create new instance of PluginInstaller to check plugin compatibility
			$installer = new PluginInstaller($plugin);

			$plugin_list[] = array(
				'name' => $plugin->getName(),
				'title' => $plugin->getTitle(),
				'description' => $plugin->getDescription($lang_token),
				'version' => $plugin->getVersion(),
				'installed_version' => $plugin->getInstalledVersion(),
				'homepage' => $plugin->getHomepage(),
				'authors' => $plugin->listAuthors(),
				'license' => $plugin->getLicense(),
				'keywords' => $plugin->listKeywords(),
				'categories' => $plugin->listCategories(),
				'text' => "",
				'issues' => $plugin->getIssuesLink(),
				'source' => $plugin->getSourceLink(),
				'support_mail' => $plugin->getSupportMail(),
				'support_links' => $plugin->listSupportLinks(),
				'compatible' => $installer->checkRequirements(true),
				'uptodate' => true,//TODO: check, if plugin is newest version
				'alpha' => $plugin->isAlpha(),
				'beta' => $plugin->isBeta(),
				'installed' => $plugin->isInstalled(),
				'activated' => $plugin->isActivated()
			);
		}

		$template->assign("plugins", $plugin_list);

		return $template->getCode();
	}

	public function getFooterScripts(): string {
		return "<!-- page script -->
			<script>
				$(function () {
					/*$('#example1').DataTable();*/
					$('#example2').DataTable({
						'paging'      : true,
						'lengthChange': false,
					 	'searching'   : false,
					 	'ordering'    : true,
					 	'info'        : true,
					 	'autoWidth'   : false
					});
					$('#plugintable').DataTable({
						'paging'      : true,
						'lengthChange': false,
					 	'searching'   : false,
					 	'ordering'    : true,
					 	'info'        : true,
					 	'autoWidth'   : false
					});
				});
			</script>";
	}

}

?>



1			<?php
2
3			/**
4			* Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19
20			/**
21			* Project: JuKuCMS
22			* License: Apache 2.0 license
23			* User: Justin
24			* Date: 07.04.2018
25			* Time: 21:17
26			*/
27
28			class PluginsPage extends PageType {
29
30			public function getContent(): string {
31			$template = new DwooTemplate("pages/plugins");
32
33			//get list with installed plugins
34			$installed_plugins = Plugins::listInstalledPlugins();
35
36			$array = array();
37
38			$lang_token = substr(Registry::singleton()->getSetting("lang_token"), 0, 2);
39
40			foreach ($installed_plugins as $plugin) {
41			$plugin = PLugin::castPlugin($plugin);
42
43			$array[] = array(
44			'name' => $plugin->getName(),
45			'title' => $plugin->getTitle(),
46			'description' => $plugin->getDescription($lang_token),
47			'version' => $plugin->getVersion(),
48			'installed_version' => $plugin->getInstalledVersion(),
49			'homepage' => $plugin->getHomepage(),
50			'authors' => $plugin->listAuthors(),
51			'license' => $plugin->getLicense(),
52			'keywords' => $plugin->listKeywords(),
53			'categories' => $plugin->listCategories(),
54			'text' => "",
55			'issues' => $plugin->getIssuesLink(),
56			'source' => $plugin->getSourceLink(),
57			'support_mail' => $plugin->getSupportMail(),
58			'support_links' => $plugin->listSupportLinks(),
59			'installed' => $plugin->isInstalled(),
60			'activated' => $plugin->isActivated()
61			);
62			}
63
64			//assign list with installed plugins
65			$template->assign("installed_plugins", $array);
66
67			//get list with all uninstalled plugins
68			$plugins = Plugins::listUninstalledPlugins();
69
70			$plugin_list = array();
71
72			foreach ($plugins as $plugin) {
73			$plugin = PLugin::castPlugin($plugin);
74
75			//create new instance of PluginInstaller to check plugin compatibility
76			$installer = new PluginInstaller($plugin);
77
78			$plugin_list[] = array(
79			'name' => $plugin->getName(),
80			'title' => $plugin->getTitle(),
81			'description' => $plugin->getDescription($lang_token),
82			'version' => $plugin->getVersion(),
83			'installed_version' => $plugin->getInstalledVersion(),
84			'homepage' => $plugin->getHomepage(),
85			'authors' => $plugin->listAuthors(),
86			'license' => $plugin->getLicense(),
87			'keywords' => $plugin->listKeywords(),
88			'categories' => $plugin->listCategories(),
89			'text' => "",
90			'issues' => $plugin->getIssuesLink(),
91			'source' => $plugin->getSourceLink(),
92			'support_mail' => $plugin->getSupportMail(),
93			'support_links' => $plugin->listSupportLinks(),
94			'compatible' => $installer->checkRequirements(true),
95			'uptodate' => true,//TODO: check, if plugin is newest version
96			'alpha' => $plugin->isAlpha(),
97			'beta' => $plugin->isBeta(),
98			'installed' => $plugin->isInstalled(),
99			'activated' => $plugin->isActivated()
100			);
101			}
102
103			$template->assign("plugins", $plugin_list);
104
105			return $template->getCode();
106			}
107
108			public function getFooterScripts(): string {
109			return "<!-- page script -->
110			<script>
111			$(function () {
112			/$('#example1').DataTable();/
113			$('#example2').DataTable({
114			'paging' : true,
115			'lengthChange': false,
116			'searching' : false,
117			'ordering' : true,
118			'info' : true,
119			'autoWidth' : false
120			});
121			$('#plugintable').DataTable({
122			'paging' : true,
123			'lengthChange': false,
124			'searching' : false,
125			'ordering' : true,
126			'info' : true,
127			'autoWidth' : false
128			});
129			});
130			</script>";
131			}
132
133			}
134
135			?>
			0 ignored issues – show Best Practice introduced 2018-04-07 21:11 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
136

JuKu / JuKuCMS

Push — master ( 0e5acb...8b15ea )

PluginsPage::getContent() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like