PHPInfoPage::getContent() - Code Metrics - Inspection of "fixed some problems with X-Frame-Options header in..." - JuKu/JuKuCMS - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( c7776a...1a465b )

by Justin

created 2018-04-04 13:55 UTC

PHPInfoPage::getContent() A

↳ Parent: PHPInfoPage

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	1

Metric	Value
c	3
b	2
f	1
dl	0
loc	16
rs	9.4285
cc	2
eloc	5
nc	2
nop	0

<?php

/**
 * Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */


/**
 * Project: JuKuCMS
 * License: Apache 2.0 license
 * User: Justin
 * Date: 04.04.2018
 * Time: 15:29
 */

class PHPInfoPage extends PageType {

	public function getContent(): string {
		if (isset($_REQUEST['no_design'])) {
			phpinfo();
			exit;
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
		} else {
			/*$content = "";

			ob_start();
			phpinfo();
			$content = ob_get_contents();
			ob_get_clean();

			return $content;*/

			//show iframe
			return " <iframe src=\"" . DomainUtils::generateURL("admin/phpinfo") . "?no_design=true\"></iframe> ";
		}
	}

	public function setCustomHeader() {
		//allow iframe
		header('X-Frame-Options: SAMEORIGIN');
	}

	public function showDesign() {
		return !isset($_REQUEST['no_design']);
	}

	public function listRequiredPermissions(): array {
		return array("can_see_phpinfo");
	}

}

?>



1			<?php
2
3			/**
4			* Copyright (c) 2018 Justin Kuenzel (jukusoft.com)
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19
20			/**
21			* Project: JuKuCMS
22			* License: Apache 2.0 license
23			* User: Justin
24			* Date: 04.04.2018
25			* Time: 15:29
26			*/
27
28			class PHPInfoPage extends PageType {
29
30			public function getContent(): string {
31			if (isset($_REQUEST['no_design'])) {
32			phpinfo();
33			exit;
			0 ignored issues – show Best Practice introduced 2018-04-04 14:07 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug Best Practice introduced 2018-04-04 14:07 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
34			} else {
35			/*$content = "";
36
37			ob_start();
38			phpinfo();
39			$content = ob_get_contents();
40			ob_get_clean();
41
42			return $content;*/
43
44			//show iframe
45			return " <iframe src=\"" . DomainUtils::generateURL("admin/phpinfo") . "?no_design=true\"></iframe> ";
46			}
47			}
48
49			public function setCustomHeader() {
50			//allow iframe
51			header('X-Frame-Options: SAMEORIGIN');
52			}
53
54			public function showDesign() {
55			return !isset($_REQUEST['no_design']);
56			}
57
58			public function listRequiredPermissions(): array {
59			return array("can_see_phpinfo");
60			}
61
62			}
63
64			?>
			0 ignored issues – show Best Practice introduced 2018-04-04 13:42 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
65

JuKu / JuKuCMS

Push — master ( c7776a...1a465b )

PHPInfoPage::getContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like