Issues in RememberMeService.php (master) - Issues in master - JouwWeb/JwPersistentUser - Measure and Improve Code Quality continuously with Scrutinizer

Issues (40)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/JwPersistentUser/Service/RememberMeService.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JwPersistentUser\Service;

use JwPersistentUser\Model\ModuleOptions;
use JwPersistentUser\Model\SerieTokenInterface;
use JwPersistentUser\Mapper\SerieTokenMapperInterface;

use Zend\Math\Rand;

class RememberMeService
{
    /**
     * @var SerieTokenMapperInterface
     */
    protected $mapper;

    /**
     * @var ModuleOptions
     */
    protected $moduleOptions;

    /**
     * @var UserValidityInterface
     */
    protected $userValidityInterface;

    /**
     * @param int $userId
     * @return SerieTokenInterface
     */
    public function createNew($userId)
    {
        $serieTokenClass = $this->getModuleOptions()->getSerieTokenEntityClass();
        $serieToken = new $serieTokenClass;

        /** @var $serieToken SerieTokenInterface */
        $serieToken->setUserId($userId);
        $serieToken->setSerie($this->generateRandom());
        $serieToken->setToken($this->generateRandom());
        $serieToken->setExpiresAt($this->getNewExpireDate());
        $serieToken->setValidUntil($this->getUserValidityInterface()->getValidUntilForUser($userId));

        $this->getMapper()->persist($serieToken);

        return $serieToken;
    }

    /**
     * @param SerieTokenInterface $serieToken
     * @return SerieTokenInterface|null
     */
    public function getNextInSerie(SerieTokenInterface $serieToken)
    {
        $matchingSerieToken = $this->getMapper()->find($serieToken->getUserId(), $serieToken->getSerie());
        if (!$matchingSerieToken) {
            return null;
        } elseif ($matchingSerieToken->getValidUntil() && $matchingSerieToken->getValidUntil() < new \DateTime) {
            return null;
        } elseif (!$matchingSerieToken->getExpiresAt() || $matchingSerieToken->getExpiresAt() < new \DateTime) {
            return null;
        } elseif ($matchingSerieToken->getToken() !== $serieToken->getToken()) {
            $this->removeSerie($serieToken->getUserId(), $serieToken->getSerie());
            return null;
        }

        if ($this->moduleOptions->isTokenRefreshedAfterLogin()) {
            // Generate new token in the serie
            $matchingSerieToken->setToken($this->generateRandom());
        }

        $matchingSerieToken->setExpiresAt($this->getNewExpireDate());

        $this->getMapper()->persist($matchingSerieToken);

        return $matchingSerieToken;
    }

    /**
     * @return \DateTime
     */
    protected function getNewExpireDate()
    {
        return new \DateTime('+1 year');
    }

    /**
     * @param int $userId
     * @param string $serieId
     */
    public function removeSerie($userId, $serieId)
    {
        $serieToken = $this->getMapper()->find($userId, $serieId);
        if ($serieToken) {
            $this->getMapper()->remove($serieToken);
        }
    }

    public function removeAllSeries(int $userId)
    {
        $serieTokens = $this->getMapper()->findAllByUser($userId);
        foreach ($serieTokens as $serieToken) {
            $this->getMapper()->remove($serieToken);
        }
    }

    /**
     * @note Should NOT contain semicolons.
     *
     * @return string
     */
    private function generateRandom()
    {
        return Rand::getString(10);
    }

    /**
     * @return SerieTokenMapper
     */
    public function getMapper()
    {
        return $this->mapper;
    }

    /**
     * @param SerieTokenMapper $mapper
     * @return $this
     */
    public function setMapper($mapper)
    {
        $this->mapper = $mapper;

        return $this;
    }

    /**
     * @return ModuleOptions
     */
    public function getModuleOptions()
    {
        return $this->moduleOptions;
    }

    /**
     * @param ModuleOptions $moduleOptions
     * @return $this
     */
    public function setModuleOptions($moduleOptions)
    {
        $this->moduleOptions = $moduleOptions;
        return $this;
    }

    /**
     * @return UserValidityInterface
     */
    public function getUserValidityInterface()
    {
        return $this->userValidityInterface;
    }

    /**
     * @param UserValidityInterface $userValidityInterface
     * @return $this
     */
    public function setUserValidityInterface($userValidityInterface)
    {
        $this->userValidityInterface = $userValidityInterface;
        return $this;
    }
}


1		<?php
2
3		namespace JwPersistentUser\Service;
4
5		use JwPersistentUser\Model\ModuleOptions;
6		use JwPersistentUser\Model\SerieTokenInterface;
7		use JwPersistentUser\Mapper\SerieTokenMapperInterface;
8
9		use Zend\Math\Rand;
10
11		class RememberMeService
12		{
13		/**
14		* @var SerieTokenMapperInterface
15		*/
16		protected $mapper;
17
18		/**
19		* @var ModuleOptions
20		*/
21		protected $moduleOptions;
22
23		/**
24		* @var UserValidityInterface
25		*/
26		protected $userValidityInterface;
27
28		/**
29		* @param int $userId
30		* @return SerieTokenInterface
31		*/
32	2	public function createNew($userId)
33		{
34	2	$serieTokenClass = $this->getModuleOptions()->getSerieTokenEntityClass();
35	2	$serieToken = new $serieTokenClass;
36
37		/** @var $serieToken SerieTokenInterface */
38	2	$serieToken->setUserId($userId);
39	2	$serieToken->setSerie($this->generateRandom());
40	2	$serieToken->setToken($this->generateRandom());
41	2	$serieToken->setExpiresAt($this->getNewExpireDate());
42	2	$serieToken->setValidUntil($this->getUserValidityInterface()->getValidUntilForUser($userId));
43
44	2	$this->getMapper()->persist($serieToken);
45
46	2	return $serieToken;
47		}
48
49		/**
50		* @param SerieTokenInterface $serieToken
51		* @return SerieTokenInterface\|null
52		*/
53	6	public function getNextInSerie(SerieTokenInterface $serieToken)
54		{
55	6	$matchingSerieToken = $this->getMapper()->find($serieToken->getUserId(), $serieToken->getSerie());
56	6	if (!$matchingSerieToken) {
57	1	return null;
58	5	} elseif ($matchingSerieToken->getValidUntil() && $matchingSerieToken->getValidUntil() < new \DateTime) {
59	1	return null;
60	4	} elseif (!$matchingSerieToken->getExpiresAt() \|\| $matchingSerieToken->getExpiresAt() < new \DateTime) {
61	1	return null;
62	3	} elseif ($matchingSerieToken->getToken() !== $serieToken->getToken()) {
63	1	$this->removeSerie($serieToken->getUserId(), $serieToken->getSerie());
64	1	return null;
65		}
66
67	2	if ($this->moduleOptions->isTokenRefreshedAfterLogin()) {
68		// Generate new token in the serie
69	1	$matchingSerieToken->setToken($this->generateRandom());
70		}
71
72	2	$matchingSerieToken->setExpiresAt($this->getNewExpireDate());
73
74	2	$this->getMapper()->persist($matchingSerieToken);
75
76	2	return $matchingSerieToken;
77		}
78
79		/**
80		* @return \DateTime
81		*/
82	4	protected function getNewExpireDate()
83		{
84	4	return new \DateTime('+1 year');
85		}
86
87		/**
88		* @param int $userId
89		* @param string $serieId
90		*/
91	2	public function removeSerie($userId, $serieId)
92		{
93	2	$serieToken = $this->getMapper()->find($userId, $serieId);
94	2	if ($serieToken) {
95	2	$this->getMapper()->remove($serieToken);
96		}
97	2	}
98
99		public function removeAllSeries(int $userId)
100		{
101		$serieTokens = $this->getMapper()->findAllByUser($userId);
102		foreach ($serieTokens as $serieToken) {
103		$this->getMapper()->remove($serieToken);
104		}
105		}
106
107		/**
108		* @note Should NOT contain semicolons.
109		*
110		* @return string
111		*/
112	3	private function generateRandom()
113		{
114	3	return Rand::getString(10);
115		}
116
117		/**
118		* @return SerieTokenMapper
119		*/
120	9	public function getMapper()
121		{
122	9	return $this->mapper;
123		}
124
125		/**
126		* @param SerieTokenMapper $mapper
127		* @return $this
128		*/
129	9	public function setMapper($mapper)
130		{
131	9	$this->mapper = $mapper;
		0 ignored issues – show Documentation Bug introduced 2016-01-29 11:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$mapper` of type `object<JwPersistentUser\Service\SerieTokenMapper>` is incompatible with the declared type `object<JwPersistentUser\...ieTokenMapperInterface>` of property `$mapper`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
132	9	return $this;
133		}
134
135		/**
136		* @return ModuleOptions
137		*/
138	2	public function getModuleOptions()
139		{
140	2	return $this->moduleOptions;
141		}
142
143		/**
144		* @param ModuleOptions $moduleOptions
145		* @return $this
146		*/
147	9	public function setModuleOptions($moduleOptions)
148		{
149	9	$this->moduleOptions = $moduleOptions;
150	9	return $this;
151		}
152
153		/**
154		* @return UserValidityInterface
155		*/
156	2	public function getUserValidityInterface()
157		{
158	2	return $this->userValidityInterface;
159		}
160
161		/**
162		* @param UserValidityInterface $userValidityInterface
163		* @return $this
164		*/
165	9	public function setUserValidityInterface($userValidityInterface)
166		{
167	9	$this->userValidityInterface = $userValidityInterface;
168	9	return $this;
169		}
170		}
171

JouwWeb / JwPersistentUser

Issues (40)

Security Analysis no request data

src/JwPersistentUser/Service/RememberMeService.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like