Issues in CookieService.php (master) - Issues in master - JouwWeb/JwPersistentUser - Measure and Improve Code Quality continuously with Scrutinizer

Issues (40)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/JwPersistentUser/Service/CookieService.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JwPersistentUser\Service;

use JwPersistentUser\Model\ModuleOptions;
use JwPersistentUser\Model\SerieTokenInterface;

use Zend\Http\Request;
use Zend\Http\Response;
use Zend\Http\Header\SetCookie;

class CookieService
{
    const COOKIE_NAME = 'JwPersistentUser';

    /**
     * @var ModuleOptions
     */
    protected $moduleOptions;

    /**
     * @param Request $request
     * @param Response|null $response
     * @return SerieTokenInterface|null
     */
    public function read(Request $request, Response $response = null)
    {
        $cookie = $request->getCookie();
        if (!isset($cookie[self::COOKIE_NAME])) {
            return null;
        }

        $parts = explode(':', $cookie[self::COOKIE_NAME]);
        if (!is_array($parts) || count($parts) !== 3) {
            if ($response) {
                $this->writeNull($response);
            }
            return null;
        }

        $serieTokenEntityClass = $this->getModuleOptions()->getSerieTokenEntityClass();
        $serieToken = new $serieTokenEntityClass;
        $serieToken->setUserId($parts[0]);
        $serieToken->setSerie($parts[1]);
        $serieToken->setToken($parts[2]);

        return $serieToken;
    }

    /**
     * @return SetCookie
     */
    public function writeNull(Response $response)
    {
        $this->setCookie($response, $this->appendWithDefaultParameters(new SetCookie(
            self::COOKIE_NAME,
            null,
            time()  - 3600,
            '/'
        )));
    }

    /**
     * @param SerieTokenInterface $serieToken
     * @return SetCookie
     */
    public function writeSerie(Response $response, SerieTokenInterface $serieToken)
    {
        $serieRepresentation =
            $serieToken->getUserId() .
            ':' . $serieToken->getSerie() .
            ':' . $serieToken->getToken();

        $this->setCookie($response, $this->appendWithDefaultParameters(new SetCookie(
            self::COOKIE_NAME,
            $serieRepresentation,
            $serieToken->getExpiresAt()->getTimestamp(),
            $this->getModuleOptions()->getCookiePath(),
            $this->getModuleOptions()->getCookieDomain(),
            $this->getModuleOptions()->getCookieSecure(),

            $this->getModuleOptions()->getCookieHttpOnly(),

            $this->getModuleOptions()->getCookieMaxAge(),
            $this->getModuleOptions()->getCookieVersion(),
            $this->getModuleOptions()->getCookieSameSite()
        )));
    }

    private function appendWithDefaultParameters(SetCookie $header)
    {
        $header->setHttponly(true);
        return $header;
    }

    /**
     * @param Response $response
     * @param SetCookie $cookie
     */
    protected static function setCookie(Response $response, SetCookie $cookie)
    {
        $response->getHeaders()->addHeader($cookie);
    }

    /**
     * @return ModuleOptions
     */
    public function getModuleOptions()
    {
        return $this->moduleOptions;
    }

    /**
     * @param ModuleOptions $moduleOptions
     * @return $this
     */
    public function setModuleOptions($moduleOptions)
    {
        $this->moduleOptions = $moduleOptions;
        return $this;
    }
}


1		<?php
2
3		namespace JwPersistentUser\Service;
4
5		use JwPersistentUser\Model\ModuleOptions;
6		use JwPersistentUser\Model\SerieTokenInterface;
7
8		use Zend\Http\Request;
9		use Zend\Http\Response;
10		use Zend\Http\Header\SetCookie;
11
12		class CookieService
13		{
14		const COOKIE_NAME = 'JwPersistentUser';
15
16		/**
17		* @var ModuleOptions
18		*/
19		protected $moduleOptions;
20
21		/**
22		* @param Request $request
23		* @param Response\|null $response
24		* @return SerieTokenInterface\|null
25		*/
26	3	public function read(Request $request, Response $response = null)
27		{
28	3	$cookie = $request->getCookie();
29	3	if (!isset($cookie[self::COOKIE_NAME])) {
30	1	return null;
31		}
32
33	2	$parts = explode(':', $cookie[self::COOKIE_NAME]);
34	2	if (!is_array($parts) \|\| count($parts) !== 3) {
35	1	if ($response) {
36	1	$this->writeNull($response);
37		}
38	1	return null;
39		}
40
41	1	$serieTokenEntityClass = $this->getModuleOptions()->getSerieTokenEntityClass();
42	1	$serieToken = new $serieTokenEntityClass;
43	1	$serieToken->setUserId($parts[0]);
44	1	$serieToken->setSerie($parts[1]);
45	1	$serieToken->setToken($parts[2]);
46
47	1	return $serieToken;
48		}
49
50		/**
51		* @return SetCookie
52		*/
53	2	public function writeNull(Response $response)
54		{
55	2	$this->setCookie($response, $this->appendWithDefaultParameters(new SetCookie(
56	2	self::COOKIE_NAME,
57	2	null,
58	2	time() - 3600,
59	2	'/'
60		)));
61	2	}
62
63		/**
64		* @param SerieTokenInterface $serieToken
65		* @return SetCookie
66		*/
67	2	public function writeSerie(Response $response, SerieTokenInterface $serieToken)
68		{
69		$serieRepresentation =
70	2	$serieToken->getUserId() .
71	2	':' . $serieToken->getSerie() .
72	2	':' . $serieToken->getToken();
73
74	2	$this->setCookie($response, $this->appendWithDefaultParameters(new SetCookie(
75	2	self::COOKIE_NAME,
76	2	$serieRepresentation,
77	2	$serieToken->getExpiresAt()->getTimestamp(),
78	2	$this->getModuleOptions()->getCookiePath(),
79	2	$this->getModuleOptions()->getCookieDomain(),
80	2	$this->getModuleOptions()->getCookieSecure(),
		0 ignored issues – show Bug introduced 2020-03-04 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->getModuleOptions()->getCookieSecure()` targeting `JwPersistentUser\Model\M...ions::getCookieSecure()` can also be of type `null`; however, `Zend\Http\Header\SetCookie::__construct()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
81	2	$this->getModuleOptions()->getCookieHttpOnly(),
		0 ignored issues – show Bug introduced 2020-03-04 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->getModuleOptions()->getCookieHttpOnly()` targeting `JwPersistentUser\Model\M...ns::getCookieHttpOnly()` can also be of type `null`; however, `Zend\Http\Header\SetCookie::__construct()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
82	2	$this->getModuleOptions()->getCookieMaxAge(),
83	2	$this->getModuleOptions()->getCookieVersion(),
84	2	$this->getModuleOptions()->getCookieSameSite()
85		)));
86	2	}
87
88	4	private function appendWithDefaultParameters(SetCookie $header)
89		{
90	4	$header->setHttponly(true);
91	4	return $header;
92		}
93
94		/**
95		* @param Response $response
96		* @param SetCookie $cookie
97		*/
98	4	protected static function setCookie(Response $response, SetCookie $cookie)
99		{
100	4	$response->getHeaders()->addHeader($cookie);
101	4	}
102
103		/**
104		* @return ModuleOptions
105		*/
106	3	public function getModuleOptions()
107		{
108	3	return $this->moduleOptions;
109		}
110
111		/**
112		* @param ModuleOptions $moduleOptions
113		* @return $this
114		*/
115	6	public function setModuleOptions($moduleOptions)
116		{
117	6	$this->moduleOptions = $moduleOptions;
118	6	return $this;
119		}
120		}
121

JouwWeb / JwPersistentUser

Issues (40)

Security Analysis no request data

src/JwPersistentUser/Service/CookieService.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like