ImmutableNumber::modulo() - Code Metrics - Inspection of "Added flag to manually control use of extensions d..." - JordanRL/Fermat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 8be191...84ccba )

by Jordan

created 2017-01-14 22:27 UTC

ImmutableNumber::modulo() A

↳ Parent: ImmutableNumber

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php

namespace Samsara\Fermat\Values;

use Samsara\Fermat\Numbers;
use Samsara\Fermat\Types\Number;
use Samsara\Fermat\Types\Base\DecimalInterface;
use Samsara\Fermat\Types\Base\NumberInterface;

class ImmutableNumber extends Number implements NumberInterface, DecimalInterface
{

    public function modulo($mod)
    {
        $oldBase = $this->convertForModification();

        return (new ImmutableNumber(bcmod($this->getValue(), $mod), $this->getPrecision(), $this->getBase()))->convertFromModification($oldBase);
    }

    public function continuousModulo($mod)

    {

        $mod = Numbers::makeOrDont(Numbers::IMMUTABLE, $mod, 100);

        $multiple = $this->divide($mod)->floor();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $remainder = $this->subtract($mod->multiply($multiple));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $remainder;

    }

    /**
     * @param $value
     *
     * @return ImmutableNumber
     */
    protected function setValue($value)
    {
        return new ImmutableNumber($value, $this->getPrecision(), $this->getBase());
    }

}

1			<?php
2
3			namespace Samsara\Fermat\Values;
4
5			use Samsara\Fermat\Numbers;
6			use Samsara\Fermat\Types\Number;
7			use Samsara\Fermat\Types\Base\DecimalInterface;
8			use Samsara\Fermat\Types\Base\NumberInterface;
9
10			class ImmutableNumber extends Number implements NumberInterface, DecimalInterface
11			{
12
13	1		public function modulo($mod)
14			{
15	1		$oldBase = $this->convertForModification();
16
17	1		return (new ImmutableNumber(bcmod($this->getValue(), $mod), $this->getPrecision(), $this->getBase()))->convertFromModification($oldBase);
18			}
19
20	3	View Code Duplication	public function continuousModulo($mod)
			0 ignored issues – show Duplication introduced 2017-01-09 18:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21			{
22
23	3		$mod = Numbers::makeOrDont(Numbers::IMMUTABLE, $mod, 100);
24
25	3		$multiple = $this->divide($mod)->floor();
			0 ignored issues – show Bug introduced 2017-01-14 10:27 UTC by Report Bug Copy Issue Report The method `floor` does only exist in `Samsara\Fermat\Types\Base\DecimalInterface`, but not in `Samsara\Fermat\Types\Base\NumberInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26
27	3		$remainder = $this->subtract($mod->multiply($multiple));
			0 ignored issues – show Bug introduced 2017-01-12 21:08 UTC by Report Bug Copy Issue Report The method `multiply` does only exist in `Samsara\Fermat\Types\Base\NumberInterface`, but not in `Samsara\Fermat\Types\Bas...\Base\FractionInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28
29	3		return $remainder;
30
31			}
32
33			/**
34			* @param $value
35			*
36			* @return ImmutableNumber
37			*/
38	18		protected function setValue($value)
39			{
40	18		return new ImmutableNumber($value, $this->getPrecision(), $this->getBase());
41			}
42
43			}

JordanRL / Fermat

Push — dev ( 8be191...84ccba )

ImmutableNumber::modulo() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like