Samsara\Fermat\Values\MutableDecimal

Complexity

Total Complexity

7

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

71.43%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setValue()	0	24	5
A	continuousModulo()	0	11	1
A	isComplex()	0	3	1

<?php


namespace Samsara\Fermat\Values;


use Samsara\Fermat\Types\Decimal;

use Samsara\Fermat\Numbers;


class MutableDecimal extends Decimal

{


    public function continuousModulo($mod)

    {


        $mod = Numbers::makeOrDont(Numbers::IMMUTABLE, $mod, $this->precision+1);

        $oldNum = Numbers::make(Numbers::IMMUTABLE, $this->getValue(), $this->precision+1);


        $multiple = $oldNum->divide($mod)->floor();

The method floor() does not exist on Samsara\Fermat\Types\Base\Interfaces\Numbers\NumberInterface. It seems like you code against a sub-type of Samsara\Fermat\Types\Base\Interfaces\Numbers\NumberInterface such as Samsara\Fermat\Types\Base\Interfaces\Numbers\DecimalInterface or Samsara\Fermat\Types\Decimal.

The method floor() does not exist on Samsara\Fermat\Types\Base\Interfaces\Numbers\FractionInterface.

The method floor() does not exist on Samsara\Fermat\Values\ImmutableComplexNumber.

The method floor() does not exist on Samsara\Fermat\Values\MutableFraction.

The method floor() does not exist on Samsara\Fermat\Values\ImmutableFraction.

        $remainder = $oldNum->subtract($mod->multiply($multiple));


        return Numbers::make(Numbers::MUTABLE, $remainder->truncate($this->precision)->getValue());

The method truncate() does not exist on Samsara\Fermat\Types\Base\Interfaces\Numbers\NumberInterface. It seems like you code against a sub-type of Samsara\Fermat\Types\Base\Interfaces\Numbers\NumberInterface such as Samsara\Fermat\Types\Base\Interfaces\Numbers\DecimalInterface or Samsara\Fermat\Types\Decimal.

The expression return Samsara\Fermat\Numbers::make(Samsara\Fermat\Numbers::MUTABLE, $remainder->truncate($this->precision)->getValue()) also could return the type Samsara\Fermat\Types\Base\Interfaces\Numbers\FractionInterface|Samsara\Fermat\Values\ImmutableFraction|Samsara\Fermat\Values\MutableFraction which is incompatible with the return type mandated by Samsara\Fermat\Types\Base\Interfaces\Numbers\DecimalInterface::continuousModulo() of Samsara\Fermat\Types\Base\Interfaces\Numbers\DecimalInterface.

The method truncate() does not exist on Samsara\Fermat\Values\ImmutableComplexNumber.

The method truncate() does not exist on Samsara\Fermat\Types\Base\Interfaces\Numbers\FractionInterface.

The method truncate() does not exist on Samsara\Fermat\Values\MutableFraction.

The method truncate() does not exist on Samsara\Fermat\Values\ImmutableFraction.

    }


    /**

     * @param string $value

     *

     * @return MutableDecimal

     */

    protected function setValue(string $value, int $precision = null, int $base = 10)

    {

        $imaginary = false;


        if (strpos($value, 'i') !== false) {

            $value = str_replace('i', '', $value);

            $imaginary = true;

        }


        if ($base != 10) {

            $value = $this->convertValue($value, 10, $base);

        }


        if ($imaginary) {

            $value .= 'i';

        }


        if (is_null($precision)) {

            $precision = $this->getPrecision();

The assignment to $precision is dead and can be removed.

        }


        $this->value = $this->translateValue($value);

It seems like $value can also be of type false; however, parameter $value of Samsara\Fermat\Types\Decimal::translateValue() does only seem to accept string, maybe add an additional type check?

        return $this;

    }


    /**

     * @return bool

     */

    public function isComplex(): bool

    {

        return false;

    }


}