Jleagle\BattleNet\Request\AbstractBattleNet

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
B	_get()	0	25	5

<?php
namespace Jleagle\BattleNet\Request;

use Jleagle\BattleNet\Enums\ServerLocations;
use Jleagle\BattleNet\Exceptions\BattleNetException;
use Jleagle\CurlWrapper\Curl;
use Jleagle\CurlWrapper\Exceptions\CurlException;

abstract class AbstractBattleNet
{
  use BattleNetTrait;

  protected $_apiKey;
  protected $_responseLocale;

  /**
   * @param string $apiKey
   * @param string $serverLocation
   * @param string $responseLocale
   */
  public function __construct(
    $apiKey, $serverLocation = ServerLocations::US, $responseLocale = null
  )
  {
    $this->_apiKey = $apiKey;
    $this->_serverLocation = $serverLocation;
    $this->_responseLocale = $responseLocale;
  }

  /**
   * @param string $path
   * @param array  $data
   *
   * @return array
   * @throws BattleNetException
   */
  protected function _get($path, $data = [])
  {
    if($this->_responseLocale)

The expression $this->_responseLocale of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

    {
      $data['locale'] = $this->_responseLocale;
    }

    if($this->_jsonP)
    {
      $data['jsonp'] = $this->_jsonP;
    }

    $data['apikey'] = $this->_apiKey;

    try
    {
      return Curl::get($this->_makeApiUrl($path), $data)->run()->getJson();
    }
    catch(CurlException $e)
    {
      $json = $e->getResponse()->getJson();
      $message = isset($json['reason']) ? $json['reason'] : $e->getMessage();
      throw new BattleNetException($message);
    }
  }
}