Issues in AverageTimeSpentColumnAnalytic.php (master) - Issues in master - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3948)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Analytic/AverageTimeSpentColumnAnalytic.php (4 issues)

Labels

Severity

Informational 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\Analytic;

use Jitamin\Foundation\Base;
use Jitamin\Model\TaskModel;

/**
 * Average Time Spent by Column.
 */
class AverageTimeSpentColumnAnalytic extends Base
{
    /**
     * Build report.
     *
     * @param int $project_id Project id
     *
     * @return array
     */
    public function build($project_id)
    {
        $stats = $this->initialize($project_id);

        $this->processTasks($stats, $project_id);
        $this->calculateAverage($stats);

        return $stats;
    }

    /**
     * Initialize default values for each column.
     *
     * @param int $project_id
     *
     * @return array
     */
    private function initialize($project_id)
    {
        $stats = [];
        $columns = $this->columnModel->getList($project_id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        foreach ($columns as $column_id => $column_title) {
            $stats[$column_id] = [
                'count'      => 0,
                'time_spent' => 0,
                'average'    => 0,
                'title'      => $column_title,
            ];
        }

        return $stats;
    }

    /**
     * Calculate time spent for each tasks for each columns.
     *
     * @param array $stats
     * @param int   $project_id
     */
    private function processTasks(array &$stats, $project_id)
    {
        $tasks = $this->getTasks($project_id);

        foreach ($tasks as &$task) {
            foreach ($this->getTaskTimeByColumns($task) as $column_id => $time_spent) {
                if (isset($stats[$column_id])) {
                    $stats[$column_id]['count']++;
                    $stats[$column_id]['time_spent'] += $time_spent;
                }
            }
        }
    }

    /**
     * Calculate averages.
     *
     * @param array $stats
     */
    private function calculateAverage(array &$stats)
    {
        foreach ($stats as &$column) {
            $this->calculateColumnAverage($column);
        }
    }

    /**
     * Calculate column average.
     *
     * @param array $column
     */
    private function calculateColumnAverage(array &$column)
    {
        if ($column['count'] > 0) {
            $column['average'] = (int) ($column['time_spent'] / $column['count']);
        }
    }

    /**
     * Get time spent for each column for a given task.
     *
     * @param array $task
     *
     * @return array
     */
    private function getTaskTimeByColumns(array &$task)
    {
        $columns = $this->transitionModel->getTimeSpentByTask($task['id']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (!isset($columns[$task['column_id']])) {
            $columns[$task['column_id']] = 0;
        }

        $columns[$task['column_id']] += $this->getTaskTimeSpentInCurrentColumn($task);

        return $columns;
    }

    /**
     * Calculate time spent of a task in the current column.
     *
     * @param array $task
     *
     * @return int
     */
    private function getTaskTimeSpentInCurrentColumn(array &$task)
    {
        $end = $task['date_completed'] ?: time();

        return $end - $task['date_moved'];
    }

    /**
     * Fetch the last 1000 tasks.
     *
     * @param int $project_id
     *
     * @return array
     */
    private function getTasks($project_id)

    {
        return $this->db
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->table(TaskModel::TABLE)
            ->columns('id', 'date_completed', 'date_moved', 'column_id')
            ->eq('project_id', $project_id)
            ->desc('id')
            ->limit(1000)
            ->findAll();
    }
}


1		<?php
2
3		/*
4		* This file is part of Jitamin.
5		*
6		* Copyright (C) Jitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Jitamin\Analytic;
13
14		use Jitamin\Foundation\Base;
15		use Jitamin\Model\TaskModel;
16
17		/**
18		* Average Time Spent by Column.
19		*/
20		class AverageTimeSpentColumnAnalytic extends Base
21		{
22		/**
23		* Build report.
24		*
25		* @param int $project_id Project id
26		*
27		* @return array
28		*/
29		public function build($project_id)
30		{
31		$stats = $this->initialize($project_id);
32
33		$this->processTasks($stats, $project_id);
34		$this->calculateAverage($stats);
35
36		return $stats;
37		}
38
39		/**
40		* Initialize default values for each column.
41		*
42		* @param int $project_id
43		*
44		* @return array
45		*/
46		private function initialize($project_id)
47		{
48		$stats = [];
49		$columns = $this->columnModel->getList($project_id);
		0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `columnModel` does not exist on `object<Jitamin\Analytic\...imeSpentColumnAnalytic>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50
51		foreach ($columns as $column_id => $column_title) {
52		$stats[$column_id] = [
53		'count' => 0,
54		'time_spent' => 0,
55		'average' => 0,
56		'title' => $column_title,
57		];
58		}
59
60		return $stats;
61		}
62
63		/**
64		* Calculate time spent for each tasks for each columns.
65		*
66		* @param array $stats
67		* @param int $project_id
68		*/
69		private function processTasks(array &$stats, $project_id)
70		{
71		$tasks = $this->getTasks($project_id);
72
73		foreach ($tasks as &$task) {
74		foreach ($this->getTaskTimeByColumns($task) as $column_id => $time_spent) {
75		if (isset($stats[$column_id])) {
76		$stats[$column_id]['count']++;
77		$stats[$column_id]['time_spent'] += $time_spent;
78		}
79		}
80		}
81		}
82
83		/**
84		* Calculate averages.
85		*
86		* @param array $stats
87		*/
88		private function calculateAverage(array &$stats)
89		{
90		foreach ($stats as &$column) {
91		$this->calculateColumnAverage($column);
92		}
93		}
94
95		/**
96		* Calculate column average.
97		*
98		* @param array $column
99		*/
100		private function calculateColumnAverage(array &$column)
101		{
102		if ($column['count'] > 0) {
103		$column['average'] = (int) ($column['time_spent'] / $column['count']);
104		}
105		}
106
107		/**
108		* Get time spent for each column for a given task.
109		*
110		* @param array $task
111		*
112		* @return array
113		*/
114		private function getTaskTimeByColumns(array &$task)
115		{
116		$columns = $this->transitionModel->getTimeSpentByTask($task['id']);
		0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `transitionModel` does not exist on `object<Jitamin\Analytic\...imeSpentColumnAnalytic>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
117
118		if (!isset($columns[$task['column_id']])) {
119		$columns[$task['column_id']] = 0;
120		}
121
122		$columns[$task['column_id']] += $this->getTaskTimeSpentInCurrentColumn($task);
123
124		return $columns;
125		}
126
127		/**
128		* Calculate time spent of a task in the current column.
129		*
130		* @param array $task
131		*
132		* @return int
133		*/
134		private function getTaskTimeSpentInCurrentColumn(array &$task)
135		{
136		$end = $task['date_completed'] ?: time();
137
138		return $end - $task['date_moved'];
139		}
140
141		/**
142		* Fetch the last 1000 tasks.
143		*
144		* @param int $project_id
145		*
146		* @return array
147		*/
148	View Code Duplication	private function getTasks($project_id)
		0 ignored issues – show Duplication introduced 2017-11-03 05:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
149		{
150		return $this->db
		0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `db` does not exist on `object<Jitamin\Analytic\...imeSpentColumnAnalytic>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
151		->table(TaskModel::TABLE)
152		->columns('id', 'date_completed', 'date_moved', 'column_id')
153		->eq('project_id', $project_id)
154		->desc('id')
155		->limit(1000)
156		->findAll();
157		}
158		}
159

Jitamin / jitamin

Issues (3948)

Security Analysis not enabled

Analytic/AverageTimeSpentColumnAnalytic.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like