Issues in DateHelper.php (master) - Issues in master - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3948)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Helpers/DateHelper.php (3 issues)

Labels

Documentation 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\Helper;

use DateTime;
use Jitamin\Foundation\Base;

/**
 * DateTime helpers.
 */
class DateHelper extends Base
{
    /**
     * Get formatted time.
     *
     * @param int $value
     *
     * @return string
     */
    public function time($value)
    {
        return date($this->settingModel->get('application_time_format', 'H:i'), $value);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get formatted date.
     *
     * @param int $value
     *
     * @return string
     */
    public function date($value)
    {
        if (empty($value)) {
            return '';
        }

        if (!ctype_digit($value)) {
            $value = strtotime($value);
        }

        return date($this->settingModel->get('application_date_format', 'm/d/Y'), $value);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get formatted  datetime.
     *
     * @param int $value
     *
     * @return string
     */
    public function datetime($value)
    {
        return date($this->settingModel->get('application_datetime_format', 'm/d/Y H:i'), $value);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get duration in seconds into human format.
     *
     * @param int $seconds
     *
     * @return string
     */
    public function duration($seconds)
    {
        if ($seconds == 0) {
            return 0;
        }

        $dtF = new DateTime('@0');
        $dtT = new DateTime("@$seconds");

        return $dtF->diff($dtT)->format('%a days, %h hours, %i minutes and %s seconds');
    }

    /**
     * Get the age of an item in quasi human readable format.
     * It's in this format: <1h , NNh, NNd.
     *
     * @param int $timestamp Unix timestamp of the artifact for which age will be calculated
     * @param int $now       Compare with this timestamp (Default value is the current unix timestamp)
     *
     * @return string
     */
    public function age($timestamp, $now = null)
    {
        if ($now === null) {
            $now = time();
        }

        $diff = $now - $timestamp;

        if ($diff < 900) {
            return t('<15m');
        }
        if ($diff < 1200) {
            return t('<30m');
        } elseif ($diff < 3600) {
            return t('<1h');
        } elseif ($diff < 86400) {
            return '~'.t('%dh', $diff / 3600);
        }

        return t('%dd', ($now - $timestamp) / 86400);
    }

    /**
     * Get all hours for day.
     *
     * @return array
     */
    public function getDayHours()
    {
        $values = [];

        foreach (range(0, 23) as $hour) {
            foreach ([0, 30] as $minute) {
                $time = sprintf('%02d:%02d', $hour, $minute);
                $values[$time] = $time;
            }
        }

        return $values;
    }

    /**
     * Get all days of a week.
     *
     * @return array
     */
    public function getWeekDays()
    {
        $values = [];

        foreach (range(1, 7) as $day) {
            $values[$day] = $this->getWeekDay($day);
        }

        return $values;
    }

    /**
     * Get the localized day name from the day number.
     *
     * @param int $day Day number
     *
     * @return string
     */
    public function getWeekDay($day)
    {
        return date('l', strtotime('next Monday +'.($day - 1).' days'));
    }
}


1			<?php
2
3			/*
4			* This file is part of Jitamin.
5			*
6			* Copyright (C) Jitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Jitamin\Helper;
13
14			use DateTime;
15			use Jitamin\Foundation\Base;
16
17			/**
18			* DateTime helpers.
19			*/
20			class DateHelper extends Base
21			{
22			/**
23			* Get formatted time.
24			*
25			* @param int $value
26			*
27			* @return string
28			*/
29			public function time($value)
30			{
31			return date($this->settingModel->get('application_time_format', 'H:i'), $value);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `settingModel` does not exist on `object<Jitamin\Helper\DateHelper>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
32			}
33
34			/**
35			* Get formatted date.
36			*
37			* @param int $value
38			*
39			* @return string
40			*/
41			public function date($value)
42			{
43			if (empty($value)) {
44			return '';
45			}
46
47			if (!ctype_digit($value)) {
48			$value = strtotime($value);
49			}
50
51			return date($this->settingModel->get('application_date_format', 'm/d/Y'), $value);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `settingModel` does not exist on `object<Jitamin\Helper\DateHelper>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52			}
53
54			/**
55			* Get formatted datetime.
56			*
57			* @param int $value
58			*
59			* @return string
60			*/
61			public function datetime($value)
62			{
63			return date($this->settingModel->get('application_datetime_format', 'm/d/Y H:i'), $value);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `settingModel` does not exist on `object<Jitamin\Helper\DateHelper>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
64			}
65
66			/**
67			* Get duration in seconds into human format.
68			*
69			* @param int $seconds
70			*
71			* @return string
72			*/
73			public function duration($seconds)
74			{
75			if ($seconds == 0) {
76			return 0;
77			}
78
79			$dtF = new DateTime('@0');
80			$dtT = new DateTime("@$seconds");
81
82			return $dtF->diff($dtT)->format('%a days, %h hours, %i minutes and %s seconds');
83			}
84
85			/**
86			* Get the age of an item in quasi human readable format.
87			* It's in this format: <1h , NNh, NNd.
88			*
89			* @param int $timestamp Unix timestamp of the artifact for which age will be calculated
90			* @param int $now Compare with this timestamp (Default value is the current unix timestamp)
91			*
92			* @return string
93			*/
94			public function age($timestamp, $now = null)
95			{
96			if ($now === null) {
97			$now = time();
98			}
99
100			$diff = $now - $timestamp;
101
102			if ($diff < 900) {
103			return t('<15m');
104			}
105			if ($diff < 1200) {
106			return t('<30m');
107			} elseif ($diff < 3600) {
108			return t('<1h');
109			} elseif ($diff < 86400) {
110			return '~'.t('%dh', $diff / 3600);
111			}
112
113			return t('%dd', ($now - $timestamp) / 86400);
114			}
115
116			/**
117			* Get all hours for day.
118			*
119			* @return array
120			*/
121			public function getDayHours()
122			{
123			$values = [];
124
125			foreach (range(0, 23) as $hour) {
126			foreach ([0, 30] as $minute) {
127			$time = sprintf('%02d:%02d', $hour, $minute);
128			$values[$time] = $time;
129			}
130			}
131
132			return $values;
133			}
134
135			/**
136			* Get all days of a week.
137			*
138			* @return array
139			*/
140			public function getWeekDays()
141			{
142			$values = [];
143
144			foreach (range(1, 7) as $day) {
145			$values[$day] = $this->getWeekDay($day);
146			}
147
148			return $values;
149			}
150
151			/**
152			* Get the localized day name from the day number.
153			*
154			* @param int $day Day number
155			*
156			* @return string
157			*/
158			public function getWeekDay($day)
159			{
160			return date('l', strtotime('next Monday +'.($day - 1).' days'));
161			}
162			}
163

Jitamin / jitamin

Issues (3948)

Security Analysis not enabled

app/Helpers/DateHelper.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like