Issues in MemcachedCache.php (master) - Issues in master - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3948)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Foundation/Cache/MemcachedCache.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\Foundation\Cache;

use Carbon\Carbon;

/**
 * Memcached Cache Driver.
 */
class MemcachedCache extends BaseCache
{
    /**
     * The Memcached instance.
     *
     * @var \Memcached
     */
    protected $memcached;

    /**
     * A string that should be prepended to keys.
     *
     * @var string
     */
    protected $prefix;

    /**
     * Container.
     *
     * @var array
     */
    private $storage = [];


    /**
     * Create a new Memcached store.
     *
     * @param \Memcached $memcached
     * @param string     $prefix
     *
     * @return void

     */
    public function __construct($memcached, $prefix = '')
    {
        $this->setPrefix($prefix);
        $this->memcached = $memcached;
    }

    /**
     * Store an item in the cache.
     *
     * @param string $key
     * @param mixed  $value
     * @param int    $minutes
     */
    public function set($key, $value, $minutes = 0)
    {
        $this->memcached->set($this->prefix.$key, $value, $this->toTimestamp($minutes));
    }

    /**
     * Retrieve an item from the cache by key.
     *
     * @param string $key
     *
     * @return mixed Null when not found, cached value otherwise
     */
    public function get($key)
    {
        $value = $this->memcached->get($this->prefix.$key);
        if ($this->memcached->getResultCode() == 0) {
            return $value;
        }
    }

    /**
     * Clear all cache.
     */
    public function flush()
    {
        $this->memcached->flush();
    }

    /**
     * Remove cached value.
     *
     * @param string $key
     */
    public function remove($key)
    {
        return $this->memcached->delete($this->prefix.$key);
    }

    /**
     * Get the UNIX timestamp for the given number of minutes.
     *
     * @parma  int  $minutes
     *
     * @return int
     */
    protected function toTimestamp($minutes)
    {
        return $minutes > 0 ? Carbon::now()->addMinutes($minutes)->getTimestamp() : 0;
    }

    /**
     * Get the cache key prefix.
     *
     * @return string
     */
    public function getPrefix()
    {
        return $this->prefix;
    }

    /**
     * Set the cache key prefix.
     *
     * @param string $prefix
     *
     * @return void
     */
    public function setPrefix($prefix)
    {
        $this->prefix = !empty($prefix) ? $prefix.':' : '';
    }
}


1			<?php
2
3			/*
4			* This file is part of Jitamin.
5			*
6			* Copyright (C) Jitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Jitamin\Foundation\Cache;
13
14			use Carbon\Carbon;
15
16			/**
17			* Memcached Cache Driver.
18			*/
19			class MemcachedCache extends BaseCache
20			{
21			/**
22			* The Memcached instance.
23			*
24			* @var \Memcached
25			*/
26			protected $memcached;
27
28			/**
29			* A string that should be prepended to keys.
30			*
31			* @var string
32			*/
33			protected $prefix;
34
35			/**
36			* Container.
37			*
38			* @var array
39			*/
40			private $storage = [];
			0 ignored issues – show Unused Code introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$storage` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
41
42			/**
43			* Create a new Memcached store.
44			*
45			* @param \Memcached $memcached
46			* @param string $prefix
47			*
48			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
49			*/
50			public function __construct($memcached, $prefix = '')
51			{
52			$this->setPrefix($prefix);
53			$this->memcached = $memcached;
54			}
55
56			/**
57			* Store an item in the cache.
58			*
59			* @param string $key
60			* @param mixed $value
61			* @param int $minutes
62			*/
63			public function set($key, $value, $minutes = 0)
64			{
65			$this->memcached->set($this->prefix.$key, $value, $this->toTimestamp($minutes));
66			}
67
68			/**
69			* Retrieve an item from the cache by key.
70			*
71			* @param string $key
72			*
73			* @return mixed Null when not found, cached value otherwise
74			*/
75			public function get($key)
76			{
77			$value = $this->memcached->get($this->prefix.$key);
78			if ($this->memcached->getResultCode() == 0) {
79			return $value;
80			}
81			}
82
83			/**
84			* Clear all cache.
85			*/
86			public function flush()
87			{
88			$this->memcached->flush();
89			}
90
91			/**
92			* Remove cached value.
93			*
94			* @param string $key
95			*/
96			public function remove($key)
97			{
98			return $this->memcached->delete($this->prefix.$key);
99			}
100
101			/**
102			* Get the UNIX timestamp for the given number of minutes.
103			*
104			* @parma int $minutes
105			*
106			* @return int
107			*/
108			protected function toTimestamp($minutes)
109			{
110			return $minutes > 0 ? Carbon::now()->addMinutes($minutes)->getTimestamp() : 0;
111			}
112
113			/**
114			* Get the cache key prefix.
115			*
116			* @return string
117			*/
118			public function getPrefix()
119			{
120			return $this->prefix;
121			}
122
123			/**
124			* Set the cache key prefix.
125			*
126			* @param string $prefix
127			*
128			* @return void
129			*/
130			public function setPrefix($prefix)
131			{
132			$this->prefix = !empty($prefix) ? $prefix.':' : '';
133			}
134			}
135

Jitamin / jitamin

Issues (3948)

Security Analysis not enabled

app/Foundation/Cache/MemcachedCache.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like