WebLink::getTitle() - Code Metrics - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

WebLink::getTitle() A
last analyzed 2017-12-27 06:16 UTC

↳ Parent: WebLink

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	3
nop	0
dl	0
loc	16
rs	9.2
c	0
b	0
f	0

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\ExternalLink;

use Jitamin\Foundation\ExternalLink\ExternalLinkInterface;

/**
 * Web Link.
 */
class WebLink extends BaseLink implements ExternalLinkInterface
{
    /**
     * Get link title.
     *
     * @return string
     */
    public function getTitle()
    {
        $html = $this->httpClient->get($this->url);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (preg_match('/<title>(.*)<\/title>/siU', $html, $matches)) {
            return trim($matches[1]);
        }

        $components = parse_url($this->url);

        if (!empty($components['host']) && !empty($components['path'])) {
            return $components['host'].$components['path'];
        }

        return t('Title not found');
    }
}


1			<?php
2
3			/*
4			* This file is part of Jitamin.
5			*
6			* Copyright (C) Jitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Jitamin\ExternalLink;
13
14			use Jitamin\Foundation\ExternalLink\ExternalLinkInterface;
15
16			/**
17			* Web Link.
18			*/
19			class WebLink extends BaseLink implements ExternalLinkInterface
20			{
21			/**
22			* Get link title.
23			*
24			* @return string
25			*/
26			public function getTitle()
27			{
28			$html = $this->httpClient->get($this->url);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `httpClient` does not exist on `object<Jitamin\ExternalLink\WebLink>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29
30			if (preg_match('/<title>(.*)<\/title>/siU', $html, $matches)) {
31			return trim($matches[1]);
32			}
33
34			$components = parse_url($this->url);
35
36			if (!empty($components['host']) && !empty($components['path'])) {
37			return $components['host'].$components['path'];
38			}
39
40			return t('Title not found');
41			}
42			}
43

Jitamin / jitamin

WebLink::getTitle() A last analyzed 2017-12-27 06:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

WebLink::getTitle() A
last analyzed 2017-12-27 06:16 UTC