NotificationJob - Code Metrics - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

NotificationJob A
last analyzed 2017-12-27 06:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	33
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	withParams()	0	6	1
A	execute()	0	9	2

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\Bus\Job;

use Jitamin\Bus\Event\GenericEvent;

/**
 * Class NotificationJob.
 */
class NotificationJob extends BaseJob
{
    /**
     * Set job parameters.
     *
     * @param GenericEvent $event
     * @param string       $eventName
     *
     * @return $this
     */
    public function withParams(GenericEvent $event, $eventName)
    {
        $this->jobParams = [$event->getAll(), $eventName];

        return $this;
    }

    /**
     * Execute job.
     *
     * @param array  $eventData
     * @param string $eventName
     */
    public function execute(array $eventData, $eventName)
    {
        if (!empty($eventData['mention'])) {
            $this->userNotificationModel->sendUserNotification($eventData['mention'], $eventName, $eventData);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->userNotificationModel->sendNotifications($eventName, $eventData);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->projectNotificationModel->sendNotifications($eventData['task']['project_id'], $eventName, $eventData);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of Jitamin.
5			*
6			* Copyright (C) Jitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Jitamin\Bus\Job;
13
14			use Jitamin\Bus\Event\GenericEvent;
15
16			/**
17			* Class NotificationJob.
18			*/
19			class NotificationJob extends BaseJob
20			{
21			/**
22			* Set job parameters.
23			*
24			* @param GenericEvent $event
25			* @param string $eventName
26			*
27			* @return $this
28			*/
29			public function withParams(GenericEvent $event, $eventName)
30			{
31			$this->jobParams = [$event->getAll(), $eventName];
32
33			return $this;
34			}
35
36			/**
37			* Execute job.
38			*
39			* @param array $eventData
40			* @param string $eventName
41			*/
42			public function execute(array $eventData, $eventName)
43			{
44			if (!empty($eventData['mention'])) {
45			$this->userNotificationModel->sendUserNotification($eventData['mention'], $eventName, $eventData);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `userNotificationModel` does not exist on `object<Jitamin\Bus\Job\NotificationJob>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			} else {
47			$this->userNotificationModel->sendNotifications($eventName, $eventData);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `userNotificationModel` does not exist on `object<Jitamin\Bus\Job\NotificationJob>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48			$this->projectNotificationModel->sendNotifications($eventData['task']['project_id'], $eventName, $eventData);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `projectNotificationModel` does not exist on `object<Jitamin\Bus\Job\NotificationJob>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49			}
50			}
51			}
52

Jitamin / jitamin

NotificationJob A last analyzed 2017-12-27 06:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

NotificationJob A
last analyzed 2017-12-27 06:16 UTC