CommentEventJob - Code Metrics - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

CommentEventJob A
last analyzed 2017-12-27 06:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	40
rs	10
c	0
b	0
f	0
wmc	4
lcom	1
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	withParams()	0	6	1
A	execute()	0	14	3

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\Bus\Job;

use Jitamin\Bus\EventBuilder\CommentEventBuilder;
use Jitamin\Model\CommentModel;

/**
 * Class CommentEventJob.
 */
class CommentEventJob extends BaseJob
{
    /**
     * Set job params.
     *
     * @param int    $commentId
     * @param string $eventName
     *
     * @return $this
     */
    public function withParams($commentId, $eventName)
    {
        $this->jobParams = [$commentId, $eventName];

        return $this;
    }

    /**
     * Execute job.
     *
     * @param int    $commentId
     * @param string $eventName
     *
     * @return $this
     */
    public function execute($commentId, $eventName)
    {
        $event = CommentEventBuilder::getInstance($this->container)
            ->withCommentId($commentId)
            ->buildEvent();

        if ($event !== null) {
            $this->dispatcher->dispatch($eventName, $event);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            if ($eventName === CommentModel::EVENT_CREATE) {
                $this->userMentionModel->fireEvents($event['comment']['comment'], CommentModel::EVENT_USER_MENTION, $event);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of Jitamin.
5			*
6			* Copyright (C) Jitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Jitamin\Bus\Job;
13
14			use Jitamin\Bus\EventBuilder\CommentEventBuilder;
15			use Jitamin\Model\CommentModel;
16
17			/**
18			* Class CommentEventJob.
19			*/
20			class CommentEventJob extends BaseJob
21			{
22			/**
23			* Set job params.
24			*
25			* @param int $commentId
26			* @param string $eventName
27			*
28			* @return $this
29			*/
30			public function withParams($commentId, $eventName)
31			{
32			$this->jobParams = [$commentId, $eventName];
33
34			return $this;
35			}
36
37			/**
38			* Execute job.
39			*
40			* @param int $commentId
41			* @param string $eventName
42			*
43			* @return $this
44			*/
45			public function execute($commentId, $eventName)
46			{
47			$event = CommentEventBuilder::getInstance($this->container)
48			->withCommentId($commentId)
49			->buildEvent();
50
51			if ($event !== null) {
52			$this->dispatcher->dispatch($eventName, $event);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `dispatcher` does not exist on `object<Jitamin\Bus\Job\CommentEventJob>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
53
54			if ($eventName === CommentModel::EVENT_CREATE) {
55			$this->userMentionModel->fireEvents($event['comment']['comment'], CommentModel::EVENT_USER_MENTION, $event);
			0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `userMentionModel` does not exist on `object<Jitamin\Bus\Job\CommentEventJob>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			}
57			}
58			}
59			}
60

Jitamin / jitamin

CommentEventJob A last analyzed 2017-12-27 06:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

CommentEventJob A
last analyzed 2017-12-27 06:16 UTC