TaskMoveColumnUnAssigned - Code Metrics - Jitamin/jitamin - Measure and Improve Code Quality continuously with Scrutinizer

TaskMoveColumnUnAssigned A
last analyzed 2017-12-27 06:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	88
loc	88
rs	10
c	0
b	0
f	0
wmc	7
lcom	0
cbo	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getDescription()	4	4	1
A	getCompatibleEvents()	7	7	1
A	getActionRequiredParameters()	7	7	1
A	getEventRequiredParameters()	13	13	1
A	doAction()	11	11	1
A	hasRequiredCondition()	4	4	2

How to fix Duplicated Code

<?php

/*
 * This file is part of Jitamin.
 *
 * Copyright (C) Jitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Jitamin\Action;

use Jitamin\Model\TaskModel;

/**
 * Move a task to another column when an assignee is cleared.
 */
class TaskMoveColumnUnAssigned extends Base

{
    /**
     * Get automatic action description.
     *
     * @return string
     */
    public function getDescription()
    {
        return t('Move the task to another column when assignee is cleared');
    }

    /**
     * Get the list of compatible events.
     *
     * @return array
     */
    public function getCompatibleEvents()
    {
        return [
            TaskModel::EVENT_ASSIGNEE_CHANGE,
            TaskModel::EVENT_UPDATE,
        ];
    }

    /**
     * Get the required parameter for the action (defined by the user).
     *
     * @return array
     */
    public function getActionRequiredParameters()
    {
        return [
            'src_column_id'  => t('Source column'),
            'dest_column_id' => t('Destination column'),
        ];
    }

    /**
     * Get the required parameter for the event.
     *
     * @return string[]
     */
    public function getEventRequiredParameters()
    {
        return [
            'task_id',
            'task' => [
                'project_id',
                'column_id',
                'owner_id',
                'position',
                'swimlane_id',
            ],
        ];
    }

    /**
     * Execute the action (move the task to another column).
     *
     * @param array $data Event data dictionary
     *
     * @return bool True if the action was executed or false when not executed
     */
    public function doAction(array $data)
    {
        return $this->taskPositionModel->movePosition(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $data['task']['project_id'],
            $data['task_id'],
            $this->getParam('dest_column_id'),
            $data['task']['position'],
            $data['task']['swimlane_id'],
            false
        );
    }

    /**
     * Check if the event data meet the action condition.
     *
     * @param array $data Event data dictionary
     *
     * @return bool
     */
    public function hasRequiredCondition(array $data)
    {
        return $data['task']['column_id'] == $this->getParam('src_column_id') && $data['task']['owner_id'] == 0;
    }
}


1		<?php
2
3		/*
4		* This file is part of Jitamin.
5		*
6		* Copyright (C) Jitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Jitamin\Action;
13
14		use Jitamin\Model\TaskModel;
15
16		/**
17		* Move a task to another column when an assignee is cleared.
18		*/
19	View Code Duplication	class TaskMoveColumnUnAssigned extends Base
		0 ignored issues – show Duplication introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		/**
22		* Get automatic action description.
23		*
24		* @return string
25		*/
26		public function getDescription()
27		{
28		return t('Move the task to another column when assignee is cleared');
29		}
30
31		/**
32		* Get the list of compatible events.
33		*
34		* @return array
35		*/
36		public function getCompatibleEvents()
37		{
38		return [
39		TaskModel::EVENT_ASSIGNEE_CHANGE,
40		TaskModel::EVENT_UPDATE,
41		];
42		}
43
44		/**
45		* Get the required parameter for the action (defined by the user).
46		*
47		* @return array
48		*/
49		public function getActionRequiredParameters()
50		{
51		return [
52		'src_column_id' => t('Source column'),
53		'dest_column_id' => t('Destination column'),
54		];
55		}
56
57		/**
58		* Get the required parameter for the event.
59		*
60		* @return string[]
61		*/
62		public function getEventRequiredParameters()
63		{
64		return [
65		'task_id',
66		'task' => [
67		'project_id',
68		'column_id',
69		'owner_id',
70		'position',
71		'swimlane_id',
72		],
73		];
74		}
75
76		/**
77		* Execute the action (move the task to another column).
78		*
79		* @param array $data Event data dictionary
80		*
81		* @return bool True if the action was executed or false when not executed
82		*/
83		public function doAction(array $data)
84		{
85		return $this->taskPositionModel->movePosition(
		0 ignored issues – show Documentation introduced 2016-12-21 12:32 UTC by Report Bug Copy Issue Report The property `taskPositionModel` does not exist on `object<Jitamin\Action\TaskMoveColumnUnAssigned>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
86		$data['task']['project_id'],
87		$data['task_id'],
88		$this->getParam('dest_column_id'),
89		$data['task']['position'],
90		$data['task']['swimlane_id'],
91		false
92		);
93		}
94
95		/**
96		* Check if the event data meet the action condition.
97		*
98		* @param array $data Event data dictionary
99		*
100		* @return bool
101		*/
102		public function hasRequiredCondition(array $data)
103		{
104		return $data['task']['column_id'] == $this->getParam('src_column_id') && $data['task']['owner_id'] == 0;
105		}
106		}
107

Jitamin / jitamin

TaskMoveColumnUnAssigned A last analyzed 2017-12-27 06:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

TaskMoveColumnUnAssigned A
last analyzed 2017-12-27 06:16 UTC