Jiad\Weather\WeatherController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	109
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	4	1
A	indexAction()	0	15	1
A	indexActionPost()	0	49	3

<?php

namespace Jiad\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Jiad\Modules\GeoTag;
use Jiad\Modules\Curl;

// use Anax\Route\Exception\ForbiddenException;
// use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * A sample controller to show how a controller class can be implemented.
 * The controller will be injected with $di if implementing the interface
 * ContainerInjectableInterface, like this sample class does.
 * The controller is mounted on a particular route and can then handle all
 * requests for that mount point.
 *
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class WeatherController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;




    /**
     * @var string $db a sample member variable that gets initialised
     */
    private $db = "not active";



    /**
     * The initialize method is optional and will always be called before the
     * target method/action. This is a convienient method where you could
     * setup internal properties that are commonly used by several methods.
     *
     * @return void
     */
    public function initialize() : void
    {
        // Use to initialise member variables.
        $this->db = "active";
    }

    /**
     * This is the index method action, it handles:
     * ANY METHOD mountpoint
     * ANY METHOD mountpoint/
     * ANY METHOD mountpoint/index
     *
     * @return string
     */
    public function indexAction() : object
    {
        $title = "Weather";
        $page = $this->di->get("page");

        $client_ip = $this->di->get("request")->getServer("REMOTE_ADDR", "127.0.0.1");

        $data = [
            "client_ip" => $client_ip,
        ];

        $page->add("weather/form", $data);

        return $page->render([
            "title" => $title
        ]);
    }


    /**
     * This is the Validate method action, it handles:
     * POST METHOD mountpoint/
     *
     * @return object
     */
    public function indexActionPost() : object
    {
        $page = $this->di->get("page");
        $title = "Weather Result";

        // Post
        $searchType = $this->di->request->getPost("searchType");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $search = $this->di->request->getPost("search");
        $time = $this->di->request->getPost("time");

        $test = "";

        $geotag = $this->di->get("geotag");

        $ipInfo = $geotag->getGeoInfo($search);


        $searchOptions = [
            "lat" => $ipInfo->latitude,
            "long" => $ipInfo->longitude
        ];

        $curl = $this->di->get("curl");

        $error = 0;
        $type = "";

        if ($time == "future") {
            $weatherInfo = $curl->sCurl($searchOptions); // Single Curl
        } else if ($time == "past") {
            $weatherInfo = $curl->mCurl($searchOptions); // Multi Curl
        }


        $data = [
            "searchType" => $searchType,
            "search" => $search,
            "time" => $time,
            "ipInfo" => $ipInfo,
            "test" => $test,
            "type" => $type,
            "error" => $error,
            "weatherInfo" => $weatherInfo

The variable $weatherInfo does not seem to be defined for all execution paths leading up to this point.

        ];

        $page->add("weather/weatherResult", $data);

        return $page->render([
            "title" => $title
        ]);
    }
}