TimSDK\Core\BaseIMCloud

Complexity

Total Complexity

6

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	httpPostJson()	0	4	2
A	httpPost()	0	4	1
A	__construct()	0	5	1
A	initialize()	0	2	1
A	request()	0	11	1

<?php
/**
 * Created by PhpStorm.
 * User: lenovo
 * Date: 6/14/2018
 * Time: 1:56 PM
 */

namespace TimSDK\Core;

use GuzzleHttp\Client;
use TimSDK\Support\Json;
use TimSDK\Foundation\Application;
use TimSDK\Foundation\ResponseBag;
use TimSDK\Container\ServiceContainer;
use Psr\Http\Message\ResponseInterface;

class BaseIMCloud
{
    /**
     * @var Application
     */
    protected $app;

    /**
     * AbstractTimSDKAPI constructor.
     * @param ServiceContainer $app
     */
    public function __construct(ServiceContainer $app)
    {
        $this->app = $app;

$app is of type TimSDK\Container\ServiceContainer, but the property $app was declared to be of type TimSDK\Foundation\Application. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->initialize();
    }

    /**
     * Init
     */
    public function initialize()
    {
    }

    /**
     * POST request.
     *
     * @param       $uri
     * @param array $data
     * @param array $options
     * @return ResponseBag
     */
    public function httpPost($uri, $data = [], $options = [])
    {
        return $this->request($uri, 'POST', array_merge($options, [
            'form_params' => $data
        ]));
    }

    /**
     * JSON request.
     *
     * @param       $uri
     * @param array $data
     * @param array $options
     * @return ResponseBag
     * @throws Exceptions\JsonParseException
     */
    public function httpPostJson($uri, $data = [], $options = [])
    {
        return $this->request($uri, 'POST', array_merge($options, [
            'body' => is_array($data) ? Json::encode($data) : $data

The condition is_array($data) is always true.

        ]));
    }

    /**
     * @param string $method
     * @param string $uri
     * @param array  $options
     * @return ResponseBag
     */
    public function request($uri, $method = 'GET', $options = [])
    {
        /**
         * @var ResponseInterface $response
         */
        $response = $this->app->httpClient->request($method, $uri, $options);

        return new ResponseBag(
            $response->getBody()->getContents(),
            $response->getHeaders(),
            $response->getStatusCode()
        );
    }
}