LazyDBConnectionProvider::getConnection() - Code Metrics - Inspection of "Modernize setup, PHP and MW requirements" - JeroenDeDauw/SubPageList - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by Jeroen De

created 2019-07-12 01:28 UTC

LazyDBConnectionProvider::getConnection() A

↳ Parent: LazyDBConnectionProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	9
ccs	5
cts	5
cp	1
crap	2
rs	9.9666
c	0
b	0
f	0

<?php

namespace SubPageList;

use DatabaseBase;

/**
 * Lazy database connection provider.
 * The connection is fetched when needed using the id provided in the constructor.
 *
 * @since 1.0
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class LazyDBConnectionProvider implements DBConnectionProvider {

	/**
	 * @var DatabaseBase|null
	 */
	private $connection = null;

	/**
	 * @var int|null
	 */
	private $connectionId = null;

	/**
	 * @var string|array
	 */
	private $groups;

	/**
	 * @var string|boolean $wiki
	 */
	private $wiki;

	/**
	 * Constructor.
	 *
	 * @since 1.0
	 *
	 * @param int $connectionId
	 * @param string|array $groups
	 * @param string|boolean $wiki
	 */
	public function __construct( $connectionId, $groups = [], $wiki = false ) {
		$this->connectionId = $connectionId;
		$this->groups = $groups;
		$this->wiki = $wiki;
	}

	/**
	 * @see DBConnectionProvider::getConnection
	 *
	 * @since 1.0
	 *
	 * @return DatabaseBase
	 */
	public function getConnection() {
		if ( $this->connection === null ) {
			$this->connection = wfGetLB( $this->wiki )->getConnection( $this->connectionId, $this->groups, $this->wiki );
		}

		assert( $this->connection instanceof DatabaseBase );


		return $this->connection;
	}

	/**
	 * @see DBConnectionProvider::releaseConnection
	 *
	 * @since 1.0
	 */
	public function releaseConnection() {
		if ( $this->wiki !== false && $this->connection !== null ) {
			wfGetLB( $this->wiki )->reuseConnection( $this->connection );
		}
	}

}

1		<?php
2
3		namespace SubPageList;
4
5		use DatabaseBase;
6
7		/**
8		* Lazy database connection provider.
9		* The connection is fetched when needed using the id provided in the constructor.
10		*
11		* @since 1.0
12		*
13		* @licence GNU GPL v2+
14		* @author Jeroen De Dauw < [email protected] >
15		*/
16		class LazyDBConnectionProvider implements DBConnectionProvider {
17
18		/**
19		* @var DatabaseBase\|null
20		*/
21		private $connection = null;
22
23		/**
24		* @var int\|null
25		*/
26		private $connectionId = null;
27
28		/**
29		* @var string\|array
30		*/
31		private $groups;
32
33		/**
34		* @var string\|boolean $wiki
35		*/
36		private $wiki;
37
38		/**
39		* Constructor.
40		*
41		* @since 1.0
42		*
43		* @param int $connectionId
44		* @param string\|array $groups
45		* @param string\|boolean $wiki
46		*/
47	26	public function __construct( $connectionId, $groups = [], $wiki = false ) {
48	26	$this->connectionId = $connectionId;
49	26	$this->groups = $groups;
50	26	$this->wiki = $wiki;
51	26	}
52
53		/**
54		* @see DBConnectionProvider::getConnection
55		*
56		* @since 1.0
57		*
58		* @return DatabaseBase
59		*/
60	25	public function getConnection() {
61	25	if ( $this->connection === null ) {
62	25	$this->connection = wfGetLB( $this->wiki )->getConnection( $this->connectionId, $this->groups, $this->wiki );
63		}
64
65	25	assert( $this->connection instanceof DatabaseBase );
		0 ignored issues – show Bug introduced 2016-01-05 11:28 UTC by Report Bug Copy Issue Report The class `DatabaseBase` does not exist. Is this class maybe located in a folder that is not analyzed, or in a newer version of your dependencies than listed in your composer.lock/composer.json? Loading history...
66
67	25	return $this->connection;
68		}
69
70		/**
71		* @see DBConnectionProvider::releaseConnection
72		*
73		* @since 1.0
74		*/
75	21	public function releaseConnection() {
76	21	if ( $this->wiki !== false && $this->connection !== null ) {
77		wfGetLB( $this->wiki )->reuseConnection( $this->connection );
78		}
79	21	}
80
81		}

JeroenDeDauw / SubPageList

Pull Request — master (#50)

LazyDBConnectionProvider::getConnection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like