PagesImporterCli::runImport() - Code Metrics - JeroenDeDauw/Replicator - Measure and Improve Code Quality continuously with Scrutinizer

PagesImporterCli::runImport() A
last analyzed 2019-04-21 21:30 UTC

↳ Parent: PagesImporterCli

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	9
cp	0
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Queryr\Replicator\Cli\Import;

use Queryr\Replicator\ServiceFactory;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class PagesImporterCli {

	/**
	 * @var InputInterface
	 */
	private $input;

	/**
	 * @var OutputInterface
	 */
	private $output;

	/**
	 * @var ServiceFactory
	 */
	private $factory = null;

	/**
	 * @var callable|null
	 */
	private $onAborted;

	public function __construct( InputInterface $input, OutputInterface $output,
			ServiceFactory $factory, callable $onAborted = null ) {

		$this->input = $input;
		$this->output = $output;
		$this->factory = $factory;
		$this->onAborted = $onAborted;
	}

	public function runImport( \Iterator $entityPageIterator ) {
		$pagesImporter = $this->factory->newPagesImporter(
			$this->newReporter(),
			new ConsoleStatsReporter( $this->output ),
			$this->onAborted
		);

		pcntl_signal( SIGINT, [ $pagesImporter, 'stop' ] );
		pcntl_signal( SIGTERM, [ $pagesImporter, 'stop' ] );

		$pagesImporter->importPages( $entityPageIterator );
	}

	private function newReporter() {
		return $this->output->isVerbose() ?
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			new VerboseReporter( $this->output, $this->output->isVeryVerbose() )
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			: new SimpleReporter( $this->output );
	}


}


1			<?php
2
3			namespace Queryr\Replicator\Cli\Import;
4
5			use Queryr\Replicator\ServiceFactory;
6			use Symfony\Component\Console\Input\InputInterface;
7			use Symfony\Component\Console\Output\OutputInterface;
8
9			/**
10			* @licence GNU GPL v2+
11			* @author Jeroen De Dauw < [email protected] >
12			*/
13			class PagesImporterCli {
14
15			/**
16			* @var InputInterface
17			*/
18			private $input;
19
20			/**
21			* @var OutputInterface
22			*/
23			private $output;
24
25			/**
26			* @var ServiceFactory
27			*/
28			private $factory = null;
29
30			/**
31			* @var callable\|null
32			*/
33			private $onAborted;
34
35			public function __construct( InputInterface $input, OutputInterface $output,
36			ServiceFactory $factory, callable $onAborted = null ) {
37
38			$this->input = $input;
39			$this->output = $output;
40			$this->factory = $factory;
41			$this->onAborted = $onAborted;
42			}
43
44			public function runImport( \Iterator $entityPageIterator ) {
45			$pagesImporter = $this->factory->newPagesImporter(
46			$this->newReporter(),
47			new ConsoleStatsReporter( $this->output ),
48			$this->onAborted
49			);
50
51			pcntl_signal( SIGINT, [ $pagesImporter, 'stop' ] );
52			pcntl_signal( SIGTERM, [ $pagesImporter, 'stop' ] );
53
54			$pagesImporter->importPages( $entityPageIterator );
55			}
56
57			private function newReporter() {
58			return $this->output->isVerbose() ?
			0 ignored issues – show Bug introduced 2016-01-02 05:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `isVerbose()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Output\BufferedOutput`, `Symfony\Component\Console\Output\ConsoleOutput`, `Symfony\Component\Console\Output\NullOutput`, `Symfony\Component\Console\Output\Output`, `Symfony\Component\Console\Output\StreamOutput`, `Symfony\Component\Consol...ts\Fixtures\DummyOutput`, `Symfony\Component\Console\Tests\Output\TestOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
59			new VerboseReporter( $this->output, $this->output->isVeryVerbose() )
			0 ignored issues – show Bug introduced 2016-01-02 05:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `isVeryVerbose()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Output\BufferedOutput`, `Symfony\Component\Console\Output\ConsoleOutput`, `Symfony\Component\Console\Output\NullOutput`, `Symfony\Component\Console\Output\Output`, `Symfony\Component\Console\Output\StreamOutput`, `Symfony\Component\Consol...ts\Fixtures\DummyOutput`, `Symfony\Component\Console\Tests\Output\TestOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
60			: new SimpleReporter( $this->output );
61			}
62
63
64			}
65

JeroenDeDauw / Replicator

PagesImporterCli::runImport() A last analyzed 2019-04-21 21:30 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

PagesImporterCli::runImport() A
last analyzed 2019-04-21 21:30 UTC