JsonDumpImportCommand::configure() - Code Metrics - JeroenDeDauw/Replicator - Measure and Improve Code Quality continuously with Scrutinizer

JsonDumpImportCommand::configure() A
last analyzed 2019-04-21 21:30 UTC

↳ Parent: JsonDumpImportCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	18
cts	18
cp	1
rs	9.536
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace Queryr\Replicator\Cli\Command;

use Queryr\Replicator\Cli\Import\PagesImporterCli;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Wikibase\JsonDumpReader\JsonDumpFactory;
use Wikibase\JsonDumpReader\SeekableDumpReader;

/**
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class JsonDumpImportCommand extends ImportCommandBase {

	protected function configure() {
		$this->setName( 'import:json' );
		$this->setDescription( 'Imports entities from an extracted JSON dump' );

		$this->addArgument(
			'file',
			InputArgument::REQUIRED,
			'Full path of the JSON dump file'
		);

		$this->addOption(
			'continue',
			'c',
			InputOption::VALUE_OPTIONAL,
			'The position to resume import from'
		);

		$this->addOption(
			'max',
			'm',
			InputOption::VALUE_OPTIONAL,
			'The maximum number of entities to import'
		);
	}

	protected function executeCommand( InputInterface $input, OutputInterface $output ) {
		$reader = ( new JsonDumpFactory() )->newExtractedDumpReader(
			$input->getArgument( 'file' ),

			$input->getOption( 'continue' ) === null ? 0 : (int)$input->getOption( 'continue' )
		);

		$onAborted = function() use ( $output, $reader ) {
			$output->writeln( "\n" );
			$output->writeln( "<info>Import process aborted</info>" );
			$output->writeln( "<comment>To resume, run with</comment> --continue=" . $reader->getPosition() );
		};

		$importer = new PagesImporterCli( $input, $output, $this->factory, $onAborted );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

		$iterator = $this->factory->newJsonEntityPageIterator( $reader );

		if ( is_numeric( $input->getOption( 'max' ) ) ) {
			$iterator = new \LimitIterator( $iterator, 0, (int)$input->getOption( 'max' ) );
		}

		$importer->runImport( $iterator );

		$this->outputMaxContinuation( $input, $output, $reader );
	}

	private function outputMaxContinuation( InputInterface $input, OutputInterface $output, SeekableDumpReader $reader ) {
		if ( is_numeric( $input->getOption( 'max' ) ) ) {
			$output->writeln(
				"\n<comment>To continue from current position, run with</comment> --continue=" . $reader->getPosition()
			);
		}
	}

}


1		<?php
2
3		namespace Queryr\Replicator\Cli\Command;
4
5		use Queryr\Replicator\Cli\Import\PagesImporterCli;
6		use Symfony\Component\Console\Input\InputArgument;
7		use Symfony\Component\Console\Input\InputInterface;
8		use Symfony\Component\Console\Input\InputOption;
9		use Symfony\Component\Console\Output\OutputInterface;
10		use Wikibase\JsonDumpReader\JsonDumpFactory;
11		use Wikibase\JsonDumpReader\SeekableDumpReader;
12
13		/**
14		* @licence GNU GPL v2+
15		* @author Jeroen De Dauw < [email protected] >
16		*/
17		class JsonDumpImportCommand extends ImportCommandBase {
18
19	3	protected function configure() {
20	3	$this->setName( 'import:json' );
21	3	$this->setDescription( 'Imports entities from an extracted JSON dump' );
22
23	3	$this->addArgument(
24	3	'file',
25	3	InputArgument::REQUIRED,
26	3	'Full path of the JSON dump file'
27		);
28
29	3	$this->addOption(
30	3	'continue',
31	3	'c',
32	3	InputOption::VALUE_OPTIONAL,
33	3	'The position to resume import from'
34		);
35
36	3	$this->addOption(
37	3	'max',
38	3	'm',
39	3	InputOption::VALUE_OPTIONAL,
40	3	'The maximum number of entities to import'
41		);
42	3	}
43
44	3	protected function executeCommand( InputInterface $input, OutputInterface $output ) {
45	3	$reader = ( new JsonDumpFactory() )->newExtractedDumpReader(
46	3	$input->getArgument( 'file' ),
		0 ignored issues – show Bug introduced 2019-04-21 21:30 UTC by Report Bug Copy Issue Report It seems like `$input->getArgument('file')` targeting `Symfony\Component\Consol...nterface::getArgument()` can also be of type `array<integer,string>` or `null`; however, `Wikibase\JsonDumpReader\...ewExtractedDumpReader()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
47	3	$input->getOption( 'continue' ) === null ? 0 : (int)$input->getOption( 'continue' )
48		);
49
50	3	$onAborted = function() use ( $output, $reader ) {
51		$output->writeln( "\n" );
52		$output->writeln( "<info>Import process aborted</info>" );
53		$output->writeln( "<comment>To resume, run with</comment> --continue=" . $reader->getPosition() );
54	3	};
55
56	3	$importer = new PagesImporterCli( $input, $output, $this->factory, $onAborted );
		0 ignored issues – show Bug introduced 2016-01-09 20:24 UTC by Report Bug Copy Issue Report It seems like `$this->factory` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
57
58	3	$iterator = $this->factory->newJsonEntityPageIterator( $reader );
59
60	3	if ( is_numeric( $input->getOption( 'max' ) ) ) {
61	1	$iterator = new \LimitIterator( $iterator, 0, (int)$input->getOption( 'max' ) );
62		}
63
64	3	$importer->runImport( $iterator );
65
66	3	$this->outputMaxContinuation( $input, $output, $reader );
67	3	}
68
69	3	private function outputMaxContinuation( InputInterface $input, OutputInterface $output, SeekableDumpReader $reader ) {
70	3	if ( is_numeric( $input->getOption( 'max' ) ) ) {
71	1	$output->writeln(
72	1	"\n<comment>To continue from current position, run with</comment> --continue=" . $reader->getPosition()
73		);
74		}
75	3	}
76
77		}
78

JeroenDeDauw / Replicator

JsonDumpImportCommand::configure() A last analyzed 2019-04-21 21:30 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

JsonDumpImportCommand::configure() A
last analyzed 2019-04-21 21:30 UTC