Queryr\Replicator\Cli\Command\Bz2JsonImportCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

92.86%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	17	1
A	executeCommand()	0	20	2

<?php

namespace Queryr\Replicator\Cli\Command;

use Queryr\Replicator\Cli\Import\PagesImporterCli;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Wikibase\JsonDumpReader\JsonDumpFactory;

/**
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 */
class Bz2JsonImportCommand extends ImportCommandBase {

	protected function configure() {
		$this->setName( 'import:bz2' );
		$this->setDescription( 'Imports entities from a bzip2 compressed JSON dump' );

		$this->addArgument(
			'file',
			InputArgument::REQUIRED,
			'Full path of the bz2 JSON dump file'
		);

		$this->addOption(
			'max',
			'm',
			InputOption::VALUE_OPTIONAL,
			'The maximum number of entities to import'
		);
	}

	protected function executeCommand( InputInterface $input, OutputInterface $output ) {
		$importer = new PagesImporterCli(
			$input,
			$output,
			$this->factory,

It seems like $this->factory can be null; however, __construct() does not accept null, maybe add an additional type check?

			function() use ( $output ) {
				$output->writeln( "\n" );
				$output->writeln( "<info>Import process aborted</info>" );
			}
		);

		$dumpReader = ( new JsonDumpFactory() )->newBz2DumpReader( $input->getArgument( 'file' ) );

It seems like $input->getArgument('file') targeting Symfony\Component\Console\Input\InputInterface::getArgument() can also be of type array<integer,string> or null; however, Wikibase\JsonDumpReader\JsonDumpFactory::newBz2DumpReader() does only seem to accept string, maybe add an additional type check?

		$iterator = $this->factory->newJsonEntityPageIterator( $dumpReader );

		if ( is_numeric( $input->getOption( 'max' ) ) ) {
			$iterator = new \LimitIterator( $iterator, 0, (int)$input->getOption( 'max' ) );
		}

		$importer->runImport( $iterator );
	}

}