DimensionParser::parse() - Code Metrics - Inspection of "Fix issue in dimension param" - JeroenDeDauw/ParamProcessor - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 45441d...6fcca7 )

by Jeroen De

created 2019-08-03 15:18 UTC

DimensionParser::parse() A

↳ Parent: DimensionParser

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.8333
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	3

<?php

namespace ParamProcessor\PackagePrivate;

use ValueParsers\ParseException;
use ValueParsers\ParserOptions;
use ValueParsers\ValueParser;

/**
 * Package private
 */
class DimensionParser implements ValueParser {

	public const DEFAULT_UNIT = 'defaultunit';

	public const PIXELS = 'px';

	private $defaultUnit;

	public function __construct( ParserOptions $options = null ) {
		$options = $options ?? new ParserOptions();

		$this->defaultUnit = $options->hasOption( self::DEFAULT_UNIT ) ? $options->getOption( self::DEFAULT_UNIT ) : self::PIXELS;
	}

	public function parse( $value ) {
		if ( !is_string( $value ) ) {
			throw new ParseException( 'Not a string' );
		}

		$value = $this->removeWhitespace( $value );

		if ( preg_match( '/^(\d|\.)+$/', $value ) ) {
			$value .= $this->defaultUnit;
		}

		return $value;
	}

	private function removeWhitespace( string $string ): string {
		return preg_replace( '/\s+/', '', $string );
	}

}


1		<?php
2
3		namespace ParamProcessor\PackagePrivate;
4
5		use ValueParsers\ParseException;
6		use ValueParsers\ParserOptions;
7		use ValueParsers\ValueParser;
8
9		/**
10		* Package private
11		*/
12		class DimensionParser implements ValueParser {
13
14		public const DEFAULT_UNIT = 'defaultunit';
15
16		public const PIXELS = 'px';
17
18		private $defaultUnit;
19
20	40	public function __construct( ParserOptions $options = null ) {
21	40	$options = $options ?? new ParserOptions();
22
23	40	$this->defaultUnit = $options->hasOption( self::DEFAULT_UNIT ) ? $options->getOption( self::DEFAULT_UNIT ) : self::PIXELS;
24	40	}
25
26	40	public function parse( $value ) {
27	40	if ( !is_string( $value ) ) {
28	1	throw new ParseException( 'Not a string' );
29		}
30
31	39	$value = $this->removeWhitespace( $value );
32
33	39	if ( preg_match( '/^(\d\|\.)+$/', $value ) ) {
34	10	$value .= $this->defaultUnit;
35		}
36
37	39	return $value;
38		}
39
40	39	private function removeWhitespace( string $string ): string {
41	39	return preg_replace( '/\s+/', '', $string );
42		}
43
44		}
45

JeroenDeDauw / ParamProcessor

Push — master ( 45441d...6fcca7 )

DimensionParser::parse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like