DimensionParamTest::valueProvider() - Code Metrics - Inspection of "Deprecate parameter dependencies" - JeroenDeDauw/ParamProcessor - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 761e95...f1e6ba )

by Jeroen De

created 2019-07-29 18:35 UTC

DimensionParamTest::valueProvider() B

↳ Parent: DimensionParamTest

Complexity

Conditions	6
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	8.4032
c	0
b	0
f	0
cc	6
nc	2
nop	1

How to fix Long Method

<?php

namespace ParamProcessor\Tests\Integration\Definitions;

/**
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class DimensionParamTest extends ParamDefinitionTest {

	/**
	 * @see ParamDefinitionTest::getDefinitions
	 * @return array
	 */
	public function getDefinitions() {
		$params = parent::getDefinitions();

		$params['auto'] = [
			'allowauto' => true,
		];

		$params['allunits'] = [
			'units' => [ 'px', 'ex', 'em', '%', '' ],
		];

		$params['bounds'] = [
			'lowerbound' => 42,
			'upperbound' => 9000,
			'maxpercentage' => 34,
			'minpercentage' => 23,
			'units' => [ 'px', 'ex', '%', '' ],
		];

		return $params;
	}

	/**
	 * @see ParamDefinitionTest::valueProvider
	 *
	 * @param boolean $stringlyTyped
	 *
	 * @return array
	 */
	public function valueProvider( $stringlyTyped = true ) {
		$values = [
			'empty' => [
				[ '100px', true, '100px' ],
				[ '100', true, '100px' ],
				[ 42, true, '42px' ],
				[ 42.5, true, '42.5px' ],
				[ 'over9000', false ],
				[ 'yes', false ],
				[ 'auto', false ],
				[ '100%', false ],
			],
			'values' => [
				[ 1, true, '1px' ],
//				array( 2, false ),
				[ 'yes', false ],
				[ 'no', false ],
			],
			'auto' => [
				[ 'auto', true, 'auto' ],
			],
			'allunits' => [
				[ '100%', true, '100%' ],
				[ '100em', true, '100em' ],
				[ '100ex', true, '100ex' ],
				[ '101%', false ],
			],
			'bounds' => [
				[ '30%', true, '30%' ],
				[ '20%', false ],
				[ '40%', false ],
				[ '100px', true, '100px' ],
				[ '100ex', true, '100ex' ],
				[ '10px', false ],
				[ '9001ex', false ],
			],
		];

		if ( $stringlyTyped ) {
			foreach ( $values as &$set ) {
				foreach ( $set as &$value ) {
					if ( is_int( $value[0] ) || is_float( $value[0] ) ) {
						$value[0] = (string)$value[0];
					}
				}
			}

//			$values['empty'][] = array( 42, false );
//			$values['empty'][] = array( 42.5, false );
		}

		return $values;
	}

	/**
	 * @see ParamDefinitionTest::getType
	 * @return string
	 */
	public function getType() {
		return 'dimension';
	}

}


1			<?php
2
3			namespace ParamProcessor\Tests\Integration\Definitions;
4
5			/**
6			* @licence GNU GPL v2+
7			* @author Jeroen De Dauw < [email protected] >
8			*/
9			class DimensionParamTest extends ParamDefinitionTest {
10
11			/**
12			* @see ParamDefinitionTest::getDefinitions
13			* @return array
14			*/
15			public function getDefinitions() {
16			$params = parent::getDefinitions();
17
18			$params['auto'] = [
19			'allowauto' => true,
20			];
21
22			$params['allunits'] = [
23			'units' => [ 'px', 'ex', 'em', '%', '' ],
24			];
25
26			$params['bounds'] = [
27			'lowerbound' => 42,
28			'upperbound' => 9000,
29			'maxpercentage' => 34,
30			'minpercentage' => 23,
31			'units' => [ 'px', 'ex', '%', '' ],
32			];
33
34			return $params;
35			}
36
37			/**
38			* @see ParamDefinitionTest::valueProvider
39			*
40			* @param boolean $stringlyTyped
41			*
42			* @return array
43			*/
44			public function valueProvider( $stringlyTyped = true ) {
45			$values = [
46			'empty' => [
47			[ '100px', true, '100px' ],
48			[ '100', true, '100px' ],
49			[ 42, true, '42px' ],
50			[ 42.5, true, '42.5px' ],
51			[ 'over9000', false ],
52			[ 'yes', false ],
53			[ 'auto', false ],
54			[ '100%', false ],
55			],
56			'values' => [
57			[ 1, true, '1px' ],
58			// array( 2, false ),
59			[ 'yes', false ],
60			[ 'no', false ],
61			],
62			'auto' => [
63			[ 'auto', true, 'auto' ],
64			],
65			'allunits' => [
66			[ '100%', true, '100%' ],
67			[ '100em', true, '100em' ],
68			[ '100ex', true, '100ex' ],
69			[ '101%', false ],
70			],
71			'bounds' => [
72			[ '30%', true, '30%' ],
73			[ '20%', false ],
74			[ '40%', false ],
75			[ '100px', true, '100px' ],
76			[ '100ex', true, '100ex' ],
77			[ '10px', false ],
78			[ '9001ex', false ],
79			],
80			];
81
82			if ( $stringlyTyped ) {
83			foreach ( $values as &$set ) {
84			foreach ( $set as &$value ) {
85			if ( is_int( $value[0] ) \|\| is_float( $value[0] ) ) {
86			$value[0] = (string)$value[0];
87			}
88			}
89			}
90
91			// $values['empty'][] = array( 42, false );
92			// $values['empty'][] = array( 42.5, false );
93			}
94
95			return $values;
96			}
97
98			/**
99			* @see ParamDefinitionTest::getType
100			* @return string
101			*/
102			public function getType() {
103			return 'dimension';
104			}
105
106			}
107

JeroenDeDauw / ParamProcessor

Push — master ( 761e95...f1e6ba )

DimensionParamTest::valueProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like