JeroenDeDauw / Maps

includes/ServiceParam.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
 	 * @param IParamDefinition[] $definitions
 	 * @param IParam[] $params
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	protected function formatValue( $value, IParam $param, array &$definitions, array $params ) {
 		// Make sure the service is valid.

src/Maps/Elements/Location.php

Doc Comments +1 added lines, -1 removed lines

@@ -232,7 +232,7 @@
 	 *
 	 * @since 2.0
 	 *
-	 * @return string
+	 * @return boolean
 	 */
 	public function hasGroup() {
 		return $this->group !== '';

includes/parserhooks/Maps_Coordinates.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 *
 	 * @param $type
 	 * 
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getDefaultParameters( $type ) {
 		return array( 'location1', 'location2', 'unit', 'decimals' );

includes/parserhooks/Maps_Distance.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 *
 	 * @param $type
 	 * 
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getDefaultParameters( $type ) {
 		return array( 'location1', 'location2', 'unit', 'decimals' );

includes/parserhooks/Maps_Finddestination.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 *
 	 * @param $type
 	 * 
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getDefaultParameters( $type ) {
 		return array( 'location1', 'location2', 'unit', 'decimals' );

includes/parserhooks/Maps_Geocode.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 *
 	 * @param $type
 	 * 
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getDefaultParameters( $type ) {
 		return array( 'location1', 'location2', 'unit', 'decimals' );

Maps.hooks.php

Doc Comments +5 added lines, -5 removed lines

@@ -100,7 +100,7 @@ 
 	 *
 	 * @param DatabaseUpdater $updater
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public static function onLoadExtensionSchemaUpdates( DatabaseUpdater $updater ) {
 		switch( $GLOBALS['wgDBtype'] ) {
@@ -122,7 +122,7 @@ 
 	 * @since 3.0
 	 *
 	 * @param $article WikiPage|Article (depending on MW version, WikiPage in 1.18+)
-	 * @return type
+	 * @return boolean
 	 */
 	public static function onArticlePurge( &$article ) {
 		self::$purgedBeforeStore = true;
@@ -137,7 +137,7 @@ 
 	 * @param Parser &$parser
 	 * @param string &$text
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public static function onParserAfterTidy( Parser &$parser, &$text ) {
 
@@ -165,7 +165,7 @@ 
 	 *
 	 * @param LinksUpdate &$linksUpdate
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public static function onLinksUpdateConstructed( LinksUpdate &$linksUpdate ) {
 		$title = $linksUpdate->getTitle();
@@ -209,7 +209,7 @@ 
 	 *
 	 * @param Parser $parser
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public static function onParserClearState( Parser &$parser ) {
 		$parser->getOutput()->mExtMapsLayers = null;

includes/geocoders/Maps_GoogleGeocoder.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 *
 	 * @param $type
 	 * 
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getDefaultParameters( $type ) {
 		return array( 'location1', 'location2', 'unit', 'decimals' );

includes/Geocoders.php

Doc Comments +6 added lines, -3 removed lines

@@ -124,7 +124,7 @@ 
 	 * @param string|false $mappingService
 	 * @param boolean $checkForCoords
 	 *
-	 * @return LatLongValue|false
+	 * @return LatLongValue
 	 */
 	public static function attemptToGeocode( $coordsOrAddress, $geoservice = '', $mappingService = false, $checkForCoords = true ) {
 		if ( $checkForCoords ) {
@@ -200,7 +200,7 @@ 
 	 * @param string $geoService
 	 * @param string|false $mappingService
 	 *
-	 * @return LatLongValue|false
+	 * @return LatLongValue
 	 * @throws MWException
 	 */
 	public static function geocode( $address, $geoService = '', $mappingService = false ) {
@@ -240,6 +240,9 @@ 
 		return $coordinates;
 	}
 
+	/**
+	 * @param string $address
+	 */
 	private static function getGeocoded( Geocoder $geocoder, $address ) {
 		$coordinates = self::getGeocodedAsArray( $geocoder, $address );
 
@@ -373,7 +376,7 @@ 
 	 *
 	 * @param string $geocoderIdentifier
 	 *
-	 * @return string|bool
+	 * @return string
 	 * @throws MWException
 	 */
 	protected static function getValidGeocoderIdentifier( $geocoderIdentifier ) {