ImageOverlayParser::stringParse() - Code Metrics - Inspection of "Merge pull request #328 from JeroenDeDauw/dvgeo" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 200886...a4bdfd )

by Jeroen De

created 2017-05-13 23:52 UTC

ImageOverlayParser::stringParse() A

↳ Parent: ImageOverlayParser

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	9
nc	2
nop	1
dl	0
loc	14
ccs	0
cts	11
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace Maps;

use DataValues\Geo\Parsers\GeoCoordinateParser;
use Maps\Elements\ImageOverlay;
use Maps\Elements\WmsOverlay;
use ValueParsers\ParseException;
use ValueParsers\StringValueParser;

/**
 * @since 3.1
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class ImageOverlayParser extends StringValueParser {

	/**
	 * @since 3.1
	 *
	 * @param string $value
	 *
	 * @return WmsOverlay
	 * @throws ParseException
	 */
	protected function stringParse( $value ) {
		$parameters = explode( '~', $value );
		$imageParameters = explode( ':', $parameters[0], 3 );

		if ( count( $imageParameters ) === 3 ) {
			$boundsNorthEast = $this->stringToLatLongValue( $imageParameters[0] );
			$boundsSouthWest = $this->stringToLatLongValue( $imageParameters[1] );
			$imageUrl = \MapsMapper::getFileUrl( $imageParameters[2] );


			return new ImageOverlay( $boundsNorthEast, $boundsSouthWest, $imageUrl );
		}

		throw new ParseException( 'Need 3 parameters for an image overlay' );
	}

	private function stringToLatLongValue( $location ) {
		$parser = new GeoCoordinateParser( new \ValueParsers\ParserOptions() );

		return $parser->parse( $location );
	}

}


1			<?php
2
3			namespace Maps;
4
5			use DataValues\Geo\Parsers\GeoCoordinateParser;
6			use Maps\Elements\ImageOverlay;
7			use Maps\Elements\WmsOverlay;
8			use ValueParsers\ParseException;
9			use ValueParsers\StringValueParser;
10
11			/**
12			* @since 3.1
13			*
14			* @licence GNU GPL v2+
15			* @author Jeroen De Dauw < [email protected] >
16			*/
17			class ImageOverlayParser extends StringValueParser {
18
19			/**
20			* @since 3.1
21			*
22			* @param string $value
23			*
24			* @return WmsOverlay
25			* @throws ParseException
26			*/
27			protected function stringParse( $value ) {
28			$parameters = explode( '~', $value );
29			$imageParameters = explode( ':', $parameters[0], 3 );
30
31			if ( count( $imageParameters ) === 3 ) {
32			$boundsNorthEast = $this->stringToLatLongValue( $imageParameters[0] );
33			$boundsSouthWest = $this->stringToLatLongValue( $imageParameters[1] );
34			$imageUrl = \MapsMapper::getFileUrl( $imageParameters[2] );
			0 ignored issues – show Deprecated Code introduced 2015-12-04 20:45 UTC by Report Bug Copy Issue Report The method `MapsMapper::getFileUrl()` has been deprecated. This method has been deprecated. Loading history...
35
36			return new ImageOverlay( $boundsNorthEast, $boundsSouthWest, $imageUrl );
37			}
38
39			throw new ParseException( 'Need 3 parameters for an image overlay' );
40			}
41
42			private function stringToLatLongValue( $location ) {
43			$parser = new GeoCoordinateParser( new \ValueParsers\ParserOptions() );
			0 ignored issues – show Deprecated Code introduced 2017-05-13 23:47 UTC by Report Bug Copy Issue Report The class `DataValues\Geo\Parsers\GeoCoordinateParser` has been deprecated with message: since 2.0, use the base class instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
44			return $parser->parse( $location );
45			}
46
47			}
48

JeroenDeDauw / Maps

Push — master ( 200886...a4bdfd )

ImageOverlayParser::stringParse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like